Skip to contentSkip to conversation

Fix client-pending-auth error message to say ERROR instead of SUCCESS

PATCH In review Arne Schwabe 3 participants 3 messages May 23, 2022 – May 24, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix client-pending-auth error message to say ERROR instead of SUCCESS

---
 src/openvpn/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/manage.c +1 -1
index aeea5f9ff..9c07bf298 100644
@@ -989,7 +989,7 @@ man_client_pending_auth(struct management *man, const char *cid_str,
             }
             else
             {
-                msg(M_CLIENT, "SUCCESS: client-pending-auth command failed."
+                msg(M_CLIENT, "ERROR: client-pending-auth command failed."
                     " Extra paramter might be too long");
             }
         }
Signature · 1 line
2.32.0 (Apple Git-132)
Acked-by on v1 1/1
#1 lore raw

Trivial.

Quoted 12 lines

Arne Schwabe <[email protected]...> hat am 23.05.2022 11:17 geschrieben:

---
 src/openvpn/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/manage.c +0 -0
index aeea5f9ff..9c07bf298 100644

src/openvpn/manage.c man_client_pending_auth(struct management *man, const char *cid_str, · line 993

Quoted 6 lines
src/openvpn/manage.c +1 -1
@@ -989,7 +989,7 @@ man_client_pending_auth(struct management *man, const char *cid_str,
             }
             else
             {
-                msg(M_CLIENT, "SUCCESS: client-pending-auth command failed."
+                msg(M_CLIENT, "ERROR: client-pending-auth command failed."
                     " Extra paramter might be too long");

We might want to fix "parameter" at the same time.

Regards,
--
Frank Lichtenheld

#2 lore raw
In reply to Arne Schwabe

"paramter" adjusted as suggested. SOB added.

Your patch has been applied to the master and release/2.5 branch.

commit d681e9d42e11b08668fae6e7b61d6a040c93082d (master) commit 5288c578b8b45dc1486bd51811a3e4462a8a9597 (release/2.5)

Author: Arne Schwabe
Date:   Mon May 23 11:17:24 2022 +0200
     Fix client-pending-auth error message to say ERROR instead of SUCCESS

     Acked-by: Frank Lichtenheld <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg24421.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering