Skip to contentSkip to conversation

drm/msm/disp/dpu1: remove supoerflous init

PATCH Superseded Vinod Koul 4 participants 4 messages May 24, 2022

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

PATCH 1/1 drm/msm/disp/dpu1: remove supoerflous init

Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init.

Fixes 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -1
index 51f24ba68375..388125c8bda1 100644
@@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc,
 		}
 	}
 
-	dsc_common_mode = 0;
 	pic_width = dsc->drm->pic_width;
 
 	dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Vinod Koul

Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init.

Fixes 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")
Quoted 19 lines
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -2
index 51f24ba68375..388125c8bda1 100644
@@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc,
                }
        }
 
-       dsc_common_mode = 0;
        pic_width = dsc->drm->pic_width;
 
        dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
--

2.34.1

Signature · 2 lines
With best wishes
Dmitry
#2 lore raw
In reply to Vinod Koul
Quoted 12 lines

-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Vinod Koul
Sent: Tuesday, May 24, 2022 6:36 AM
To: Dmitry Baryshkov <[email protected]>
Cc: Liu, Yujie <[email protected]>; [email protected]; Abhinav Kumar <[email protected]>; [email protected]; Bjorn Andersson <[email protected]>; Vinod Koul <[email protected]>; [email protected]
Subject: [PATCH] drm/msm/disp/dpu1: remove supoerflous init

s/supoerflous/superfluous/

m

Quoted 28 lines

Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init.

Fixes 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")

---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -

1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -1
index 51f24ba68375..388125c8bda1 100644
@@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct
 dpu_encoder_virt *dpu_enc,
 		}
 	}
 
-	dsc_common_mode = 0;
 	pic_width = dsc->drm->pic_width;
 

dsc_common_mode = DSC_MODE_MULTIPLEX |
DSC_MODE_SPLIT_PANEL;
--
2.34.1

Reviewed-by on v1 1/1
#3 lore raw
In reply to Vinod Koul
Quoted 3 lines · Vinod Koul

Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init.

Both in the subject line and here, typo
supoerflous ---> superfluous

Other than that,

Quoted 20 lines
Fixes 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +0 -1
index 51f24ba68375..388125c8bda1 100644
@@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc,
  		}
  	}
 
-	dsc_common_mode = 0;
  	pic_width = dsc->drm->pic_width;
 
  	dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;