Skip to contentSkip to conversation

May 24, 2022

PATCH In review Jasdeep Dhillon 2 participants 2 messages May 24, 2022 – May 25, 2022

lore
Share & tools
lore
#0 lore raw

cover May 24, 2022

This DC patchset brings improvements in multiple areas. In summary, we highlight:

*Changes to DP LT fallback behavior to more closely match the DP standard *Added new interfaces for lut pipeline
*Restore ref_dtblck value when clk struct is cleared in init_clocks *Fixes DMUB outbox trace in S4
*Fixes lingering DIO FIFO errors when DIO no longer enabled *Reads Golden Settings Table from VBIOS

Alvin (1):
drm/amd/display: Don't clear ref_dtbclk value

Aric Cyr (1):
drm/amd/display: 3.2.187

Hung, Cruise (1):
drm/amd/display: Fix DMUB outbox trace in S4 (#4465)

Ilya (1):
drm/amd/display: Fix possible infinite loop in DP LT fallback

Leung, Martin (2):
drm/amd/display: revert Blank eDP on disable/enable drv Prepare for new interfaces

Nicholas Kazlauskas (1):
drm/amd/display: Pass the new context into disable OTG WA

hengzhou (1):
drm/amd/display: Wait DMCUB to idle state before reset.

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   2 +
 .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c  |  19 ++-
 .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h  |   2 +
 .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c        |  13 +-
 .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c        |  11 +-
 drivers/gpu/drm/amd/display/dc/core/dc_link.c |  17 +-
 .../gpu/drm/amd/display/dc/core/dc_link_dp.c  | 158 +++++++++---------
 drivers/gpu/drm/amd/display/dc/dc.h           |   6 +-
 .../display/dc/dce110/dce110_hw_sequencer.c   |  23 ++-
 .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c |  79 ++++-----
 .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h |   2 +-
 .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h   |   1 +
 drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h  |  20 ++-
 drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h   |   5 +
 .../amd/display/dc/inc/hw_sequencer_private.h |   2 +
 .../amd/display/dc/link/link_hwss_hpo_dp.c    |  19 ++-
 .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c |  11 +-
 .../gpu/drm/amd/display/dmub/src/dmub_dcn31.h |   3 +-
 .../amd/display/include/ddc_service_types.h   |   2 +
 19 files changed, 233 insertions(+), 162 deletions(-)
Signature · 1 line
2.25.1
Tested-by on the v1 series
#1 lore raw

[AMD Official Use Only - General]

Hi all,

This week this patchset was tested on the following systems:

HP Envy 360, with Ryzen 5 4500U
Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U
Sapphire Pulse RX5700XT
Reference AMD RX6800
Engineering board with Ryzen 9 5900H

These systems were tested on the following display types:
eDP, (1080p 60hz [4500U, 5650U, 5900H])
VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters])

MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays
DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays

The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to):
Changing display configurations and settings
Benchmark testing
Feature testing (Freesync, etc.)

Automated testing includes (but is not limited to):
Script testing (scripts to automate some of the manual checks) IGT testing

The patchset consists of the most recent amd-staging-drm-next (Head commit - da38a66ac46e334f198afcd1b4d4554b4ddca0df - drm/amdgpu: Ensure the DMA engine is deactivated during set ups) branch with a selection of patches added on top of it. This goes for both Ubuntu testing and Chrome OS testing.

Tested on Ubuntu 22.04 and Chrome OS

Thank you,

Dan Wheeler
Technologist | AMD
SW Display
------------------------------------------------------------------------------------------------------------------
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Jasdeep Dhillon
Sent: May 24, 2022 1:47 PM
To: [email protected]
Cc: Wang, Chao-kai (Stylon) <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Wentland, Harry <[email protected]>; Zhuo, Qingqing (Lillian) <[email protected]>; Dhillon, Jasdeep <[email protected]>; Siqueira, Rodrigo <[email protected]>; Li, Roman <[email protected]>; Chiu, Solomon <[email protected]>; Pillai, Aurabindo <[email protected]>; Lin, Wayne <[email protected]>; Lakha, Bhawanpreet <[email protected]>; Gutierrez, Agustin <[email protected]>; Kotarac, Pavle <[email protected]>
Subject: [PATCH 0/8] May 24, 2022

This DC patchset brings improvements in multiple areas. In summary, we highlight:

*Changes to DP LT fallback behavior to more closely match the DP standard *Added new interfaces for lut pipeline *Restore ref_dtblck value when clk struct is cleared in init_clocks *Fixes DMUB outbox trace in S4 *Fixes lingering DIO FIFO errors when DIO no longer enabled *Reads Golden Settings Table from VBIOS

Alvin (1):
drm/amd/display: Don't clear ref_dtbclk value

Aric Cyr (1):
drm/amd/display: 3.2.187

Hung, Cruise (1):
drm/amd/display: Fix DMUB outbox trace in S4 (#4465)

Ilya (1):
drm/amd/display: Fix possible infinite loop in DP LT fallback

Leung, Martin (2):
drm/amd/display: revert Blank eDP on disable/enable drv Prepare for new interfaces

Nicholas Kazlauskas (1):
drm/amd/display: Pass the new context into disable OTG WA

hengzhou (1):
drm/amd/display: Wait DMCUB to idle state before reset.

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   2 +
 .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c  |  19 ++-
 .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h  |   2 +
 .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c        |  13 +-
 .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c        |  11 +-
 drivers/gpu/drm/amd/display/dc/core/dc_link.c |  17 +-  .../gpu/drm/amd/display/dc/core/dc_link_dp.c  | 158 +++++++++---------
 drivers/gpu/drm/amd/display/dc/dc.h           |   6 +-
 .../display/dc/dce110/dce110_hw_sequencer.c   |  23 ++-
 .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c |  79 ++++-----
 .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h |   2 +-
 .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h   |   1 +
 drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h  |  20 ++-
 drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h   |   5 +
 .../amd/display/dc/inc/hw_sequencer_private.h |   2 +
 .../amd/display/dc/link/link_hwss_hpo_dp.c    |  19 ++-
 .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c |  11 +-
 .../gpu/drm/amd/display/dmub/src/dmub_dcn31.h |   3 +-
 .../amd/display/include/ddc_service_types.h   |   2 +
 19 files changed, 233 insertions(+), 162 deletions(-)

--
2.25.1