package/midori: add missing !BR2_PACKAGE_GNUPG dependency
PATCH 1/1 package/midori: add missing !BR2_PACKAGE_GNUPG dependency
The !BR2_PACKAGE_GNUPG needs to be propagated from BR2_PACKAGE_GCR.
Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_GCR
Depends on [n]: BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && !BR2_STATIC_LIBS [=n] && !BR2_PACKAGE_GNUPG [=y]
Selected by [y]:
- BR2_PACKAGE_MIDORI [=y] && BR2_PACKAGE_MIDORI_ARCH_SUPPORTS [=y] && !BR2_STATIC_LIBS [=n] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_HOST_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_USES_GLIBC [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=y] && BR2_USE_WCHAR [=y] && BR2_PACKAGE_LIBGTK3 [=y] && (BR2_PACKAGE_LIBGTK3_X11 [=y] || BR2_PACKAGE_LIBGTK3_WAYLAND [=n])
--- package/midori/Config.in | 1 + 1 file changed, 1 insertion(+)
package/midori/Config.in +1 -0
@@ -25,6 +25,7 @@ config BR2_PACKAGE_MIDORI bool "midori" depends on BR2_PACKAGE_MIDORI_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS # webkitgtk + depends on !BR2_PACKAGE_GNUPG # gcr depends on BR2_INSTALL_LIBSTDCPP # webkitgtk depends on BR2_HOST_GCC_AT_LEAST_8 # gobject-introspection depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # webkitgtk
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Arnout Vandecappelle
AppliedQuoted 18 lines · James Hilliard
The !BR2_PACKAGE_GNUPG needs to be propagated from
BR2_PACKAGE_GCR.Fixes:
WARNING: unmet direct dependencies detected forBR2_PACKAGE_GCR
Depends on [n]:BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_USE_MMU[=y] && !BR2_STATIC_LIBS [=n] && !BR2_PACKAGE_GNUPG [=y]
Selected by [y]:
-BR2_PACKAGE_MIDORI[=y] &&BR2_PACKAGE_MIDORI_ARCH_SUPPORTS[=y] && !BR2_STATIC_LIBS [=n] &&BR2_INSTALL_LIBSTDCPP[=y] &&BR2_HOST_GCC_AT_LEAST_8[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_7[=y] &&BR2_TOOLCHAIN_USES_GLIBC[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_TOOLCHAIN_HAS_SYNC_4[=y] &&BR2_USE_WCHAR[=y] &&BR2_PACKAGE_LIBGTK3[=y] && (BR2_PACKAGE_LIBGTK3_X11[=y] ||BR2_PACKAGE_LIBGTK3_WAYLAND[=n])Signed-off-by James Hilliard <[email protected]>--- package/midori/Config.in | 1 + 1 file changed, 1 insertion(+)package/midori/Config.in +0
-0
package/midori/Config.in config BR2_PACKAGE_MIDORI · line 28
Quoted 4 lines
package/midori/Config.in +1
-0@@ -25,6 +25,7 @@ config BR2_PACKAGE_MIDORI bool "midori" depends on BR2_PACKAGE_MIDORI_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS # webkitgtk + depends on !BR2_PACKAGE_GNUPG # gcr
You forget to add a comment for this.
Applied to master with that fixed, thanks.
Regards,
Arnout
package/midori/Config.in config BR2_PACKAGE_MIDORI · line 31
Quoted 3 lines
package/midori/Config.in +0
-0depends on BR2_INSTALL_LIBSTDCPP # webkitgtk depends on BR2_HOST_GCC_AT_LEAST_8 # gobject-introspection depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # webkitgtk
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
James, Arnout, All,
On 2022-05-18 21:17 +0200, Arnout Vandecappelle spake thusly:
Quoted 14 lines · James Hilliard
Quoted 13 lines
The !BR2_PACKAGE_GNUPG needs to be propagated from
BR2_PACKAGE_GCR.Fixes:
WARNING: unmet direct dependencies detected forBR2_PACKAGE_GCR
Depends on [n]:BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_USE_MMU[=y] && !BR2_STATIC_LIBS [=n] && !BR2_PACKAGE_GNUPG [=y]
Selected by [y]:
-BR2_PACKAGE_MIDORI[=y] &&BR2_PACKAGE_MIDORI_ARCH_SUPPORTS[=y] && !BR2_STATIC_LIBS [=n] &&BR2_INSTALL_LIBSTDCPP[=y] &&BR2_HOST_GCC_AT_LEAST_8[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_7[=y] &&BR2_TOOLCHAIN_USES_GLIBC[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_TOOLCHAIN_HAS_SYNC_4[=y] &&BR2_USE_WCHAR[=y] &&BR2_PACKAGE_LIBGTK3[=y] && (BR2_PACKAGE_LIBGTK3_X11[=y] ||BR2_PACKAGE_LIBGTK3_WAYLAND[=n])Signed-off-by James Hilliard <[email protected]>--- package/midori/Config.in | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
package/midori/Config.in config BR2_PACKAGE_MIDORI · line 28
Quoted 9 lines
package/midori/Config.in +1
-0@@ -25,6 +25,7 @@ config BR2_PACKAGE_MIDORI bool "midori" depends on BR2_PACKAGE_MIDORI_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS # webkitgtk + depends on !BR2_PACKAGE_GNUPG # gcrYou forget to add a comment for this.
Applied to master with that fixed, thanks.
Unfortunately, as Romain noticed, this is causing a circular (aka recursive) kconfig dependency:
$ make distclean; make defconfig
[...]
package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency detected!
package/gstreamer1/gstreamer1/Config.in:5: symbol BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
package/webkitgtk/Config.in:90: symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDIA depends on BR2_PACKAGE_WEBKITGTK
package/webkitgtk/Config.in:24: symbol BR2_PACKAGE_WEBKITGTK is selected by BR2_PACKAGE_MIDORI
package/midori/Config.in:28: symbol BR2_PACKAGE_MIDORI depends on BR2_PACKAGE_GNUPG
package/gnupg/Config.in:1: symbol BR2_PACKAGE_GNUPG is selected by BR2_PACKAGE_PYTHON_GNUPG
package/python-gnupg/Config.in:1: symbol BR2_PACKAGE_PYTHON_GNUPG depends on BR2_PACKAGE_PYTHON3
package/python3/Config.in:5: symbol BR2_PACKAGE_PYTHON3 is selected by BR2_PACKAGE_JACK2_DBUS
package/jack2/Config.in:35: symbol BR2_PACKAGE_JACK2_DBUS depends on BR2_PACKAGE_JACK2
package/jack2/Config.in:1: symbol BR2_PACKAGE_JACK2 is selected by BR2_PACKAGE_FLUIDSYNTH_JACK2
package/fluidsynth/Config.in:38: symbol BR2_PACKAGE_FLUIDSYNTH_JACK2 depends on BR2_PACKAGE_FLUIDSYNTH
package/fluidsynth/Config.in:1: symbol BR2_PACKAGE_FLUIDSYNTH is selected by BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH
package/gstreamer1/gst1-plugins-bad/Config.in:438: symbol BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH depends on BR2_PACKAGE_GSTREAMER1James, can you look at it, please?
Regards,
Yann E. MORIN.
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 49 lines · Yann E. MORIN
James, Arnout, All,
On 2022-05-18 21:17 +0200, Arnout Vandecappelle spake thusly:
Quoted 14 lines · James Hilliard
Quoted 13 lines
The !BR2_PACKAGE_GNUPG needs to be propagated from
BR2_PACKAGE_GCR.Fixes:
WARNING: unmet direct dependencies detected forBR2_PACKAGE_GCR
Depends on [n]:BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_USE_MMU[=y] && !BR2_STATIC_LIBS [=n] && !BR2_PACKAGE_GNUPG [=y]
Selected by [y]:
-BR2_PACKAGE_MIDORI[=y] &&BR2_PACKAGE_MIDORI_ARCH_SUPPORTS[=y] && !BR2_STATIC_LIBS [=n] &&BR2_INSTALL_LIBSTDCPP[=y] &&BR2_HOST_GCC_AT_LEAST_8[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_7[=y] &&BR2_TOOLCHAIN_USES_GLIBC[=y] &&BR2_TOOLCHAIN_HAS_THREADS[=y] &&BR2_TOOLCHAIN_HAS_SYNC_4[=y] &&BR2_USE_WCHAR[=y] &&BR2_PACKAGE_LIBGTK3[=y] && (BR2_PACKAGE_LIBGTK3_X11[=y] ||BR2_PACKAGE_LIBGTK3_WAYLAND[=n])Signed-off-by James Hilliard <[email protected]>--- package/midori/Config.in | 1 + 1 file changed, 1 insertion(+)Quoted 11 lines
package/midori/Config.in config BR2_PACKAGE_MIDORI · line 28
Quoted 9 lines
package/midori/Config.in +1
-0@@ -25,6 +25,7 @@ config BR2_PACKAGE_MIDORI bool "midori" depends on BR2_PACKAGE_MIDORI_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS # webkitgtk + depends on !BR2_PACKAGE_GNUPG # gcrYou forget to add a comment for this.
Applied to master with that fixed, thanks.Unfortunately, as Romain noticed, this is causing a circular (aka recursive) kconfig dependency:
$ make distclean; make defconfig [...] package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency detected! package/gstreamer1/gstreamer1/Config.in:5: symbol BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA package/webkitgtk/Config.in:90: symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDIA depends on BR2_PACKAGE_WEBKITGTK package/webkitgtk/Config.in:24: symbol BR2_PACKAGE_WEBKITGTK is selected by BR2_PACKAGE_MIDORI package/midori/Config.in:28: symbol BR2_PACKAGE_MIDORI depends on BR2_PACKAGE_GNUPG package/gnupg/Config.in:1: symbol BR2_PACKAGE_GNUPG is selected by BR2_PACKAGE_PYTHON_GNUPG package/python-gnupg/Config.in:1: symbol BR2_PACKAGE_PYTHON_GNUPG depends on BR2_PACKAGE_PYTHON3 package/python3/Config.in:5: symbol BR2_PACKAGE_PYTHON3 is selected by BR2_PACKAGE_JACK2_DBUS package/jack2/Config.in:35: symbol BR2_PACKAGE_JACK2_DBUS depends on BR2_PACKAGE_JACK2 package/jack2/Config.in:1: symbol BR2_PACKAGE_JACK2 is selected by BR2_PACKAGE_FLUIDSYNTH_JACK2 package/fluidsynth/Config.in:38: symbol BR2_PACKAGE_FLUIDSYNTH_JACK2 depends on BR2_PACKAGE_FLUIDSYNTH package/fluidsynth/Config.in:1: symbol BR2_PACKAGE_FLUIDSYNTH is selected by BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH package/gstreamer1/gst1-plugins-bad/Config.in:438: symbol BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH depends on BR2_PACKAGE_GSTREAMER1
Quoted 1 line
James, can you look at it, please?
Yeah, already sent a patch that should fix this:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Quoted 11 lines
Regards,
Yann E. MORIN.--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
James, All,
On 2022-05-24 13:16 -0600, James Hilliard spake thusly:
Quoted 4 lines · Yann E. MORIN
Quoted 3 lines
On 2022-05-18 21:17 +0200, Arnout Vandecappelle spake thusly:
Quoted 2 lines · James Hilliard
Quoted 1 line
The !BR2_PACKAGE_GNUPG needs to be propagated from
BR2_PACKAGE_GCR.
[--SNIP--]
Quoted 2 lines
Quoted 2 lines
Unfortunately, as Romain noticed, this is causing a circular (aka recursive) kconfig dependency:
[--SNIP--]
Quoted 2 lines
Yeah, already sent a patch that should fix this:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Greatm thanks! I've just applied it now.
Regards,
Yann E. MORIN.
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot