mkfs: Fix memory leark
v2 cover mkfs: Fix memory leark
V2:
- Fixed typo s/strup/strdup/
- Added Reviewed-by tag
Pavel Reichl (1):
mkfs: Fix memory leak
mkfs/xfs_mkfs.c | 1 + 1 file changed, 1 insertion(+)
Signature · 1 line
2.36.1
PATCH v2 1/1 mkfs: Fix memory leak
'value' is allocated by strdup() in getstr(). It
needs to be freed as we do not keep any permanent
reference to it.
Signed-off-by Pavel Reichl <[email protected]>
Reviewed-by Darrick J. Wong <[email protected]>
--- mkfs/xfs_mkfs.c | 1 + 1 file changed, 1 insertion(+)
mkfs/xfs_mkfs.c +1 -0
@@ -1714,6 +1714,7 @@ naming_opts_parser( }else { cli->sb_feat.dir_version =getnum (value, opts, subopt); } +free ((char *)value);break ;case N_FTYPE : cli->sb_feat.dirftype =getnum (value, opts, subopt);
Signature · 1 line
2.36.1
Re: [PATCH v2 1/1] mkfs: Fix memory leak
Quoted 7 lines · Pavel Reichl
'value' is allocated by
strdup()ingetstr(). It
needs to be freed as we do not keep any permanent
reference to it.Signed-off-by Pavel Reichl <[email protected]>Reviewed-by Darrick J. Wong <[email protected]>---
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck