fpga: altera-pr-ip: fix unsigned comparison with less than zero
PATCH v2 1/1 fpga: altera-pr-ip: fix unsigned comparison with less than zero
Fix the "comparison with less than zero" warning reported by cppcheck for the unsigned (size_t) parameter count of the alt_pr_fpga_write() function.
Reviewed-by Tom Rix <[email protected]>
Acked-by Xu Yilun <[email protected]>
Signed-off-by Marco Pagani <[email protected]>
---
Changes v1 -> v2:
- Coding style fix
--- drivers/fpga/altera-pr-ip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/altera-pr-ip-core.c +1 -1
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,u32 *buffer_32 = (u32 *)buf;size_t i =0 ; -if (count <=0 ) +if (!count)return -EINVAL ;/* Write out the complete 32-bit chunks */
Signature · 1 line
2.35.3
Xu Yilun
maintainerQuoted 4 lines · Marco Pagani
Fix the "comparison with less than zero" warning reported by cppcheck for the unsigned (
size_t) parameter count of thealt_pr_fpga_write()function.
Please add the 'Fixes' tag, and resend it based on 5.19-rc1
Thanks,
Yilun
Quoted 25 lines
Reviewed-by Tom Rix <[email protected]>Acked-by Xu Yilun <[email protected]>Signed-off-by Marco Pagani <[email protected]>---
Changes v1 -> v2:
- Coding style fix--- drivers/fpga/altera-pr-ip-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/fpga/altera-pr-ip-core.c +1
-1@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,u32 *buffer_32 = (u32 *)buf;size_t i =0 ; -if (count <=0 ) +if (!count)return -EINVAL ;/* Write out the complete 32-bit chunks */ Signature · 1 line
2.35.3