x86/microcode: Drop old interface and default-disable late loading
Subsystems (2)
Borislav Petkov
maintainercover x86/microcode: Drop old interface and default-disable late loading
From: Borislav Petkov <[email protected]>
Now tested.
AMD:
[ 349.234368] microcode: Attempting late microcode loading - it is dangerous and taints the kernel. [ 349.244128] microcode: You should switch to early loading, if possible. ... [ 349.391934] microcode: Reload completed, microcode revision: 0xa001173
Intel:
[ 50.726917] microcode: Attempting late microcode loading - it is dangerous and taints the kernel. [ 50.736139] microcode: You should switch to early loading, if possible. [ 50.745504] microcode: updated to revision 0x718, date = 2019-05-21 [ 50.752000] x86/CPU: CPU features have changed after loading microcode, but might not take effect. [ 50.761158] x86/CPU: Please consider either early loading through initrd/built-in or a potential BIOS update. [ 50.771362] microcode: Reload completed, microcode revision: 0x718
Changelog:
----------
v0:
Totally untested, just sending out as a RFC first. This is something Peter and I talked about recently and think it makes sense.
Borislav Petkov (4):
x86/microcode: Rip out the OLD_INTERFACE
x86/microcode: Default-disable late loading
x86/microcode: Taint and warn on late loading
x86/microcode: Remove unnecessary perf callback
arch/x86/Kconfig | 15 ++-- arch/x86/kernel/cpu/common.c | 2 + arch/x86/kernel/cpu/microcode/core.c | 115 +++------------------------ 3 files changed, 20 insertions(+), 112 deletions(-)
Signature · 1 line
2.35.1
Borislav Petkov
maintainerPATCH 1/4 x86/microcode: Rip out the OLD_INTERFACE
From: Borislav Petkov <[email protected]>
Everything should be using the early initrd loading by now.
--- arch/x86/Kconfig | 12 ---- arch/x86/kernel/cpu/microcode/core.c | 100 --------------------------- 2 files changed, 112 deletions(-)
arch/x86/Kconfig +0 -12
@@ -1345,18 +1345,6 @@ config MICROCODE_AMD If you select this option, microcode patch loading support for AMD processors will be enabled. -config MICROCODE_OLD_INTERFACE - bool "Ancient loading interface (DEPRECATED)" - default n - depends on MICROCODE - help - DO NOT USE THIS! This is the ancient /dev/cpu/microcode interface - which was used by userspace tools like iucode_tool and microcode.ctl. - It is inadequate because it runs too late to be able to properly - load microcode on a machine and it needs special tools. Instead, you - should've switched to the early loading method with the initrd or - builtin microcode by now: Documentation/x86/microcode.rst - config X86_MSR tristate "/dev/cpu/*/msr - Model-specific register support" help
arch/x86/kernel/cpu/microcode/core.c +0 -100
118 lines not on this page · raw message
Signature · 1 line
2.35.1
[tip: x86/microcode] x86/microcode: Rip out the OLD_INTERFACE
The following commit has been merged into the x86/microcode branch of tip:
The following commit has been merged into the x86/microcode branch of tip:
Commit-ID: 181b6f40e9ea80c76756d4d0cdeed396016c487e Gitweb: https://git.kernel.org/tip/181b6f40e9ea80c76756d4d0cdeed396016c487e Author: Borislav Petkov <[email protected]> AuthorDate: Wed, 25 May 2022 18:12:29 +02:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Tue, 31 May 2022 09:31:19 +02:00
x86/microcode: Rip out the OLD_INTERFACE
Everything should be using the early initrd loading by now.
--- arch/x86/Kconfig | 12 +--- arch/x86/kernel/cpu/microcode/core.c | 100 +-------------------------- 2 files changed, 112 deletions(-)
arch/x86/Kconfig +0 -12
@@ -1350,18 +1350,6 @@ config MICROCODE_AMD If you select this option, microcode patch loading support for AMD processors will be enabled. -config MICROCODE_OLD_INTERFACE - bool "Ancient loading interface (DEPRECATED)" - default n - depends on MICROCODE - help - DO NOT USE THIS! This is the ancient /dev/cpu/microcode interface - which was used by userspace tools like iucode_tool and microcode.ctl. - It is inadequate because it runs too late to be able to properly - load microcode on a machine and it needs special tools. Instead, you - should've switched to the early loading method with the initrd or - builtin microcode by now: Documentation/x86/microcode.rst - config X86_MSR tristate "/dev/cpu/*/msr - Model-specific register support" help
arch/x86/kernel/cpu/microcode/core.c +0 -100
118 lines not on this page · raw message
Borislav Petkov
maintainerPATCH 2/4 x86/microcode: Default-disable late loading
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
It is dangerous and it should not be used anyway - there's a nice early loading already.
--- arch/x86/Kconfig | 11 +++++++++++ arch/x86/kernel/cpu/common.c | 2 ++ arch/x86/kernel/cpu/microcode/core.c | 7 ++++++- 3 files changed, 19 insertions(+), 1 deletion(-)
arch/x86/Kconfig +11 -0
@@ -1345,6 +1345,17 @@ config MICROCODE_AMD If you select this option, microcode patch loading support for AMD processors will be enabled. +config MICROCODE_LATE_LOADING + bool "Late microcode loading (DANGEROUS)" + default n + depends on MICROCODE + help + Loading microcode late, when the system is up and executing instructions + is a tricky business and should be avoided if possible. Just the sequence + of synchronizing all cores and SMT threads is one fragile dance which does + not guarantee that cores might not softlock after the loading. Therefore, + use this at your own risk. Late loading taints the kernel too. + config X86_MSR tristate "/dev/cpu/*/msr - Model-specific register support" help
arch/x86/kernel/cpu/common.c +2 -0
@@ -2222,6 +2222,7 @@ void cpu_init_secondary(void) }#endif +#ifdef CONFIG_MICROCODE_LATE_LOADING /* * The microcode loader calls this upon late microcode load to recheck features, * only when microcode has been updated. Caller holds microcode_mutex and CPU
@@ -2251,6 +2252,7 @@ void microcode_check(void)pr_warn ("x86/CPU: CPU features have changed after loading microcode, but might not take effect.\n" ); pr_warn("x86/CPU: Please consider either early loading through initrd/built-in or a potential BIOS update.\n"); } +#endif /* * Invoked from core CPU hotplug code after hotplug operations
arch/x86/kernel/cpu/microcode/core.c +6 -1
@@ -376,6 +376,7 @@ static int apply_microcode_on_target(int cpu)/* fake device for request_firmware */ static struct platform_device *microcode_pdev; +#ifdef CONFIG_MICROCODE_LATE_LOADING /* * Late loading dance. Why the heavy-handed stomp_machine effort? *
@@ -543,6 +544,9 @@ static ssize_t reload_store(struct device *dev, return ret; } +static DEVICE_ATTR_WO (reload); +#endif +static ssize_t version_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -559,7 +563,6 @@ static ssize_t pf_show(struct device *dev,return sprintf (buf,"0x%x\n" , uci->cpu_sig.pf); } -static DEVICE_ATTR_WO (reload); static DEVICE_ATTR(version, 0444, version_show, NULL); static DEVICE_ATTR(processor_flags, 0444, pf_show, NULL);
@@ -712,7 +715,9 @@ static int mc_cpu_down_prep(unsigned int cpu) }static struct attribute *cpu_root_microcode_attrs[] = { +#ifdef CONFIG_MICROCODE_LATE_LOADING &dev_attr_reload.attr, +#endifNULL };
Signature · 1 line
2.35.1
[tip: x86/microcode] x86/microcode: Default-disable late loading
The following commit has been merged into the x86/microcode branch of tip:
The following commit has been merged into the x86/microcode branch of tip:
Commit-ID: a77a94f86273ce42a39cb479217dd8d68acfe0ff Gitweb: https://git.kernel.org/tip/a77a94f86273ce42a39cb479217dd8d68acfe0ff Author: Borislav Petkov <[email protected]> AuthorDate: Wed, 25 May 2022 18:12:30 +02:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Tue, 31 May 2022 09:31:19 +02:00
x86/microcode: Default-disable late loading
It is dangerous and it should not be used anyway - there's a nice early loading already.
--- arch/x86/Kconfig | 11 +++++++++++ arch/x86/kernel/cpu/common.c | 2 ++ arch/x86/kernel/cpu/microcode/core.c | 7 ++++++- 3 files changed, 19 insertions(+), 1 deletion(-)
arch/x86/Kconfig +11 -0
@@ -1350,6 +1350,17 @@ config MICROCODE_AMD If you select this option, microcode patch loading support for AMD processors will be enabled. +config MICROCODE_LATE_LOADING + bool "Late microcode loading (DANGEROUS)" + default n + depends on MICROCODE + help + Loading microcode late, when the system is up and executing instructions + is a tricky business and should be avoided if possible. Just the sequence + of synchronizing all cores and SMT threads is one fragile dance which does + not guarantee that cores might not softlock after the loading. Therefore, + use this at your own risk. Late loading taints the kernel too. + config X86_MSR tristate "/dev/cpu/*/msr - Model-specific register support" help
arch/x86/kernel/cpu/common.c +2 -0
@@ -2222,6 +2222,7 @@ void cpu_init_secondary(void) }#endif +#ifdef CONFIG_MICROCODE_LATE_LOADING /* * The microcode loader calls this upon late microcode load to recheck features, * only when microcode has been updated. Caller holds microcode_mutex and CPU
@@ -2251,6 +2252,7 @@ void microcode_check(void)pr_warn ("x86/CPU: CPU features have changed after loading microcode, but might not take effect.\n" ); pr_warn("x86/CPU: Please consider either early loading through initrd/built-in or a potential BIOS update.\n"); } +#endif /* * Invoked from core CPU hotplug code after hotplug operations
arch/x86/kernel/cpu/microcode/core.c +6 -1
@@ -376,6 +376,7 @@ static int apply_microcode_on_target(int cpu)/* fake device for request_firmware */ static struct platform_device *microcode_pdev; +#ifdef CONFIG_MICROCODE_LATE_LOADING /* * Late loading dance. Why the heavy-handed stomp_machine effort? *
@@ -543,6 +544,9 @@ put: return ret; } +static DEVICE_ATTR_WO (reload); +#endif +static ssize_t version_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -559,7 +563,6 @@ static ssize_t pf_show(struct device *dev,return sprintf (buf,"0x%x\n" , uci->cpu_sig.pf); } -static DEVICE_ATTR_WO (reload); static DEVICE_ATTR(version, 0444, version_show, NULL); static DEVICE_ATTR(processor_flags, 0444, pf_show, NULL);
@@ -712,7 +715,9 @@ static int mc_cpu_down_prep(unsigned int cpu) }static struct attribute *cpu_root_microcode_attrs[] = { +#ifdef CONFIG_MICROCODE_LATE_LOADING &dev_attr_reload.attr, +#endifNULL };
Borislav Petkov
maintainerPATCH 3/4 x86/microcode: Taint and warn on late loading
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Warn before it is attempted and taint the kernel.
--- arch/x86/kernel/cpu/microcode/core.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/x86/kernel/cpu/microcode/core.c +5 -0
@@ -493,6 +493,9 @@ static int microcode_reload_late(void) {int ret; +pr_err ("Attempting late microcode loading - it is dangerous and taints the kernel.\n" ); +pr_err ("You should switch to early loading, if possible.\n" ); +atomic_set (&late_cpus_in,0 );atomic_set (&late_cpus_out,0 );
@@ -541,6 +544,8 @@ static ssize_t reload_store(struct device *dev,if (ret ==0 ) ret = size; +add_taint (TAINT_CPU_OUT_OF_SPEC ,LOCKDEP_STILL_OK ); +return ret; }
Signature · 1 line
2.35.1
[tip: x86/microcode] x86/microcode: Taint and warn on late loading
The following commit has been merged into the x86/microcode branch of tip:
The following commit has been merged into the x86/microcode branch of tip:
Commit-ID: d23d33ea0fcdc4bbb484990bf53867f99c63ccab Gitweb: https://git.kernel.org/tip/d23d33ea0fcdc4bbb484990bf53867f99c63ccab Author: Borislav Petkov <[email protected]> AuthorDate: Wed, 25 May 2022 18:12:31 +02:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Tue, 31 May 2022 09:31:19 +02:00
x86/microcode: Taint and warn on late loading
Warn before it is attempted and taint the kernel. Late loading microcode can lead to malfunction of the kernel when the microcode update changes behaviour. There is no way for the kernel to determine whether its safe or not.
--- arch/x86/kernel/cpu/microcode/core.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/x86/kernel/cpu/microcode/core.c +5 -0
@@ -493,6 +493,9 @@ static int microcode_reload_late(void) {int ret; +pr_err ("Attempting late microcode loading - it is dangerous and taints the kernel.\n" ); +pr_err ("You should switch to early loading, if possible.\n" ); +atomic_set (&late_cpus_in,0 );atomic_set (&late_cpus_out,0 );
@@ -541,6 +544,8 @@ put:if (ret ==0 ) ret = size; +add_taint (TAINT_CPU_OUT_OF_SPEC ,LOCKDEP_STILL_OK ); +return ret; }
Borislav Petkov
maintainerPATCH 4/4 x86/microcode: Remove unnecessary perf callback
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
c93dc84cbe32 ("perf/x86: Add a microcode revision check for SNB-PEBS") checks whether the microcode revision has fixed PEBS issues.
This can happen either:
1. At PEBS init time, where the early microcode has been loaded already
2. During late loading, in the microcode_check() callback.
So remove the unnecessary call in the microcode loader init routine.
--- arch/x86/kernel/cpu/microcode/core.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/kernel/cpu/microcode/core.c +0 -3
@@ -756,10 +756,7 @@ static int __init microcode_init(void)cpus_read_lock ();mutex_lock (µcode_mutex); - error =subsys_interface_register (&mc_cpu_interface); -if (!error) -perf_check_microcode ();mutex_unlock (µcode_mutex);cpus_read_unlock ();
Signature · 1 line
2.35.1
[tip: x86/microcode] x86/microcode: Remove unnecessary perf callback
The following commit has been merged into the x86/microcode branch of tip:
The following commit has been merged into the x86/microcode branch of tip:
Commit-ID: 0c0fe08c76485fe0178ebb0fa1a2052c727abe94 Gitweb: https://git.kernel.org/tip/0c0fe08c76485fe0178ebb0fa1a2052c727abe94 Author: Borislav Petkov <[email protected]> AuthorDate: Wed, 25 May 2022 18:12:32 +02:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Tue, 31 May 2022 09:31:19 +02:00
x86/microcode: Remove unnecessary perf callback
c93dc84cbe32 ("perf/x86: Add a microcode revision check for SNB-PEBS") checks whether the microcode revision has fixed PEBS issues.
This can happen either:
1. At PEBS init time, where the early microcode has been loaded already
2. During late loading, in the microcode_check() callback.
So remove the unnecessary call in the microcode loader init routine.
--- arch/x86/kernel/cpu/microcode/core.c | 3 --- 1 file changed, 3 deletions(-)
arch/x86/kernel/cpu/microcode/core.c +0 -3
@@ -756,10 +756,7 @@ static int __init microcode_init(void)cpus_read_lock ();mutex_lock (µcode_mutex); - error =subsys_interface_register (&mc_cpu_interface); -if (!error) -perf_check_microcode ();mutex_unlock (µcode_mutex);cpus_read_unlock ();