drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
Subsystems (3)
PATCH 1/1 drm: bridge: adv7511: Move CEC definitions to adv7511_cec.c
ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[] are only used inside adv7511_cec.c.
Move their definitions to this file to avoid the following build warnings when CONFIG_DRM_I2C_ADV7511_CEC is not selected:
drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=] drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]
--- drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------ drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511.h +0 -12
@@ -226,18 +226,6 @@#define ADV7511_REG_CEC_CLK_DIV 0x4e#define ADV7511_REG_CEC_SOFT_RESET 0x50 -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { -ADV7511_REG_CEC_RX1_FRAME_HDR , -ADV7511_REG_CEC_RX2_FRAME_HDR , -ADV7511_REG_CEC_RX3_FRAME_HDR , -}; - -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { -ADV7511_REG_CEC_RX1_FRAME_LEN , -ADV7511_REG_CEC_RX2_FRAME_LEN , -ADV7511_REG_CEC_RX3_FRAME_LEN , -}; -#define ADV7533_REG_CEC_OFFSET 0x70enum adv7511_input_clock {
drivers/gpu/drm/bridge/adv7511/adv7511_cec.c +12 -0
@@ -15,6 +15,18 @@#include "adv7511.h" +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { +ADV7511_REG_CEC_RX1_FRAME_HDR , +ADV7511_REG_CEC_RX2_FRAME_HDR , +ADV7511_REG_CEC_RX3_FRAME_HDR , +}; + +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { +ADV7511_REG_CEC_RX1_FRAME_LEN , +ADV7511_REG_CEC_RX2_FRAME_LEN , +ADV7511_REG_CEC_RX3_FRAME_LEN , +}; +#define ADV7511_INT1_CEC_MASK \ (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \ ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \
Signature · 1 line
2.25.1
Quoted 6 lines · Fabio Estevam
ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[] are only used inside
adv7511_cec.c.Move their definitions to this file to avoid the following build warnings when
CONFIG_DRM_I2C_ADV7511_CECis not selected:
Quoted 7 lines
drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]Reported-by kernel test robot <[email protected]>Fixes ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")Signed-off-by Fabio Estevam <[email protected]>---
Thank you for fixing this.
Quoted 53 lines
drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------ drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)drivers/gpu/drm/bridge/adv7511/adv7511.h +0
-12@@ -226,18 +226,6 @@#define ADV7511_REG_CEC_CLK_DIV 0x4e#define ADV7511_REG_CEC_SOFT_RESET 0x50 -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { -ADV7511_REG_CEC_RX1_FRAME_HDR , -ADV7511_REG_CEC_RX2_FRAME_HDR , -ADV7511_REG_CEC_RX3_FRAME_HDR , -}; - -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { -ADV7511_REG_CEC_RX1_FRAME_LEN , -ADV7511_REG_CEC_RX2_FRAME_LEN , -ADV7511_REG_CEC_RX3_FRAME_LEN , -}; -#define ADV7533_REG_CEC_OFFSET 0x70enum adv7511_input_clock {drivers/gpu/drm/bridge/adv7511/adv7511_cec.c +12
-0@@ -15,6 +15,18 @@#include "adv7511.h" +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { +ADV7511_REG_CEC_RX1_FRAME_HDR , +ADV7511_REG_CEC_RX2_FRAME_HDR , +ADV7511_REG_CEC_RX3_FRAME_HDR , +}; + +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { +ADV7511_REG_CEC_RX1_FRAME_LEN , +ADV7511_REG_CEC_RX2_FRAME_LEN , +ADV7511_REG_CEC_RX3_FRAME_LEN , +}; +#define ADV7511_INT1_CEC_MASK \ (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \ ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \Signature · 1 line
2.25.1
Robert Foss
AppliedQuoted 66 lines · Alvin Šipraga
Quoted 6 lines · Fabio Estevam
ADV7511_REG_CEC_RX_FRAME_HDR[] and ADV7511_REG_CEC_RX_FRAME_LEN[] are only used inside
adv7511_cec.c.Move their definitions to this file to avoid the following build warnings when
CONFIG_DRM_I2C_ADV7511_CECis not selected:Quoted 7 lines
drivers/gpu/drm/bridge/adv7511/adv7511.h:229:17: warning: 'ADV7511_REG_CEC_RX_FRAME_HDR' defined but not used [-Wunused-const-variable=]drivers/gpu/drm/bridge/adv7511/adv7511.h:235:17: warning: 'ADV7511_REG_CEC_RX_FRAME_LEN' defined but not used [-Wunused-const-variable=]Reported-by kernel test robot <[email protected]>Fixes ab0af093bf90 ("drm: bridge: adv7511: use non-legacy mode for CEC RX")Signed-off-by Fabio Estevam <[email protected]>---
Thank you for fixing this.
Reviewed-by Alvin Šipraga <[email protected]>Quoted 45 lines
drivers/gpu/drm/bridge/adv7511/adv7511.h | 12 ------------ drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-)drivers/gpu/drm/bridge/adv7511/adv7511.h +0
-12@@ -226,18 +226,6 @@#define ADV7511_REG_CEC_CLK_DIV 0x4e#define ADV7511_REG_CEC_SOFT_RESET 0x50 -static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { -ADV7511_REG_CEC_RX1_FRAME_HDR , -ADV7511_REG_CEC_RX2_FRAME_HDR , -ADV7511_REG_CEC_RX3_FRAME_HDR , -}; - -static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { -ADV7511_REG_CEC_RX1_FRAME_LEN , -ADV7511_REG_CEC_RX2_FRAME_LEN , -ADV7511_REG_CEC_RX3_FRAME_LEN , -}; -#define ADV7533_REG_CEC_OFFSET 0x70enum adv7511_input_clock {drivers/gpu/drm/bridge/adv7511/adv7511_cec.c +10
-0@@ -15,6 +15,18 @@#include "adv7511.h" +static const u8 ADV7511_REG_CEC_RX_FRAME_HDR [] = { +ADV7511_REG_CEC_RX1_FRAME_HDR , +ADV7511_REG_CEC_RX2_FRAME_HDR , +ADV7511_REG_CEC_RX3_FRAME_HDR , +}; + +static const u8 ADV7511_REG_CEC_RX_FRAME_LEN [] = { +ADV7511_REG_CEC_RX1_FRAME_LEN , +ADV7511_REG_CEC_RX2_FRAME_LEN , +ADV7511_REG_CEC_RX3_FRAME_LEN ,
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/bridge/adv7511/adv7511_cec.c +2
-1+}; +#define ADV7511_INT1_CEC_MASK \ (ADV7511_INT1_CEC_TX_READY | ADV7511_INT1_CEC_TX_ARBIT_LOST | \ ADV7511_INT1_CEC_TX_RETRY_TIMEOUT | ADV7511_INT1_CEC_RX_READY1 | \ --2.25.1
Applied to drm-misc-next