spi: dt-bindings: Fix unevaluatedProperties warnings in examples
Rob Herring
maintainerPATCH 1/1 spi: dt-bindings: Fix unevaluatedProperties warnings in examples
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
--- Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml | 1 - Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 1 - 2 files changed, 2 deletions(-)
Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml +0 -1
@@ -47,6 +47,5 @@ examples: clocks = <&clkcfg CLK_SPI0>; interrupt-parent = <&plic>; interrupts = <54>; - spi-max-frequency = <25000000>; }; ...
Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml +0 -1
@@ -110,7 +110,6 @@ examples: pinctrl-names = "default"; pinctrl-0 = <&qup_spi1_default>; interrupts = <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>; - spi-max-frequency = <50000000>; #address-cells = <1>; #size-cells = <0>; };
Signature · 1 line
2.34.1
Quoted 8 lines · Rob Herring
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
Signed-off-by Rob Herring <[email protected]>
Best regards,
Krzysztof
Quoted 8 lines · Rob Herring
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
As this property is in the mpfs devicetree & I'll need to fix it, is this patch targeted at 5.19? (I assume given the window is open and there's no fixes tag that it isn't).
As an aside, I meant to send the driver once the merge window closes, so thanks for spotting a problem with the driver before I even sent it :)
Thanks,
Conor.
Quoted 33 lines
Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml | 1 - Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 1 - 2 files changed, 2 deletions(-)Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml +0
-1@@ -47,6 +47,5 @@ examples: clocks = <&clkcfg CLK_SPI0>; interrupt-parent = <&plic>; interrupts = <54>; - spi-max-frequency = <25000000>; };Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml +0
-2@@ -110,7 +110,6 @@ examples: pinctrl-names = "default"; pinctrl-0 = <&qup_spi1_default>; interrupts = <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>; - spi-max-frequency = <50000000>; #address-cells = <1>; #size-cells = <0>; }; --2.34.1
Rob Herring
maintainerQuoted 7 lines · On Thu, May 26, 2022 at 06:52:23AM +0000, [email protected] wrote:
Quoted 6 lines · Rob Herring
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
Quoted 8 lines
Quoted 2 lines
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
Reviewed-by Conor Dooley <[email protected]>As this property is in the mpfs devicetree & I'll need to fix it, is this patch targeted at 5.19? (I assume given the window is open and there's no fixes tag that it isn't).
5.18 ideally because warnings are going to appear when I push the dtschema fix for 'unevaluatedProperties'.
Rob
[email protected]
maintainerQuoted 13 lines · Rob Herring
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 10 lines · On Thu, May 26, 2022 at 06:52:23AM +0000, [email protected] wrote:
Quoted 8 lines · Rob Herring
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
Quoted 7 lines
Quoted 5 lines
Reviewed-by Conor Dooley <[email protected]>As this property is in the mpfs devicetree & I'll need to fix it, is this patch targeted at 5.19? (I assume given the window is open and there's no fixes tag that it isn't).
5.18 ideally because warnings are going to appear when I push the
18? That a typo or am I missing something? Either way, will send the dt fix shortly.
Thanks,
Conor.
Quoted 3 lines
dtschema fix for 'unevaluatedProperties'.
Rob
Mark Brown
maintainerQuoted 8 lines · Rob Herring
The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.
'spi-max-frequency' is supposed to be a per SPI peripheral device property, not a SPI controller property, so drop it.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: dt-bindings: Fix unevaluatedProperties warnings in examples
commit: 6aa27071e4354c351d98e345fc888b70f335f185
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark