Skip to contentSkip to conversation

ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init

PATCH In review Miaoqian Lin 2 participants 2 messages May 26, 2022 – Jun 28, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: omap2: Fix refcount leak in omap3xxx_prm_late_init

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 1e037794f7f0 ("ARM: OMAP3+: PRM: register interrupt information from DT")
---
 arch/arm/mach-omap2/prm3xxx.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/prm3xxx.c +1 -0
index 1b442b128569..63e73e9b82bc 100644
@@ -708,6 +708,7 @@ static int omap3xxx_prm_late_init(void)
 	}
 
 	irq_num = of_irq_get(np, 0);
+	of_node_put(np);
 	if (irq_num == -EPROBE_DEFER)
 		return irq_num;
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 3 lines · Miaoqian Lin

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Thanks applying into omap-for-v5.10/soc.

Tony