Skip to contentSkip to conversation

ARM: integrator: Fix refcount leak in intcp_init_of

PATCH In review Miaoqian Lin 2 participants 2 messages May 26, 2022 – Jun 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: integrator: Fix refcount leak in intcp_init_of

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes df36680f1a71 ("ARM: integrator: core module registers from compatible strings")
---
 arch/arm/mach-integrator/integrator_cp.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-integrator/integrator_cp.c +1 -0
index b7eb4038798b..bb301ca8c7e1 100644
@@ -126,6 +126,7 @@ static void __init intcp_init_of(void)
 		return;
 
 	intcp_con_base = of_iomap(cpcon, 0);
+	of_node_put(cpcon);
 	if (!intcp_con_base)
 		return;
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes df36680f1a71 ("ARM: integrator: core module registers from compatible strings")

Patch applied manually (target file moved in the tree)

Yours,
Linus Walleij