x86/mm: use PAGE_ALIGNED instead of IS_ALIGNED
PATCH 1/1 x86/mm: use PAGE_ALIGNED instead of IS_ALIGNED
From: Fanjun Kong <[email protected]>
The <linux/mm.h> already provides the PAGE_ALIGNED macro. Let's use this macro instead of IS_ALIGNED and passing PAGE_SIZE directly.
--- arch/x86/mm/init_64.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/x86/mm/init_64.c +4 -4
@@ -1240,8 +1240,8 @@ remove_pagetable(unsigned long start, unsigned long end, bool direct,void __ref vmemmap_free (unsigned long start,unsigned long end,struct vmem_altmap *altmap) { -VM_BUG_ON (!IS_ALIGNED (start,PAGE_SIZE )); -VM_BUG_ON (!IS_ALIGNED (end,PAGE_SIZE )); +VM_BUG_ON (!PAGE_ALIGNED (start)); +VM_BUG_ON (!PAGE_ALIGNED (end));remove_pagetable (start, end, false, altmap); }
@@ -1605,8 +1605,8 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, {int err; -VM_BUG_ON (!IS_ALIGNED (start,PAGE_SIZE )); -VM_BUG_ON (!IS_ALIGNED (end,PAGE_SIZE )); +VM_BUG_ON (!PAGE_ALIGNED (start)); +VM_BUG_ON (!PAGE_ALIGNED (end));if (end - start <PAGES_PER_SECTION *sizeof (struct page )) err =vmemmap_populate_basepages (start, end, node,NULL );
Signature · 1 line
2.36.0
Quoted 7 lines · On Thu, May 26, 2022 at 10:21 PM <[email protected]> wrote:
From: Fanjun Kong <[email protected]>
The <
linux/mm.h> already provides thePAGE_ALIGNEDmacro. Let's use this macro instead ofIS_ALIGNEDand passingPAGE_SIZEdirectly.Signed-off-by Fanjun Kong <[email protected]>
[tip: x86/mm] x86/mm: Use PAGE_ALIGNED(x) instead of IS_ALIGNED(x, PAGE_SIZE)
In reply to [email protected]The following commit has been merged into the x86/mm branch of tip:
The following commit has been merged into the x86/mm branch of tip:
Commit-ID: e19d11267f0e6c8aff2d15d2dfed12365b4c9184 Gitweb: https://git.kernel.org/tip/e19d11267f0e6c8aff2d15d2dfed12365b4c9184 Author: Fanjun Kong <[email protected]> AuthorDate: Thu, 26 May 2022 22:20:39 +08:00 Committer: Ingo Molnar <[email protected]> CommitterDate: Fri, 27 May 2022 12:19:56 +02:00
x86/mm: Use PAGE_ALIGNED(x) instead of IS_ALIGNED(x, PAGE_SIZE)
The <linux/mm.h> already provides the PAGE_ALIGNED() macro. Let's use this macro instead of IS_ALIGNED() and passing PAGE_SIZE directly.
No change in functionality.
[ mingo: Tweak changelog. ]
--- arch/x86/mm/init_64.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/x86/mm/init_64.c +4 -4
@@ -1240,8 +1240,8 @@ remove_pagetable(unsigned long start, unsigned long end, bool direct,void __ref vmemmap_free (unsigned long start,unsigned long end,struct vmem_altmap *altmap) { -VM_BUG_ON (!IS_ALIGNED (start,PAGE_SIZE )); -VM_BUG_ON (!IS_ALIGNED (end,PAGE_SIZE )); +VM_BUG_ON (!PAGE_ALIGNED (start)); +VM_BUG_ON (!PAGE_ALIGNED (end));remove_pagetable (start, end, false, altmap); }
@@ -1605,8 +1605,8 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, {int err; -VM_BUG_ON (!IS_ALIGNED (start,PAGE_SIZE )); -VM_BUG_ON (!IS_ALIGNED (end,PAGE_SIZE )); +VM_BUG_ON (!PAGE_ALIGNED (start)); +VM_BUG_ON (!PAGE_ALIGNED (end));if (end - start <PAGES_PER_SECTION *sizeof (struct page )) err =vmemmap_populate_basepages (start, end, node,NULL );