Skip to contentSkip to conversation

linux/types.h: Restore __bitwise__ definition

PATCH In review Bjorn Helgaas 2 participants 2 messages May 26, 2022 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux/types.h: Restore __bitwise__ definition

From: Bjorn Helgaas <[email protected]>

This reverts part of commit c724c866bb70cb8c607081a26823a1f0ebde4387.

Jiri Slaby reported that c724c866bb70 ("linux/types.h: remove unnecessary __bitwise__") broke userspace, including open-iscsi, because it uses __bitwise__.

Restore the __bitwise__ definition.

---
 include/uapi/linux/types.h | 3 +++
 1 file changed, 3 insertions(+)
include/uapi/linux/types.h +3 -0
index c4dc597f3dcf..308433be33c2 100644
@@ -26,6 +26,9 @@
 #define __bitwise
 #endif
 
+/* The kernel doesn't use this legacy form, but user space does */
+#define __bitwise__ __bitwise
+
 typedef __u16 __bitwise __le16;
 typedef __u16 __bitwise __be16;
 typedef __u32 __bitwise __le32;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Bjorn Helgaas

Restore the __bitwise__ definition.

Thanks, but I already ended up applying this yesterday,

Linus