Skip to contentSkip to conversation

net/iavf: increase the reset complete wait count

PATCH Superseded Qiming Yang 2 participants 5 messages May 27, 2022 – May 30, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/iavf: increase the reset complete wait count

Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case. Follow this action in DPDK iavf driver.

Fixes 22b123a36d07 ("net/avf: initialize PMD")
---
 drivers/net/iavf/iavf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/iavf/iavf.h +1 -1
index f1c2daa06e..025ab3ff60 100644
@@ -18,7 +18,7 @@
 
 #define IAVF_AQ_LEN               32
 #define IAVF_AQ_BUF_SZ            4096
-#define IAVF_RESET_WAIT_CNT       50
+#define IAVF_RESET_WAIT_CNT       500
 #define IAVF_BUF_SIZE_MIN         1024
 #define IAVF_FRAME_SIZE_MAX       9728
 #define IAVF_QUEUE_BASE_ADDR_UNIT 128
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Qiming Yang <[email protected]>
Sent: Friday, May 27, 2022 10:13 AM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; [email protected]
Subject: [PATCH] net/iavf: increase the reset complete wait count

Quoted 3 lines

Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.

Could you add a link to the corresponding kernel patch, so people can know why we need this change

#2 lore raw

sure

Quoted 24 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: 2022年5月27日 12:28
To: Yang, Qiming <[email protected]>; [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; [email protected]
Subject: RE: [PATCH] net/iavf: increase the reset complete wait count

Quoted 11 lines

-----Original Message-----
From: Qiming Yang <[email protected]>
Sent: Friday, May 27, 2022 10:13 AM
To: [email protected]
Cc: Xing, Beilei <[email protected]>; Yang, Qiming <[email protected]>; [email protected]
Subject: [PATCH] net/iavf: increase the reset complete wait count

Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.

Could you add a link to the corresponding kernel patch, so people can know why we need this change

#3 lore raw

PATCH v2 1/1 net/iavf: increase the reset complete wait count

In reply to Qiming Yang

Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case. Follow this action in DPDK iavf driver.
Kernel reference commit:
8e3e4b9da7e6 ("iavf: increase reset complete wait time")

Fixes 22b123a36d07 ("net/avf: initialize PMD")

---
* v2: add kernel patch reference in commit log

---
 drivers/net/iavf/iavf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/iavf/iavf.h +1 -1
index f1c2daa06e..025ab3ff60 100644
@@ -18,7 +18,7 @@
 
 #define IAVF_AQ_LEN               32
 #define IAVF_AQ_BUF_SZ            4096
-#define IAVF_RESET_WAIT_CNT       50
+#define IAVF_RESET_WAIT_CNT       500
 #define IAVF_BUF_SIZE_MIN         1024
 #define IAVF_FRAME_SIZE_MAX       9728
 #define IAVF_QUEUE_BASE_ADDR_UNIT 128
Signature · 1 line
2.17.1
Acked-by on v2 1/1 Applied
#4 lore raw
Quoted 16 lines

-----Original Message-----
From: Yang, Qiming <[email protected]>
Sent: Monday, May 30, 2022 1:35 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>; [email protected]
Subject: [PATCH v2] net/iavf: increase the reset complete wait count

Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.
Kernel reference commit:
8e3e4b9da7e6 ("iavf: increase reset complete wait time")

Quoted 4 lines
Fixes 22b123a36d07 ("net/avf: initialize PMD")

Applied to dpdk-next-net-intel.

Thanks
Qi