Skip to contentSkip to conversation

remoteproc: Directly use ida_alloc()/free()

PATCH Applied keliu 2 participants 2 messages May 27, 2022 – Jul 18, 2022 Remote processor (remoteproc)

lore
Share & tools
lore

keliu

author
#0 lore raw

PATCH 1/1 remoteproc: Directly use ida_alloc()/free()

Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .

---
 drivers/remoteproc/remoteproc_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/remoteproc/remoteproc_core.c +3 -3
index c510125769b9..c872152f4cb7 100644
@@ -2427,7 +2427,7 @@ static void rproc_type_release(struct device *dev)
 	idr_destroy(&rproc->notifyids);
 
 	if (rproc->index >= 0)
-		ida_simple_remove(&rproc_dev_index, rproc->index);
+		ida_free(&rproc_dev_index, rproc->index);
 
 	kfree_const(rproc->firmware);
 	kfree_const(rproc->name);
@@ -2544,9 +2544,9 @@ struct rproc *rproc_alloc(struct device *dev, const char *name,
 		goto put_device;
 
 	/* Assign a unique device index and name */
-	rproc->index = ida_simple_get(&rproc_dev_index, 0, 0, GFP_KERNEL);
+	rproc->index = ida_alloc(&rproc_dev_index, GFP_KERNEL);
 	if (rproc->index < 0) {
-		dev_err(dev, "ida_simple_get failed: %d\n", rproc->index);
+		dev_err(dev, "ida_alloc failed: %d\n", rproc->index);
 		goto put_device;
 	}
 
Signature · 1 line
2.25.1
#1 lore raw

Re: (subset) [PATCH] remoteproc: Directly use ida_alloc()/free()

Quoted 4 lines · keliu

Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .

Applied, thanks!

[1/1] remoteproc: Directly use ida_alloc()/free()

      commit: 4953012caed20e3d341085a726b97a160d8847fd

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>