Skip to contentSkip to conversation

b4 and lore are mangling from lines in patches

DISCUSSION Jason Gunthorpe 2 participants 4 messages May 27, 2022

lore
Share & tools
lore
#0 lore raw

Hi Konstantin,

I noticed this:

$ b4.sh am https://lore.kernel.org/linux-iommu/[email protected]
$ grep ^From 20220527_iommu_drivers_iommu_directly_use_ida_alloc_free.mbx
From git@z Thu Jan  1 00:00:00 1970
From: keliu via iommu <[email protected]>
           ^^^^^^^^^^^^

And when this is git AM'd the from line is mangled.

I see this is leaking into the main repo now:

commit 9ed1d7f510336e283c0bb2d20fd771e9d8fa085b

Author: Vasant Hegde via iommu <[email protected]>
Date:   Mon Mar 14 12:32:26 2022 +0530

iommu/amd: Remove redundant check

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Can something be done?

Thanks,
Jason

#1 lore raw
Quoted 18 lines · Jason Gunthorpe

Hi Konstantin,

I noticed this:

$ b4.sh am https://lore.kernel.org/linux-iommu/[email protected]
$ grep ^From 20220527_iommu_drivers_iommu_directly_use_ida_alloc_free.mbx
From git@z Thu Jan  1 00:00:00 1970
From: keliu via iommu <[email protected]>
           ^^^^^^^^^^^^

And when this is git AM'd the from line is mangled.

I see this is leaking into the main repo now:

commit 9ed1d7f510336e283c0bb2d20fd771e9d8fa085b

Author: Vasant Hegde via iommu <[email protected]>
Date:   Mon Mar 14 12:32:26 2022 +0530
Quoted 7 lines

iommu/amd: Remove redundant check

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Can something be done?

This is done by the iommu list, not by lore or b4 -- someone turned on "send emails from the list address," which is a terrible setting for lists that receive patches.

You will need to complain to that list's admins, found at the bottom of
https://lists.linuxfoundation.org/mailman/listinfo/iommu

-K

#2 lore raw
Quoted 25 lines · Konstantin Ryabitsev
Quoted 24 lines · Jason Gunthorpe

Hi Konstantin,

I noticed this:

$ b4.sh am https://lore.kernel.org/linux-iommu/[email protected]
$ grep ^From 20220527_iommu_drivers_iommu_directly_use_ida_alloc_free.mbx
From git@z Thu Jan  1 00:00:00 1970
From: keliu via iommu <[email protected]>
           ^^^^^^^^^^^^

And when this is git AM'd the from line is mangled.

I see this is leaking into the main repo now:

commit 9ed1d7f510336e283c0bb2d20fd771e9d8fa085b

Author: Vasant Hegde via iommu <[email protected]>
Date:   Mon Mar 14 12:32:26 2022 +0530

iommu/amd: Remove redundant check

smatch static checker warning:
drivers/iommu/amd/init.c:1989 amd_iommu_init_pci()
warn: duplicate check 'ret' (previous on line 1978)

Quoted 8 lines
Quoted 1 line

Can something be done?

This is done by the iommu list, not by lore or b4 -- someone turned on "send emails from the list address," which is a terrible setting for lists that receive patches.

You will need to complain to that list's admins, found at the bottom of
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Ah given the linuxfoundation.org I had guessed that is you. Let's add Alex and Joerg.

Jason

#3 lore raw
Quoted 9 lines · Jason Gunthorpe
Quoted 6 lines

This is done by the iommu list, not by lore or b4 -- someone turned on "send emails from the list address," which is a terrible setting for lists that receive patches.

You will need to complain to that list's admins, found at the bottom of
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Ah given the linuxfoundation.org I had guessed that is you. Let's add Alex and Joerg.

It's certainly not a strange guess, but in this case lists.linuxfoundation.org management is outsourced to OSUOSL. :)

I generally recommend moving from that host to lists.linux.dev, as list.lf.o will probably forever remain on mailman2 and never become DKIM-compliant.

-K