HID: nintendo: fix unused const warning
Subsystems (2)
Daniel J. Ogorchock
maintainerPATCH 1/1 HID: nintendo: fix unused const warning
JC_RUMBLE_ZERO_AMP_PKT_CNT is only used when force feedback support in the driver is enabled. Place the declaration in the CONFIG_NINTENDO_FF ifdef to avoid a warning when compiling without rumble support.
--- drivers/hid/hid-nintendo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/hid/hid-nintendo.c +1 -2
@@ -292,6 +292,7 @@ static const struct joycon_rumble_amp_data joycon_rumble_amplitudes[] = { };static const u16 JC_RUMBLE_DFLT_LOW_FREQ =160 ;static const u16 JC_RUMBLE_DFLT_HIGH_FREQ =320 ; +static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT =5 ;#endif /* IS_ENABLED(CONFIG_NINTENDO_FF) */ static const u16 JC_RUMBLE_PERIOD_MS =50 ;
@@ -402,8 +403,6 @@ struct joycon_input_report {#define JC_RUMBLE_DATA_SIZE 8#define JC_RUMBLE_QUEUE_SIZE 8 -static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT =5 ; -static const char *const joycon_player_led_names[] = {LED_FUNCTION_PLAYER1 ,LED_FUNCTION_PLAYER2 ,
Signature · 1 line
2.36.1
Quoted 6 lines · Daniel J. Ogorchock
JC_RUMBLE_ZERO_AMP_PKT_CNTis only used when force feedback support in the driver is enabled. Place the declaration in theCONFIG_NINTENDO_FFifdef to avoid a warning when compiling without rumble support.Signed-off-by Daniel J. Ogorchock <[email protected]>---
LGTM!
Quoted 1 line
[...]
Quoted 22 lines · Daniel J. Ogorchock
JC_RUMBLE_ZERO_AMP_PKT_CNTis only used when force feedback support in the driver is enabled. Place the declaration in theCONFIG_NINTENDO_FFifdef to avoid a warning when compiling without rumble support.Signed-off-by Daniel J. Ogorchock <[email protected]>--- drivers/hid/hid-nintendo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/hid/hid-nintendo.c +1
-0@@ -292,6 +292,7 @@ static const struct joycon_rumble_amp_data joycon_rumble_amplitudes[] = { };static const u16 JC_RUMBLE_DFLT_LOW_FREQ =160 ;static const u16 JC_RUMBLE_DFLT_HIGH_FREQ =320 ; +static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT =5 ;#endif /* IS_ENABLED(CONFIG_NINTENDO_FF) */ static const u16 JC_RUMBLE_PERIOD_MS =50 ;
drivers/hid/hid-nintendo.c struct joycon_input_report { · line 407
Quoted 7 lines
drivers/hid/hid-nintendo.c +0
-2@@ -402,8 +403,6 @@ struct joycon_input_report {#define JC_RUMBLE_DATA_SIZE 8#define JC_RUMBLE_QUEUE_SIZE 8 -static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT =5 ; -static const char *const joycon_player_led_names[] = {LED_FUNCTION_PLAYER1 ,
Applied, thanks Daniel.
Signature · 2 lines
Jiri Kosina SUSE Labs