kbuild: ignore *.cmd files for objects that come from libgcc.a
Subsystems (2)
PATCH 1/1 kbuild: ignore *.cmd files for objects that come from libgcc.a
Guenter Roeck reported the build breakage for parisc and csky. I confirmed nios2 and openrisc are broken as well.
The reason is that they borrow libgcc.a from the toolchains.
For example, see this line in arch/parisc/Makefile:
LIBGCC := $(shell $(CC) -print-libgcc-file-name)
Some objects in libgcc.a are linked to vmlinux.o, but they do not have .*.cmd files.
Obviously, there is no EXPORT_SYMBOL in external objects. Ignore them.
(Most of the architectures import library code into the kernel tree. Perhaps those 4 architectures can do similar, but I am not sure.)
---
scripts/link-vmlinux.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
scripts/link-vmlinux.sh +8 -1
@@ -344,9 +344,16 @@ ${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init need-builtin=1 modpost_link vmlinux.o objtool_link vmlinux.o -# Generate the list of objects in vmlinux +# Generate the list of in-tree objects in vmlinux +# +# This is used to retrieve symbol versions generated by genksyms. for f in ${KBUILD_VMLINUX_OBJS} ${KBUILD_VMLINUX_LIBS}; do case ${f} in + *libgcc.a) + # Some architectures do '$(CC) --print-libgcc-file-name' to + # borrow libgcc.a from the toolchain. + # There is no EXPORT_SYMBOL in external objects. Ignore this. + ;; *.a) ${AR} t ${f} ;; *)
Signature · 1 line
2.32.0
Quoted 14 lines · Masahiro Yamada
Guenter Roeck reported the build breakage for parisc and csky. I confirmed nios2 and openrisc are broken as well.
The reason is that they borrow libgcc.a from the toolchains.
For example, see this line in
arch/parisc/Makefile:LIBGCC := $(shell $(CC) -print-libgcc-file-name)Some objects in libgcc.a are linked to vmlinux.o, but they do not have .*.cmd files.
Obviously, there is no
EXPORT_SYMBOLin external objects. Ignore them.
Quoted 7 lines
(Most of the architectures import library code into the kernel tree. Perhaps those 4 architectures can do similar, but I am not sure.)
Fixes f292d875d0dc ("modpost: extract symbol versions from *.cmd files")Link https://lore.kernel.org/linux-kbuild/[email protected]/T/#mac65c20c71c3e272db0350ecfba53fcd8905b0a0 open hereReported-by Guenter Roeck <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>
Quoted 27 lines
---
scripts/link-vmlinux.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)scripts/link-vmlinux.sh +8
-1@@ -344,9 +344,16 @@ ${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init need-builtin=1 modpost_link vmlinux.o objtool_link vmlinux.o -# Generate the list of objects in vmlinux +# Generate the list of in-tree objects in vmlinux +# +# This is used to retrieve symbol versions generated by genksyms. for f in ${KBUILD_VMLINUX_OBJS} ${KBUILD_VMLINUX_LIBS}; do case ${f} in + *libgcc.a) + # Some architectures do '$(CC) --print-libgcc-file-name' to + # borrow libgcc.a from the toolchain. + # There is no EXPORT_SYMBOL in external objects. Ignore this. + ;; *.a) ${AR} t ${f} ;; *)
Cc Joel, Nicolas
Quoted 2 lines · Masahiro Yamada
Guenter Roeck reported the build breakage for parisc and csky. I confirmed nios2 and openrisc are broken as well.
Joel reported and issue building the openrisc kernel as well with this error:
This fails at the link step:
LD vmlinux.o
+ or1k-elf-ld -r -o vmlinux.o --whole-archive arch/openrisc/kernel/head.o init/built-in.a usr/built-in.a arch/openrisc/built-in.a kernel/built-in.a certs/built-in.a mm/built-in.a fs/built-in.a ipc/built-in.a security/built-in.a crypto/built-in.a block/built-in.a lib/built-in.a drivers/built-in.a sound/built-in.a net/built-in.a virt/built-in.a --no-whole-archive --start-group lib/lib.a /usr/lib/gcc/or1k-elf/12/libgcc.a --end-group
or1k-elf-ld: /usr/lib/gcc/or1k-elf/12/libgcc.a: error adding symbols:
archive has no index; run ranlib to add one
Is it the same? It might be good to have details of the error in the commit message.
Quoted 6 lines
The reason is that they borrow libgcc.a from the toolchains.
For example, see this line in
arch/parisc/Makefile:LIBGCC := $(shell $(CC) -print-libgcc-file-name)
Quoted 7 lines
Some objects in libgcc.a are linked to vmlinux.o, but they do not have .*.cmd files.
Obviously, there is no
EXPORT_SYMBOLin external objects. Ignore them.(Most of the architectures import library code into the kernel tree. Perhaps those 4 architectures can do similar, but I am not sure.)
Ill have a look at this. Could you give an example of what you mean by import library code, from where? OpenRISC imports builtins from libgcc, also we have string and other lib routines from within the port.
-Stafford
Quoted 22 lines · Stafford Horne
Cc Joel, Nicolas
Quoted 2 lines · Masahiro Yamada
Guenter Roeck reported the build breakage for parisc and csky. I confirmed nios2 and openrisc are broken as well.
Joel reported and issue building the openrisc kernel as well with this error:
This fails at the link step:
LD vmlinux.o
+ or1k-elf-ld -r -o vmlinux.o --whole-archivearch/openrisc/kernel/head.oinit/built-in.ausr/built-in.aarch/openrisc/built-in.akernel/built-in.acerts/built-in.amm/built-in.afs/built-in.aipc/built-in.asecurity/built-in.acrypto/built-in.ablock/built-in.alib/built-in.adrivers/built-in.asound/built-in.anet/built-in.avirt/built-in.a--no-whole-archive --start-grouplib/lib.a/usr/lib/gcc/or1k-elf/12/libgcc.a--end-group
or1k-elf-ld:/usr/lib/gcc/or1k-elf/12/libgcc.a: error adding symbols:
archive has no index; run ranlib to add one
Quoted 2 lines
Is it the same? It might be good to have details of the error in the commit message.
Probably, no.
I do not know when the error above happens.
I got the following error message for ARCH=openrisc allmodconfig.
CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o AR init/built-in.a LD vmlinux.o
MODPOST vmlinux.symvers
.__mulsi3.o.cmd: No such file or directory
make[2]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1 make[1]: *** [Makefile:1160: vmlinux] Error 2
make: *** [Makefile:350: __build_one_by_one] Error 2
Quoted 12 lines
Quoted 12 lines
The reason is that they borrow libgcc.a from the toolchains.
For example, see this line in
arch/parisc/Makefile:LIBGCC := $(shell $(CC) -print-libgcc-file-name)Some objects in libgcc.a are linked to vmlinux.o, but they do not have .*.cmd files.
Obviously, there is no
EXPORT_SYMBOLin external objects. Ignore them.
Quoted 9 lines
Quoted 2 lines
(Most of the architectures import library code into the kernel tree. Perhaps those 4 architectures can do similar, but I am not sure.)
Ill have a look at this. Could you give an example of what you mean by import library code, from where? OpenRISC imports builtins from libgcc, also we have string and other lib routines from within the port.
-Stafford
"git grep __mulsi3" showed some *.S files of other architectures.
You can ask the authors of the following commits:
4e07dba7cb8c9c76a52d0e32b69f13bb583a9674dbf4ed894c0fd85d421f7b3b9758ce95398d2925
Signature · 2 lines
Best Regards Masahiro Yamada