Skip to contentSkip to conversation

support/testing: test_oci: update to _OCI_CMD option

PATCH Applied Romain Naour 3 participants 3 messages May 29, 2022 – Jun 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/testing: test_oci: update to _OCI_CMD option

BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].

Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains only one item, we can safely replace by BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment used by the test_oci test case.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058

[1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0

Cc Yann E. MORIN <[email protected]>
Cc Sergio Prado <[email protected]>
Cc Matthew Weber <[email protected]>
---
 support/testing/tests/fs/test_oci.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/fs/test_oci.py +1 -1
index 347332f30d..0ecf58f626 100644
@@ -20,7 +20,7 @@ class TestOci(infra.basetest.BRTest):
         BR2_TARGET_ROOTFS_EXT2_SIZE="600M"
         BR2_TARGET_ROOTFS_OCI=y
         BR2_TARGET_ROOTFS_OCI_ENTRYPOINT="df"
-        BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS="-h"
+        BR2_TARGET_ROOTFS_OCI_CMD="-h"
         BR2_TARGET_ROOTFS_OCI_ARCHIVE=y
         # BR2_TARGET_ROOTFS_TAR is not set
         """
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Romain, All,

On 2022-05-29 22:20 +0200, Romain Naour spake thusly:

Quoted 8 lines

BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].

Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains only one item, we can safely replace by BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment used by the test_oci test case.

Quoted 7 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058

[1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0

I'll be sure to pass the message to that guy, that he should be a bit more careful when he moves options to legacy. ;-)

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 26 lines
Cc Sergio Prado <[email protected]>
Cc Matthew Weber <[email protected]>
---
 support/testing/tests/fs/test_oci.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/testing/tests/fs/test_oci.py +1 -1
index 347332f30d..0ecf58f626 100644
@@ -20,7 +20,7 @@ class TestOci(infra.basetest.BRTest):
         BR2_TARGET_ROOTFS_EXT2_SIZE="600M"
         BR2_TARGET_ROOTFS_OCI=y
         BR2_TARGET_ROOTFS_OCI_ENTRYPOINT="df"
-        BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS="-h"
+        BR2_TARGET_ROOTFS_OCI_CMD="-h"
         BR2_TARGET_ROOTFS_OCI_ARCHIVE=y
         # BR2_TARGET_ROOTFS_TAR is not set
         """
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Romain Naour
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS option has been replaced by BR2_TARGET_ROOTFS_OCI_CMD in commit [1].

Since BR2_TARGET_ROOTFS_OCI_ENTRYPOINT_ARGS contains only one item, we can safely replace by BR2_TARGET_ROOTFS_OCI_CMD in the defconfig fragment used by the test_oci test case.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/2491321058

Quoted 6 lines

[1] 08d65d81d88418b0cd7edd3bd2227faa58d022f0

Cc Yann E. MORIN <[email protected]>
Cc Sergio Prado <[email protected]>
Cc Matthew Weber <[email protected]>

Committed to 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot