Skip to contentSkip to conversation

package/cmake: bump version to 3.22.3

PATCH In review Andrey Nechypurenko 2 participants 4 messages May 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/cmake: bump version to 3.22.3

Version 3.20 is the first one where the following issue is fixed:
https://gitlab.kitware.com/cmake/cmake/-/issues/18299
Was affected by this bug and decide to bump the version to the latest stable

---
 package/cmake/cmake.hash | 4 ++--
 package/cmake/cmake.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
package/cmake/cmake.hash +2 -2
index da514a6d6b..1749db8c27 100644
@@ -1,5 +1,5 @@
-# From https://cmake.org/files/v3.18/cmake-3.18.6-SHA-256.txt
-sha256  124f571ab70332da97a173cb794dfa09a5b20ccbb80a08e56570a500f47b6600  cmake-3.18.6.tar.gz
+# From https://cmake.org/files/v3.22/cmake-3.22.3-SHA-256.txt
+sha256  9f8469166f94553b6978a16ee29227ec49a2eb5ceb608275dec40d8ae0d1b5a0  cmake-3.22.3.tar.gz
 
 # Locally calculated
 sha256  131b9ff756b64a25b7461c3c1382e70b16c70a5b4833a1577897fa3ea6d88f8d  Copyright.txt
package/cmake/cmake.mk +2 -2
index 4177b119ab..053658fad6 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-CMAKE_VERSION_MAJOR = 3.18
-CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).6
+CMAKE_VERSION_MAJOR = 3.22
+CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).3
 CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
 CMAKE_LICENSE = BSD-3-Clause
 CMAKE_LICENSE_FILES = Copyright.txt
Signature · 6 lines
2.32.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi,

This is a little bit strange. The patch file located in outgoing directory and generated with

# git format-patch -M -n -s -o outgoing origin/master
do contains Signed-off-by: tag. However, the command
# git send-email --to [email protected] --cc-cmd
'./utils/get-developers -e' origin/master
leads to what could be seen in my previous mail - no Signed-off-by: tag.

Am I doing something wrong or are there some configuration options I am missing?

Thanks,
Andrey.

Quoted 38 lines · Andrey Nechypurenko

Version 3.20 is the first one where the following issue is fixed:
https://gitlab.kitware.com/cmake/cmake/-/issues/18299
Was affected by this bug and decide to bump the version to the latest stable

---
 package/cmake/cmake.hash | 4 ++--
 package/cmake/cmake.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
package/cmake/cmake.hash +2 -2
index da514a6d6b..1749db8c27 100644
@@ -1,5 +1,5 @@
-# From https://cmake.org/files/v3.18/cmake-3.18.6-SHA-256.txt
-sha256  124f571ab70332da97a173cb794dfa09a5b20ccbb80a08e56570a500f47b6600  cmake-3.18.6.tar.gz
+# From https://cmake.org/files/v3.22/cmake-3.22.3-SHA-256.txt
+sha256  9f8469166f94553b6978a16ee29227ec49a2eb5ceb608275dec40d8ae0d1b5a0  cmake-3.22.3.tar.gz
 
 # Locally calculated
 sha256  131b9ff756b64a25b7461c3c1382e70b16c70a5b4833a1577897fa3ea6d88f8d  Copyright.txt
package/cmake/cmake.mk +2 -3
index 4177b119ab..053658fad6 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-CMAKE_VERSION_MAJOR = 3.18
-CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).6
+CMAKE_VERSION_MAJOR = 3.22
+CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).3
 CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
 CMAKE_LICENSE = BSD-3-Clause
 CMAKE_LICENSE_FILES = Copyright.txt
--
Quoted 2 lines

2.32.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Hi Andrey,

Quoted 9 lines · Andrey Nechypurenko

This is a little bit strange. The patch file located in outgoing directory and generated with

# git format-patch -M -n -s -o outgoing origin/master
do contains Signed-off-by: tag. However, the command
# git send-email --to [email protected] --cc-cmd
'./utils/get-developers -e' origin/master
leads to what could be seen in my previous mail - no Signed-off-by: tag.

Am I doing something wrong or are there some configuration options I am missing?

The 'origin/master' parameter goes to 'git format-patch'. Which means that you are sending commits between origin/master..HEAD.

If you want git send-email to send you patch file, put that file as last parameter.

One more comment below.

Quoted 5 lines · Andrey Nechypurenko
Quoted 4 lines

Version 3.20 is the first one where the following issue is fixed:
https://gitlab.kitware.com/cmake/cmake/-/issues/18299
Was affected by this bug and decide to bump the version to the latest stable

This bump by itself does not fix the issue for hosts that have buggy cmake installed. To fix them you also need a separate patch to bump BR2_CMAKE_VERSION_MIN to a fixed version.

baruch

Quoted 39 lines
Quoted 33 lines
---
 package/cmake/cmake.hash | 4 ++--
 package/cmake/cmake.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
package/cmake/cmake.hash +2 -2
index da514a6d6b..1749db8c27 100644
@@ -1,5 +1,5 @@
-# From https://cmake.org/files/v3.18/cmake-3.18.6-SHA-256.txt
-sha256  124f571ab70332da97a173cb794dfa09a5b20ccbb80a08e56570a500f47b6600  cmake-3.18.6.tar.gz
+# From https://cmake.org/files/v3.22/cmake-3.22.3-SHA-256.txt
+sha256  9f8469166f94553b6978a16ee29227ec49a2eb5ceb608275dec40d8ae0d1b5a0  cmake-3.22.3.tar.gz
 
 # Locally calculated
 sha256  131b9ff756b64a25b7461c3c1382e70b16c70a5b4833a1577897fa3ea6d88f8d  Copyright.txt
package/cmake/cmake.mk +2 -3
index 4177b119ab..053658fad6 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-CMAKE_VERSION_MAJOR = 3.18
-CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).6
+CMAKE_VERSION_MAJOR = 3.22
+CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).3
 CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
 CMAKE_LICENSE = BSD-3-Clause
 CMAKE_LICENSE_FILES = Copyright.txt
--
Quoted 2 lines

2.32.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Hi Baruch,

Quoted 5 lines

The 'origin/master' parameter goes to 'git format-patch'. Which means that you are sending commits between origin/master..HEAD.

If you want git send-email to send you patch file, put that file as last parameter.

Thank you very much for the hint. Did it like you suggested and it looks good now.

Regards,
Andrey.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot