reduce the dependency on modules
Hi Shin'ichiro,
this series reduces the dependency of blktests on modular builds of various block drivers. There are still plenty of tests that do require modules, mostly because a lot of scsi_debug and null_blk can only be set at load time, but I plan to address those in the kernel soon.
PATCH 1/9 nvme: use _have_loop instead of _have_modules loop
Also check for the losetup existance.
--- tests/nvme/002 | 2 +- tests/nvme/003 | 2 +- tests/nvme/004 | 2 +- tests/nvme/005 | 3 +-- tests/nvme/006 | 2 +- tests/nvme/008 | 2 +- tests/nvme/010 | 2 +- tests/nvme/012 | 2 +- tests/nvme/014 | 2 +- tests/nvme/015 | 2 +- tests/nvme/018 | 2 +- tests/nvme/019 | 2 +- tests/nvme/021 | 2 +- tests/nvme/022 | 2 +- tests/nvme/023 | 2 +- tests/nvme/024 | 2 +- tests/nvme/025 | 2 +- tests/nvme/026 | 2 +- tests/nvme/027 | 2 +- tests/nvme/028 | 2 +- tests/nvme/029 | 2 +- tests/nvme/030 | 2 +- tests/nvme/031 | 2 +- 23 files changed, 23 insertions(+), 24 deletions(-)
tests/nvme/002 +1 -1
@@ -11,7 +11,7 @@ DESCRIPTION="create many subsystems and test discovery" requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_loop }
tests/nvme/003 +1 -1
@@ -12,7 +12,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/004 +1 -1
@@ -13,7 +13,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/005 +1 -2
@@ -12,8 +12,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop && \ - _have_module_param_value nvme_core multipath Y + _have_loop && _have_module_param_value nvme_core multipath Y _require_nvme_trtype_is_fabrics }
tests/nvme/006 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/008 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/010 +1 -1
@@ -11,7 +11,7 @@ TIMED=1 requires() { _nvme_requires - _have_fio && _have_modules loop + _have_fio && _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/012 +1 -1
@@ -14,7 +14,7 @@ requires() { _nvme_requires _have_xfs _have_fio - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/014 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/015 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/018 +1 -1
@@ -12,7 +12,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/019 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/021 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/022 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/023 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/024 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/025 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/026 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/027 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/028 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/029 +1 -1
@@ -12,7 +12,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/030 +1 -1
@@ -11,7 +11,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
tests/nvme/031 +1 -1
@@ -19,7 +19,7 @@ QUICK=1 requires() { _nvme_requires - _have_modules loop + _have_loop _require_nvme_trtype_is_fabrics }
Signature · 1 line
2.30.2
Re: [PATCH blktests 1/9] nvme: use _have_loop instead of _have_modules loop
Quoted 3 lines · Christoph Hellwig
Also check for the losetup existance.
Signed-off-by Christoph Hellwig <[email protected]>
Looks good to me.
Signature · 1 line
Shin'ichiro Kawasaki
PATCH 2/9 common: add a helper if a driver is available
In reply to Christoph HellwigUnlike _have_modules this allows allows for a built-in driver.
--- common/rc | 12 ++++++++++++ 1 file changed, 12 insertions(+)
common/rc +12 -0
@@ -28,6 +28,18 @@ _have_root() { return 0 } +_have_driver() +{ + local modname="${1/-/_}" + + if [ ! -d "/sys/module/${modname}" ] && ! modprobe -q ${modname}; then + SKIP_REASON="driver ${modname} is not available" + return 1 + fi + + return 0 +} + _have_modules() { local missing=() local module
Signature · 1 line
2.30.2
Re: [PATCH blktests 2/9] common: add a helper if a driver is available
Quoted 12 lines · Christoph Hellwig
Unlike
_have_modulesthis allows allows for a built-in driver.Signed-off-by Christoph Hellwig <[email protected]>--- common/rc | 12 ++++++++++++ 1 file changed, 12 insertions(+)common/rc +0
-0
common/rc _have_root() { · line 35
Quoted 8 lines
common/rc +5
-0@@ -28,6 +28,18 @@ _have_root() { return 0 } +_have_driver() +{ + local modname="${1/-/_}" + + if [ ! -d "/sys/module/${modname}" ] && ! modprobe -q ${modname}; then
Nit: double quote is required for ${modname} to make shellcheck happy.
Other than that, looks good to me.
Signature · 1 line
Shin'ichiro Kawasaki
Re: [PATCH blktests 2/9] common: add a helper if a driver is available
Quoted 7 lines · Shinichiro Kawasaki
common/rc _have_root() { · line 35
Quoted 5 lines
common/rc +5
-0+_have_driver() +{ + local modname="${1/-/_}" + + if [ ! -d "/sys/module/${modname}" ] && ! modprobe -q ${modname}; thenNit: double quote is required for ${modname} to make shellcheck happy.
It is aready quote when assigning to modname, so there is no actual need. But I'll add the quotes to make the checker happy.
PATCH 3/9 common: fix _have_module_param_value to work with built-in drivers
In reply to Christoph HellwigDon't bother to call modprobe directly and just check the /sys/module/ directory. Also switch to using descriptive variable names for the paramters.
--- common/rc | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
common/rc +10 -5
@@ -74,17 +74,22 @@ _have_module_param() { } _have_module_param_value() { + local modname="${1/-/_}" + local param="$2" + local expected_value="$3" local value - modprobe "$1" + if ! have_driver $modname; then + return 1; + fi - if ! _have_module_param "$1" "$2"; then + if ! _have_module_param $modname $param; then return 1 fi - value=$(cat "/sys/module/$1/parameters/$2") - if [[ "${value}" != "$3" ]]; then - SKIP_REASON="$1 module parameter $2 must be set to $3" + value=$(cat "/sys/module/$modname/parameters/$param") + if [[ "${value}" != "$expected_value" ]]; then + SKIP_REASON="$modname module parameter $param must be set to $expected_value" return 1 fi
Signature · 1 line
2.30.2
Re: [PATCH blktests 3/9] common: fix _have_module_param_value to work with built-in drivers
Quoted 3 lines · Christoph Hellwig
Don't bother to call modprobe directly and just check the
/sys/module/directory. Also switch to using descriptive variable names for the paramters.
s/paramters/parameters/
Quoted 11 lines
Signed-off-by Christoph Hellwig <[email protected]>--- common/rc | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)common/rc +0
-0
common/rc _have_module_param() { · line 82
Quoted 10 lines
common/rc +4
-1@@ -74,17 +74,22 @@ _have_module_param() { } _have_module_param_value() { + local modname="${1/-/_}" + local param="$2" + local expected_value="$3" local value - modprobe "$1" + if ! have_driver $modname; then
Underscore is missing for '_have_driver'. Also, shellcheck requires double quote of $modname.
common/rc _have_module_param() { · line 86
Quoted 5 lines
common/rc +3
-1+ return 1; + fi - if ! _have_module_param "$1" "$2"; then + if ! _have_module_param $modname $param; then
Same here, double quotes are required for $modname and $param.
Quoted 15 lines
common/rc +3
-3return 1 fi - value=$(cat "/sys/module/$1/parameters/$2") - if [[ "${value}" != "$3" ]]; then - SKIP_REASON="$1 module parameter $2 must be set to $3" + value=$(cat "/sys/module/$modname/parameters/$param") + if [[ "${value}" != "$expected_value" ]]; then + SKIP_REASON="$modname module parameter $param must be set to $expected_value" return 1 fiSignature · 1 line
2.30.2
Signature · 1 line
Shin'ichiro Kawasaki
PATCH 4/9 common: do not require loop support to be modular
In reply to Christoph HellwigUse _have_driver instead of _have_modules in _have_loop as nothing requires the loop driver to be modular.
--- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
@@ -128,7 +128,7 @@ _have_src_program() { } _have_loop() { - _have_modules loop && _have_program losetup + _have_driver loop && _have_program losetup } _have_blktrace() {
Signature · 1 line
2.30.2
Re: [PATCH blktests 4/9] common: do not require loop support to be modular
Quoted 4 lines · Christoph Hellwig
Use
_have_driverinstead of_have_modulesin_have_loopas nothing requires the loop driver to be modular.Signed-off-by Christoph Hellwig <[email protected]>
Looks good to me.
Signature · 1 line
Shin'ichiro Kawasaki
PATCH 5/9 common: do not require null_blk support to be modular
In reply to Christoph HellwigUse _have_driver instead of _have_modules in _have_null_blk for the basic null_blk check, and instead only require an actual module in _init_null_blk when specific module parameters are passed.
--- common/null_blk | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
common/null_blk +10 -6
@@ -5,7 +5,7 @@ # null_blk helper functions. _have_null_blk() { - _have_modules null_blk + _have_driver null_blk } _remove_null_blk_devices() {
@@ -16,15 +16,19 @@ _remove_null_blk_devices() { } _init_null_blk() { - _remove_null_blk_devices + local modparams="$@" - local zoned="" - if (( RUN_FOR_ZONED )); then zoned="zoned=1"; fi + if (( RUN_FOR_ZONED )); then + modparams="${modparams} zoned=1" + fi - if ! modprobe -r null_blk || ! modprobe null_blk "$@" "${zoned}" ; then + if [ -n "${modparams}" ] && ! _have_modules null_blk; then return 1 fi + _remove_null_blk_devices + modprobe -qr null_blk && modprobe -q null_blk ${modparams} + udevadm settle return 0 }
@@ -46,5 +50,5 @@ _configure_null_blk() { _exit_null_blk() { _remove_null_blk_devices udevadm settle - modprobe -r null_blk + modprobe -qr null_blk }
Signature · 1 line
2.30.2
Re: [PATCH blktests 5/9] common: do not require null_blk support to be modular
Quoted 23 lines · Christoph Hellwig
Use
_have_driverinstead of_have_modulesin_have_null_blkfor the basicnull_blkcheck, and instead only require an actual module in_init_null_blkwhen specific module parameters are passed.Signed-off-by Christoph Hellwig <[email protected]>--- common/null_blk | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)common/null_blk +1
-1@@ -5,7 +5,7 @@ # null_blk helper functions. _have_null_blk() { - _have_modules null_blk + _have_driver null_blk } _remove_null_blk_devices() {
common/null_blk _remove_null_blk_devices() { · line 19
Quoted 5 lines
common/null_blk +1
-1@@ -16,15 +16,19 @@ _remove_null_blk_devices() { } _init_null_blk() { - _remove_null_blk_devices + local modparams="$@"
Shellcheck complains on this line:
common/null_blk:19:18: warning: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. [SC2124]
I think array would be the better.
common/null_blk _remove_null_blk_devices() { · line 25
Quoted 9 lines
common/null_blk +4
-3- local zoned="" - if (( RUN_FOR_ZONED )); then zoned="zoned=1"; fi + if (( RUN_FOR_ZONED )); then + modparams="${modparams} zoned=1" + fi - if ! modprobe -r null_blk || ! modprobe null_blk "$@" "${zoned}" ; then + if [ -n "${modparams}" ] && ! _have_modules null_blk; then
I tried this part on my test machine and it looks that '_have_modules null_blk' returns 0=success even when null_blk module is built-in. This may not be what you intended here. I think _have_modules needs modification so that it returns 1=failure when one of the modules is built-in. (At least until all null_blk parameters get supported by configfs.)
common/null_blk _remove_null_blk_devices() { · line 30
Quoted 5 lines
common/null_blk +2
-0return 1 fi + _remove_null_blk_devices + modprobe -qr null_blk && modprobe -q null_blk ${modparams}
Double quotes for ${modparams} is required for shellcheck.
Signature · 1 line
Shin'ichiro Kawasaki
PATCH 6/9 nbd: do not require nbd support to be modular
In reply to Christoph HellwigUse _have_driver instead of _have_modules in _have_nbd as nothing requires the nbd driver to be modular.
--- tests/nbd/rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/nbd/rc +2 -2
@@ -7,11 +7,11 @@ . common/rc group_requires() { - _have_root && _have_nbd && modprobe nbd + _have_root && _have_nbd } _have_nbd() { - if ! _have_modules nbd; then + if ! _have_driver nbd; then return 1 fi if ! _have_program nbd-server; then
Signature · 1 line
2.30.2
PATCH 7/9 scsi: don't require sg to be built in
In reply to Christoph HellwigUse _have_driver instead of _have_modules in _have_scsi_generic as nothing requires the sg driver to be modular.
--- tests/scsi/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/scsi/rc +1 -1
@@ -15,7 +15,7 @@ group_device_requires() { } _have_scsi_generic() { - _have_modules sg + _have_driver sg } _require_test_dev_is_scsi() {
Signature · 1 line
2.30.2
PATCH 8/9 nvme: don't require the nvme drivers to be built in
In reply to Christoph HellwigUse _have_driver instead of _have_modules to check for the availability of the nvme drivers, and don't bother checking at all for drivers that are pulled in as dependencies.
--- tests/nvme/rc | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
tests/nvme/rc +13 -11
@@ -16,21 +16,23 @@ _nvme_requires() { _have_program nvme case ${nvme_trtype} in loop) - _have_modules nvmet nvme-core nvme-loop + _have_driver nvme-loop _have_configfs ;; pci) - _have_modules nvme nvme-core + _have_driver nvme ;; tcp) - _have_modules nvmet nvme-core nvme-tcp nvmet-tcp + _have_driver nvme-tcp + _have_driver nvmet-tcp _have_configfs ;; rdma) - _have_modules nvmet nvme-core nvme-rdma nvmet-rdma + _have_driver nvme-rdma + _have_driver nvmet-rdma _have_configfs _have_program rdma - _have_modules rdma_rxe || _have_modules siw + _have_driver rdma_rxe || _have_driver siw ;; *) SKIP_REASON="unsupported nvme_trtype=${nvme_trtype}"
@@ -125,11 +127,11 @@ _cleanup_nvmet() { shopt -u nullglob trap SIGINT - modprobe -r nvme-"${nvme_trtype}" 2>/dev/null + modprobe -rq nvme-"${nvme_trtype}" 2>/dev/null if [[ "${nvme_trtype}" != "loop" ]]; then - modprobe -r nvmet-"${nvme_trtype}" 2>/dev/null + modprobe -rq nvmet-"${nvme_trtype}" 2>/dev/null fi - modprobe -r nvmet 2>/dev/null + modprobe -rq nvmet 2>/dev/null if [[ "${nvme_trtype}" == "rdma" ]]; then stop_soft_rdma fi
@@ -137,11 +139,11 @@ _cleanup_nvmet() { _setup_nvmet() { _register_test_cleanup _cleanup_nvmet - modprobe nvmet + modprobe -q nvmet if [[ "${nvme_trtype}" != "loop" ]]; then - modprobe nvmet-"${nvme_trtype}" + modprobe -q nvmet-"${nvme_trtype}" fi - modprobe nvme-"${nvme_trtype}" + modprobe -q nvme-"${nvme_trtype}" if [[ "${nvme_trtype}" == "rdma" ]]; then start_soft_rdma for i in $(rdma_network_interfaces)
Signature · 1 line
2.30.2
PATCH 9/9 common: do not require scsi_debug support to be modular
In reply to Christoph HellwigUse _have_driver instead of _have_modules in _have_scsi_debug for the basic scsi_debug check, and instead only require an actual module in _init_null_blk when specific module parameters are passed.
--- common/scsi_debug | 14 ++++++++++---- tests/block/001 | 4 +++- 2 files changed, 13 insertions(+), 5 deletions(-)
common/scsi_debug +10 -4
@@ -5,7 +5,7 @@ # scsi_debug helper functions. _have_scsi_debug() { - _have_modules scsi_debug + _have_driver scsi_debug } _init_scsi_debug() {
@@ -18,8 +18,14 @@ _init_scsi_debug() { args+=(zbc=host-managed zone_nr_conv=0) fi - if ! modprobe -r scsi_debug || ! modprobe scsi_debug "${args[@]}"; then - return 1 + if ((${#args[@]})); then + if ! modprobe -qr scsi_debug; then + exit 1 + fi + if ! modprobe scsi_debug "${args[@]}"; then + SKIP_REASON="scsi_debug not modular" + return 1 + fi fi udevadm settle
@@ -60,5 +66,5 @@ _exit_scsi_debug() { unset SCSI_DEBUG_TARGETS unset SCSI_DEBUG_DEVICES udevadm settle - modprobe -r scsi_debug + modprobe -rq scsi_debug }
tests/block/001 +3 -1
@@ -13,7 +13,9 @@ DESCRIPTION="stress device hotplugging" TIMED=1 requires() { - _have_scsi_debug && _have_modules sd_mod sr_mod + _have_scsi_debug + _have_driver sd_mod + _have_driver sr_mod } stress_scsi_debug() {
Signature · 1 line
2.30.2
Re: [PATCH blktests 9/9] common: do not require scsi_debug support to be modular
Quoted 25 lines · Christoph Hellwig
Use
_have_driverinstead of_have_modulesin_have_scsi_debugfor the basicscsi_debugcheck, and instead only require an actual module in_init_null_blkwhen specific module parameters are passed.Signed-off-by Christoph Hellwig <[email protected]>--- common/scsi_debug | 14 ++++++++++---- tests/block/001 | 4 +++- 2 files changed, 13 insertions(+), 5 deletions(-)common/scsi_debug +1
-1@@ -5,7 +5,7 @@ # scsi_debug helper functions. _have_scsi_debug() { - _have_modules scsi_debug + _have_driver scsi_debug } _init_scsi_debug() {@@ -18,8 +18,14 @@ _init_scsi_debug() { args+=(zbc=host-managed zone_nr_conv=0)
common/scsi_debug _init_scsi_debug() { · line 26
Quoted 10 lines
common/scsi_debug +6
-2fi - if ! modprobe -r scsi_debug || ! modprobe scsi_debug "${args[@]}"; then - return 1 + if ((${#args[@]})); then + if ! modprobe -qr scsi_debug; then + exit 1 + fi + if ! modprobe scsi_debug "${args[@]}"; then + SKIP_REASON="scsi_debug not modular"
I tried scsi_debug built-in kernel and observed that 'modprobe -qr scsi_debug' command fails, and the script exits at the line of "exit 1". The SKIP_REASON comment above will not be printed. I think we need to check the scsi_debug is not built-in. As I commented for _init_null_blk, _have_modules needs modification to check if the module is not built-in. I guess it can be used for scsi_debug also.
Signature · 1 line
Shin'ichiro Kawasaki
Re: [PATCH blktests 9/9] common: do not require scsi_debug support to be modular
Quoted 28 lines · Shinichiro Kawasaki
Quoted 27 lines · Christoph Hellwig
Use
_have_driverinstead of_have_modulesin_have_scsi_debugfor the basicscsi_debugcheck, and instead only require an actual module in_init_null_blkwhen specific module parameters are passed.Signed-off-by Christoph Hellwig <[email protected]>--- common/scsi_debug | 14 ++++++++++---- tests/block/001 | 4 +++- 2 files changed, 13 insertions(+), 5 deletions(-)common/scsi_debug +1
-1@@ -5,7 +5,7 @@ # scsi_debug helper functions. _have_scsi_debug() { - _have_modules scsi_debug + _have_driver scsi_debug } _init_scsi_debug() {@@ -18,8 +18,14 @@ _init_scsi_debug() { args+=(zbc=host-managed zone_nr_conv=0) fi
Quoted 15 lines
common/scsi_debug _init_scsi_debug() { · line 26
Quoted 8 lines
common/scsi_debug +6
-2- if ! modprobe -r scsi_debug || ! modprobe scsi_debug "${args[@]}"; then - return 1 + if ((${#args[@]})); then + if ! modprobe -qr scsi_debug; then + exit 1 + fi + if ! modprobe scsi_debug "${args[@]}"; then + SKIP_REASON="scsi_debug not modular"I tried
scsi_debugbuilt-in kernel and observed that 'modprobe -qrscsi_debug' command fails, and the script exits at the line of "exit 1". TheSKIP_REASONcomment above will not be printed. I think we need to check thescsi_debugis not built-in. As I commented for_init_null_blk,_have_modulesneeds modification to check if the module is not built-in. I guess it can be used forscsi_debugalso.
Another nit: the SKIP_REASON value update will make shellcheck complain:
common/scsi_debug:26:4: warning: SKIP_REASON appears unused. Verify use (or export if used externally). [SC2034]
As some of other common/* does, sourcing common/shellcheck at beginning of common/scsi_debug will avoid it.
Signature · 1 line
Shin'ichiro Kawasaki
Jens Axboe
maintainerQuoted 7 lines · Christoph Hellwig
Hi Shin'ichiro,
this series reduces the dependency of blktests on modular builds of various block drivers. There are still plenty of tests that do require modules, mostly because a lot of
scsi_debugandnull_blkcan only be set at load time, but I plan to address those in the kernel soon.
Which null_blk options can only be set at load time? If there are some, we should get them fixed up / added to the configfs side. Yes, the configfs side also kind of sucks, but at least it's there.
Signature · 1 line
Jens Axboe
Quoted 1 line · Jens Axboe
Which
null_blkoptions can only be set at load time?
The example I ran into is the queue mode.
Quoted 3 lines
If there are some,
we should get them fixed up / added to the configfs side. Yes, the configfs side also kind of sucks, but at least it's there.
That is my plan. I just wanted to get this series out first and then work on the non-tivial bits involving the kernel.
Quoted 7 lines · Christoph Hellwig
Hi Shin'ichiro,
this series reduces the dependency of blktests on modular builds of various block drivers. There are still plenty of tests that do require modules, mostly because a lot of
scsi_debugandnull_blkcan only be set at load time, but I plan to address those in the kernel soon.
Hi Christoph, thank you for the pathces. I think this is the nice first-step to avoid the module load dependency.
I tried to run blktests with the patches. At first, I kept blktests dependent drivers as modules, and observed no additional failure. Good. As the next step, I ran blktests making blktests dependent drivers built into kernel, and observed some unexpected behaviors. For example, block/016, which calls _init_null_blk, was not skipped and failed. block/025, which calls _init_scsi_debug was terminated unexpectedly. I made related comments on 5th and 9th patches.
My other comments are nits. Many of them are related to shellcheck warnings. It will be appreciated to run 'make check' command to see the warnings and clean them up.
Signature · 1 line
Shin'ichiro Kawasaki