Skip to contentSkip to conversation

package/qemu: add qemu host tools

PATCH In review Thomas Devoogdt 3 participants 4 messages May 30, 2022 – Jun 27, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qemu: add qemu host tools

From: Thomas Devoogdt <[email protected]>

Allow host tools e.g. qemu-img to be built.
Similar to the BR2_PACKAGE_QEMU_TOOLS option.

---
 package/qemu/Config.in.host | 6 ++++++
 package/qemu/qemu.mk        | 6 ++++++
 2 files changed, 12 insertions(+)
package/qemu/Config.in.host +6 -0
index f9cdb9b703..2aa6991263 100644
@@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
 	help
 	  Enables USB passthrough support from guest to host.
 
+config BR2_PACKAGE_HOST_QEMU_TOOLS
+	bool "Enable tools"
+	help
+	  Say 'y' here to include tools packaged with QEMU
+	  (e.g. qemu-img).
+
 endif
package/qemu/qemu.mk +6 -0
index 1bcffc2340..9623068c93 100644
@@ -348,6 +348,12 @@ else
 HOST_QEMU_OPTS += --disable-libusb
 endif
 
+ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
+HOST_QEMU_OPTS += --enable-tools
+else
+HOST_QEMU_OPTS += --disable-tools
+endif
+
 # Override CPP, as it expects to be able to call it like it'd
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Thomas,

Quoted 16 lines · Thomas Devoogdt

From: Thomas Devoogdt <[email protected]>

Allow host tools e.g. qemu-img to be built.
Similar to the BR2_PACKAGE_QEMU_TOOLS option.

---
  package/qemu/Config.in.host | 6 ++++++
  package/qemu/qemu.mk        | 6 ++++++
  2 files changed, 12 insertions(+)
package/qemu/Config.in.host +0 -0
index f9cdb9b703..2aa6991263 100644

package/qemu/Config.in.host config BR2_PACKAGE_HOST_QEMU_USB · line 109

Quoted 8 lines
package/qemu/Config.in.host +5 -0
@@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
  	help
  	  Enables USB passthrough support from guest to host.
 
+config BR2_PACKAGE_HOST_QEMU_TOOLS
+	bool "Enable tools"
+	help
+	  Say 'y' here to include tools packaged with QEMU
+	  (e.g. qemu-img).

For host packages, there's no rootfs size constraint, so there is normally no
reason to have sub-options. Only if it would dramatically increase the build time, it's worth to make an option for this feature.

In other words: simply do --enable-tools unconditionally.

Regards,
Arnout

Quoted 9 lines
package/qemu/Config.in.host +1 -0
+
  endif
package/qemu/qemu.mk +0 -0
index 1bcffc2340..9623068c93 100644
@@ -348,6 +348,12 @@ else
  HOST_QEMU_OPTS += --disable-libusb
  endif

package/qemu/qemu.mk else · line 359

Quoted 10 lines
package/qemu/qemu.mk +6 -0
 
+ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
+HOST_QEMU_OPTS += --enable-tools
+else
+HOST_QEMU_OPTS += --disable-tools
+endif
+
  # Override CPP, as it expects to be able to call it like it'd
  # call the compiler.
  define HOST_QEMU_CONFIGURE_CMDS

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Hi,

I did not find a way to update this series (using git send-email), should I send my mail to something else than [email protected]? Anyway, a new patch can be found here:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Kind regards,

Thomas Devoogdt

Op ma 20 jun. 2022 om 21:40 schreef Arnout Vandecappelle <[email protected]>:

Quoted 49 lines

Hi Thomas,

Quoted 16 lines · Thomas Devoogdt

From: Thomas Devoogdt <[email protected]>

Allow host tools e.g. qemu-img to be built.
Similar to the BR2_PACKAGE_QEMU_TOOLS option.

---
  package/qemu/Config.in.host | 6 ++++++
  package/qemu/qemu.mk        | 6 ++++++
  2 files changed, 12 insertions(+)
package/qemu/Config.in.host +0 -0
index f9cdb9b703..2aa6991263 100644

package/qemu/Config.in.host config BR2_PACKAGE_HOST_QEMU_USB · line 109

Quoted 8 lines
package/qemu/Config.in.host +5 -0
@@ -102,4 +102,10 @@ config BR2_PACKAGE_HOST_QEMU_USB
      help
        Enables USB passthrough support from guest to host.
 
+config BR2_PACKAGE_HOST_QEMU_TOOLS
+     bool "Enable tools"
+     help
+       Say 'y' here to include tools packaged with QEMU
+       (e.g. qemu-img).

For host packages, there's no rootfs size constraint, so there is
normally no
reason to have sub-options. Only if it would dramatically increase the build
time, it's worth to make an option for this feature.

In other words: simply do --enable-tools unconditionally.

Regards,
Arnout

Quoted 10 lines
package/qemu/Config.in.host +1 -0
+
  endif
package/qemu/qemu.mk +0 -0
index 1bcffc2340..9623068c93 100644
@@ -348,6 +348,12 @@ else
  HOST_QEMU_OPTS += --disable-libusb
  endif
 
Quoted 10 lines

package/qemu/qemu.mk else · line 359

Quoted 9 lines
package/qemu/qemu.mk +6 -0
+ifeq ($(BR2_PACKAGE_HOST_QEMU_TOOLS),y)
+HOST_QEMU_OPTS += --enable-tools
+else
+HOST_QEMU_OPTS += --disable-tools
+endif
+
  # Override CPP, as it expects to be able to call it like it'd
  # call the compiler.
  define HOST_QEMU_CONFIGURE_CMDS

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Devoogdt <[email protected]> writes:

Hi,
I did not find a way to update this series (using git send-email), should I send my mail to something else than [email protected]? Anyway, a new patch can be found here:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Simple send a v2 patch (git send-email -v2 ..) and login to patchwork to mark your v1 patch as superseeded, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot