Skip to contentSkip to conversation

erofs: fix 'backmost' member of z_erofs_decompress_frontend

PATCH In review Weizhao Ouyang 4 participants 4 messages May 30, 2022 – May 31, 2022 EROFS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 erofs: fix 'backmost' member of z_erofs_decompress_frontend

Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.

Fixes 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
---
 fs/erofs/zdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/erofs/zdata.c +1 -1
index 95efc127b2ba..94d2cb970644 100644
@@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
 
 #define DECOMPRESS_FRONTEND_INIT(__i) { \
 	.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
-	.mode = COLLECT_PRIMARY_FOLLOWED }
+	.mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
 
 static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
 static DEFINE_MUTEX(z_pagemap_global_lock);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Weizhao Ouyang

Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.

Fixes 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")

Many thanks for the in-time catching! ;)

Thanks,
Gao Xiang

Quoted 19 lines
---
 fs/erofs/zdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/erofs/zdata.c +1 -1
index 95efc127b2ba..94d2cb970644 100644
@@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
 
 #define DECOMPRESS_FRONTEND_INIT(__i) { \
 	.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
-	.mode = COLLECT_PRIMARY_FOLLOWED }
+	.mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
 
 static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
 static DEFINE_MUTEX(z_pagemap_global_lock);
Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Weizhao Ouyang
Quoted 4 lines · On Mon, 30 May 2022 15:51:14 +0800 Weizhao Ouyang <[email protected]> wrote:

Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.

Fixes 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")

Good catch.

Quoted 17 lines
---
 fs/erofs/zdata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/erofs/zdata.c +1 -1
index 95efc127b2ba..94d2cb970644 100644
@@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
 
 #define DECOMPRESS_FRONTEND_INIT(__i) { \
 	.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
-	.mode = COLLECT_PRIMARY_FOLLOWED }
+	.mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
 
 static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
 static DEFINE_MUTEX(z_pagemap_global_lock);