mm: page_isolation: use compound_nr() correctly in isolate_single_pageblock()
Subsystems (2)
PATCH 1/1 mm: page_isolation: use compound_nr() correctly in isolate_single_pageblock()
From: Zi Yan <[email protected]>
When compound_nr(page) was used, page was not guaranteed to be the head of the compound page and it could cause an infinite loop. Fix it by calling it on the head page.
--- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_isolation.c +1 -1
@@ -385,9 +385,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,* above do the rest. If migration is not possible, just fail. */ if (PageCompound (page)) { -unsigned long nr_pages =compound_nr (page);struct page *head =compound_head (page);unsigned long head_pfn =page_to_pfn (head); +unsigned long nr_pages =compound_nr (head);if (head_pfn + nr_pages <= boundary_pfn) { pfn = head_pfn + nr_pages;
Signature · 1 line
2.35.1
Quoted 10 lines · Zi Yan
From: Zi Yan <[email protected]>
When
compound_nr(page)was used, page was not guaranteed to be the head of the compound page and it could cause an infinite loop. Fix it by calling it on the head page.Fixes b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity")Reported-by Anshuman Khandual <[email protected]>Signed-off-by Zi Yan <[email protected]>
Quoted 19 lines
--- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page_isolation.c +1
-1@@ -385,9 +385,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,* above do the rest. If migration is not possible, just fail. */ if (PageCompound (page)) { -unsigned long nr_pages =compound_nr (page);struct page *head =compound_head (page);unsigned long head_pfn =page_to_pfn (head); +unsigned long nr_pages =compound_nr (head);if (head_pfn + nr_pages <= boundary_pfn) { pfn = head_pfn + nr_pages;
Quoted 10 lines · Zi Yan
From: Zi Yan <[email protected]>
When
compound_nr(page)was used, page was not guaranteed to be the head of the compound page and it could cause an infinite loop. Fix it by calling it on the head page.Fixes b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity")Reported-by Anshuman Khandual <[email protected]>Signed-off-by Zi Yan <[email protected]>
Thanks.
Quoted 10 lines · Zi Yan
From: Zi Yan <[email protected]>
When
compound_nr(page)was used, page was not guaranteed to be the head of the compound page and it could cause an infinite loop. Fix it by calling it on the head page.Fixes b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity")Reported-by Anshuman Khandual <[email protected]>Signed-off-by Zi Yan <[email protected]>
Quoted 22 lines
--- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page_isolation.c +1
-1@@ -385,9 +385,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,* above do the rest. If migration is not possible, just fail. */ if (PageCompound (page)) { -unsigned long nr_pages =compound_nr (page);struct page *head =compound_head (page);unsigned long head_pfn =page_to_pfn (head); +unsigned long nr_pages =compound_nr (head);if (head_pfn + nr_pages <= boundary_pfn) { pfn = head_pfn + nr_pages;Signature · 1 line
2.35.1
Signature · 2 lines
Oscar Salvador SUSE Labs
Quoted 10 lines · Zi Yan
From: Zi Yan <[email protected]>
When
compound_nr(page)was used, page was not guaranteed to be the head of the compound page and it could cause an infinite loop. Fix it by calling it on the head page.Fixes b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity")Reported-by Anshuman Khandual <[email protected]>Signed-off-by Zi Yan <[email protected]>
LGTM. Thanks!
Quoted 20 lines
--- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page_isolation.c +1
-1@@ -385,9 +385,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,* above do the rest. If migration is not possible, just fail. */ if (PageCompound (page)) { -unsigned long nr_pages =compound_nr (page);struct page *head =compound_head (page);unsigned long head_pfn =page_to_pfn (head); +unsigned long nr_pages =compound_nr (head);if (head_pfn + nr_pages <= boundary_pfn) { pfn = head_pfn + nr_pages;