CXL: Read CDAT and DSMAS data
v9 cover CXL: Read CDAT and DSMAS data
From: Ira Weiny <[email protected]>
Changes from V8:[5]
For this version I've punted a bit to get it out and drop the auxiliary bus functionality. I like where Jonathan is going with the port driver idea. I think eventually the irq/mailbox creation will need to be more generic in a PCI port driver. I've modeled this version on such an architecture but used the CXL port for the time being.
From Dan
Drop the auxiliary bus/device
From Jonathan
Cleanups
From Bjorn
Clean up commit messages
move pci-doe.c to doe.c
Clean up PCI spec references
Ensure all messages use pci_*()
Add offset to error messages to distinguish mailboxes
use hex for DOE offsets
Print 4 nibbles for Vendor ID and 2 for type. s/irq/IRQ in comments
Fix long lines
Fix typos
Changes from V7:[4]
Avoid code bloat by making pci-doe.c conditional on CONFIG_PCI_DOE
which is auto selected by the CXL_PCI config option.
Minor code clean ups
Fix bug in pci_doe_supports_prot()
Rebase to cxl-pending
Changes from V6:[3]
The big change is the removal of the auxiliary bus code from the PCI layer. The auxiliary bus usage is now in the CXL layer. The PCI layer provides helpers for subsystems to utilize DOE mailboxes by creating a pci_doe_mb object which controls a state machine for that mailbox capability. The CXL layer wraps this object in an auxiliary device and driver which can then be used to determine if the kernel is controlling the capability or it is available to be used by user space. Reads from user space via lspci are allowed. Writes are allowed but flagged via a tainting the kernel.
Feedback from Bjorn, Jonathan, and Dan
Details in each patch
Changes from V5:[0]
Rework the patch set to split PCI vs CXL changes
Also make each change a bit more stand alone for easier review
Add cxl_cdat structure
Put CDAT related data structures in cdat.h
Clarify some device lifetimes with comments
Incorporate feedback from Jonathan, Bjorn and Dan
The bigest change is placing the DOE scanning code into the
pci_doe driver (part of the PCI codre).
Validate the CDAT when it is read rather than before DSMAS
parsing
Do not report DSMAS failure as an error, report a warning and
keep going.
Retry reading the table 1 time.
Update commit messages and this cover letter
CXL drivers need various data which are provided through generic DOE mailboxes as defined in the PCIe 6.0 spec.[1]
One such data is the Coherent Device Atribute Table (CDAT). CDAT data provides coherent information about the various devices in the system. It was developed because systems no longer have a priori knowledge of all coherent devices within a system. CDAT describes the coherent characteristics of the components on the CXL bus separate from system configurations. The OS can then, for example, use this information to form correct interleave sets.
To begin reading the CDAT the OS must have support to access the DOE mailboxes provided by the CXL devices.
Because DOE is not specific to DOE but is provided within the PCI spec, the series adds PCI DOE capability library functions. These functions allow for the iteration of the DOE capabilities on a device as well as creating pci_doe_mb structures which can control the operation of the DOE state machine.
CXL iterates the DOE capabilities creates auxiliary bus devices. These devices are driven by a CXL DOE auxiliary driver which calls into the PCI DOE library functions as appropriate.
The auxiliary bus architecture allows for root users to control which DOE mailboxes are controlled by the kernel and which should be allowed for unrestricted access by user space. One such use case is to allow for CXL Compliance Testing (CXL 2.0 14.16.4 Compliance Mode DOE). By default the kernel controls all mailboxes found.
After the devices are created and the driver attaches, CDAT data is read from the device and DSMAS information parsed from that CDAT blob for use later.
This work was tested using qemu with additional patches.
[0] https://lore.kernel.org/linux-cxl/[email protected]/
[1] https://pcisig.com/specifications
[2] https://lore.kernel.org/qemu-devel/[email protected]/
[3] https://lore.kernel.org/linux-cxl/[email protected]/
[4] https://lore.kernel.org/linux-cxl/[email protected]/
[5] https://lore.kernel.org/linux-cxl/[email protected]/
Ira Weiny (6):
PCI: Replace magic constant for PCI Sig Vendor ID cxl/pci: Create PCI DOE mailbox's for memory devices cxl/port: Find a DOE mailbox which supports CDAT cxl/port: Introduce cxl_cdat_valid() cxl/port: Retry reading CDAT on failure cxl/port: Parse out DSMAS data from CDAT table
Jonathan Cameron (3):
PCI: Add vendor ID for the PCI SIG
PCI: Create PCI library functions in support of DOE mailboxes. cxl/port: Read CDAT table
drivers/cxl/Kconfig | 1 +drivers/cxl/cdat.h | 118 +++++++ drivers/cxl/core/pci.c | 267 ++++++++++++++ drivers/cxl/core/port.c | 45 +++ drivers/cxl/cxl.h | 7 +drivers/cxl/cxlmem.h | 10 +drivers/cxl/cxlpci.h | 3 +drivers/cxl/mem.c | 1 +drivers/cxl/pci.c | 111 ++++++ drivers/pci/Kconfig | 3 +drivers/pci/Makefile | 1 +drivers/pci/doe.c | 633 ++++++++++++++++++++++++++++++++++ drivers/pci/probe.c | 2 +- include/linux/pci-doe.h | 120 +++++++ include/linux/pci_ids.h | 1 + include/uapi/linux/pci_regs.h | 29 +-
16 files changed, 1350 insertions(+), 2 deletions(-)
create mode 100644 drivers/cxl/cdat.h
create mode 100644 drivers/pci/doe.c
create mode 100644 include/linux/pci-doe.h
--
2.35.1
PATCH v9 1/9 PCI: Add vendor ID for the PCI SIG
From: Jonathan Cameron <[email protected]>
This ID is used in DOE headers to identify protocols that are defined within the PCI Express Base Specification, PCIe r6.0, sec 6.30.1.1 table 6-32.
--- include/linux/pci_ids.h | 1 + 1 file changed, 1 insertion(+)
include/linux/pci_ids.h +1 -0
@@ -151,6 +151,7 @@#define PCI_CLASS_OTHERS 0xff/* Vendors and devices. Sort key: vendor first, device next. */ +#define PCI_VENDOR_ID_PCI_SIG 0x0001#define PCI_VENDOR_ID_LOONGSON 0x0014
Signature · 1 line
2.35.1
Re: [PATCH v9 1/9] PCI: Add vendor ID for the PCI SIG
Quoted 9 lines · On Tue, 31 May 2022, [email protected] wrote:
From: Jonathan Cameron <[email protected]>
This ID is used in DOE headers to identify protocols that are defined within the PCI Express Base Specification, PCIe r6.0, sec 6.30.1.1 table 6-32.
Acked-by Bjorn Helgaas <[email protected]>Reviewed-by Dan Williams <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>
Quoted 20 lines
---
include/linux/pci_ids.h| 1 +1 file changed, 1 insertion(+)include/linux/pci_ids.h +1
-0@@ -151,6 +151,7 @@#define PCI_CLASS_OTHERS 0xff/* Vendors and devices. Sort key: vendor first, device next. */ +#define PCI_VENDOR_ID_PCI_SIG 0x0001#define PCI_VENDOR_ID_LOONGSON 0x0014Signature · 2 lines
-- 2.35.1
PATCH v9 2/9 PCI: Replace magic constant for PCI Sig Vendor ID
In reply to [email protected]From: Ira Weiny <[email protected]>
Replace the magic value in pci_bus_crs_vendor_id() with PCI_VENDOR_ID_PCI_SIG.
---
Changes from V6
Simplify commit message
--- drivers/pci/probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/probe.c +1 -1
@@ -2312,7 +2312,7 @@ EXPORT_SYMBOL(pci_alloc_dev);static bool pci_bus_crs_vendor_id (u32 l) { -return (l &0xffff ) ==0x0001 ; +return (l &0xffff ) ==PCI_VENDOR_ID_PCI_SIG ; } static bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 *l,
Signature · 1 line
2.35.1
Re: [PATCH v9 2/9] PCI: Replace magic constant for PCI Sig Vendor ID
Quoted 9 lines · On Tue, 31 May 2022, [email protected] wrote:
From: Ira Weiny <[email protected]>
Replace the magic value in
pci_bus_crs_vendor_id()withPCI_VENDOR_ID_PCI_SIG.Reviewed-by Dan Williams <[email protected]>Suggested-by Bjorn Helgaas <[email protected]>Acked-by Bjorn Helgaas <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 24 lines
---
Changes from V6
Simplify commit message
---drivers/pci/probe.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/probe.c +1
-1@@ -2312,7 +2312,7 @@ EXPORT_SYMBOL(pci_alloc_dev);static bool pci_bus_crs_vendor_id (u32 l) { -return (l &0xffff ) ==0x0001 ; +return (l &0xffff ) ==PCI_VENDOR_ID_PCI_SIG ; } static bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 *l,Signature · 2 lines
-- 2.35.1
PATCH v9 3/9 PCI: Create PCI library functions in support of DOE mailboxes.
In reply to [email protected]From: Jonathan Cameron <[email protected]>
Introduced in a PCI r6.0, sec 6.30, DOE provides a config space based mailbox with standard protocol discovery. Each mailbox is accessed through a DOE Extended Capability.
Each DOE mailbox must support the DOE discovery protocol in addition to any number of additional protocols.
Define core PCI functionality to manage a single PCI DOE mailbox at a defined config space offset. Functionality includes iterating, creating, query of supported protocol, task submission, and destruction of the mailboxes.
If interrupts are desired, the interrupt number can be queried and passed to the create function. Passing a negative value disables interrupts for that mailbox. It is the callers responsibility to ensure enough interrupt vectors are allocated.
---
Changes from V8
Remove Bjorn's ack
Expose a function to find the irq number for a mailbox based on offset. This is the code Jonathan proposed for finding the irq number here:
https://lore.kernel.org/linux-cxl/[email protected]/
This removes funky bool parameter to create.
Move pci_set_master() within the pci_doe_enable_irq() Per Bjorn
Clean up commit messages
move pci-doe.c to doe.c
Clean up PCI spec references
Ensure all messages use pci_*()
Add offset to error messages to distinguish mailboxes
use hex for DOE offsets
Print 4 nibbles for Vendor ID and 2 for type. s/irq/IRQ in comments
Fix long lines
Fix typos
Changes from V7
Add a Kconfig for this functionality
Fix bug in pci_doe_supports_prot()
Rebased on cxl-pending
Changes from V6
Clean up signed off by lines
Make this functionality all PCI library functions
Clean up header files
s/pci_doe_irq/pci_doe_irq_handler
Use pci_{request,free}_irq
Remove irq_name (maintained by pci_request_irq)
Fix checks to use an irq
Consistently use u16 for cap_offset
Cleanup kdocs and comments
Create a helper retire_cur_task() to handle locking of the
current task pointer.
Remove devm_ calls from PCI layer.
The devm_ calls do not allow for the pci_doe_mb objects to be tied to an auxiliary device. Leave it to the caller to use devm_ if desired.
From Dan Williams
s/cb/end_task/; Pass pci_doe_task to end_task Clarify exchange/task/request/response.
Merge pci_doe_task and pci_doe_exchange into pci_doe_task which represents a single request/response task for the state machine to process.
Simplify submitting work to the mailbox
Replace pci_doe_exchange_sync() with pci_doe_submit_task() Consumers of the mailbox are now responsible for setting up callbacks within a task object and submitting them to the mailbox to be processed.
Remove WARN_ON when task != NULL and be sure to abort that task. Convert abort/dead to atomic flags s/state_lock/task_lock to better define what the lock is
protecting
Remove all the auxiliary bus code from the PCI layer
The PCI layer provides helpers to use the DOE Mailboxes. Each subsystem can then use the helpers as they see fit. The CXL layer in this series uses aux devices to manage the new pci_doe_mb objects.
From Bjorn
Clarify the fact that DOE mailboxes are capabilities of
the device.
Code clean ups
Cleanup Makefile
Update references to PCI SIG spec v6.0
Move this attribution here:
This code is based on Jonathan's V4 series here:
https://lore.kernel.org/linux-cxl/[email protected]/
Changes from V5
From Bjorn
s/pci_WARN/pci_warn
Add timeout period to print
Trim to 80 chars
Use Tabs for DOE define spacing
Use %#x for clarity
From Jonathan
Addresses concerns about the order of unwinding stuff s/doe/doe_dev in pci_doe_exhcnage_sync
Correct kernel Doc comment
Move pci_doe_task_complete() down in the file. Rework pci_doe_irq()
process STATUS_ERROR first
Return IRQ_NONE if the irq is not processed Use PCI_DOE_STATUS_INT_STATUS explicitly to
clear the irq
Clean up goto label s/err_free_irqs/err_free_irq
use devm_kzalloc for doe struct
clean up error paths in pci_doe_probe s/pci_doe_drv/pci_doe
remove include mutex.h
remove device name and define, move it in the next patch which uses it use devm_kasprintf() for irq_name
use devm_request_irq()
remove pci_doe_unregister()
[get/put]_device() were unneeded and with the use of devm_* this function can be removed completely.
refactor pci_doe_register and s/pci_doe_register/pci_doe_reg_irq
make this function just a registration of the irq and move pci_doe_abort() into pci_doe_probe()
use devm_* to allocate the protocol array
Changes from Jonathan's V4
Move the DOE MB code into the DOE auxiliary driver Remove Task List in favor of a wait queue
Changes from Ben
remove CXL references
propagate rc from pci functions on error
--- drivers/pci/Kconfig | 3 + drivers/pci/Makefile | 1 + drivers/pci/doe.c | 633 ++++++++++++++++++++++++++++++++++ include/linux/pci-doe.h | 120 +++++++ include/uapi/linux/pci_regs.h | 29 +- 5 files changed, 785 insertions(+), 1 deletion(-) create mode 100644 drivers/pci/doe.c create mode 100644 include/linux/pci-doe.h
drivers/pci/Kconfig +3 -0
@@ -121,6 +121,9 @@ config XEN_PCIDEV_FRONTEND config PCI_ATS bool +config PCI_DOE + bool + config PCI_ECAM bool
drivers/pci/Makefile +1 -0
@@ -31,6 +31,7 @@ obj-$(CONFIG_PCI_ECAM) += ecam.o obj-$(CONFIG_PCI_P2PDMA) += p2pdma.o obj-$(CONFIG_XEN_PCIDEV_FRONTEND) += xen-pcifront.o obj-$(CONFIG_VGA_ARB) += vgaarb.o +obj-$(CONFIG_PCI_DOE) += doe.o # Endpoint library must be initialized before its users obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
drivers/pci/doe.c new file +633 -0
633 lines not on this page · raw message
include/linux/pci-doe.h new file +120 -0
120 lines not on this page · raw message
include/uapi/linux/pci_regs.h +28 -1
@@ -736,7 +736,8 @@#define PCI_EXT_CAP_ID_DVSEC 0x23/* Designated Vendor-Specific */ #define PCI_EXT_CAP_ID_DLF 0x25/* Data Link Feature */ #define PCI_EXT_CAP_ID_PL_16GT 0x26/* Physical Layer 16.0 GT/s */ -#define PCI_EXT_CAP_ID_MAX PCI_EXT_CAP_ID_PL_16GT +#define PCI_EXT_CAP_ID_DOE 0x2E/* Data Object Exchange */ +#define PCI_EXT_CAP_ID_MAX PCI_EXT_CAP_ID_DOE#define PCI_EXT_CAP_DSN_SIZEOF 12#define PCI_EXT_CAP_MCAST_ENDPOINT_SIZEOF 40
@@ -1102,4 +1103,30 @@#define PCI_PL_16GT_LE_CTRL_USP_TX_PRESET_MASK 0x000000F0#define PCI_PL_16GT_LE_CTRL_USP_TX_PRESET_SHIFT 4 +/* Data Object Exchange */ +#define PCI_DOE_CAP 0x04/* DOE Capabilities Register */ +#define PCI_DOE_CAP_INT 0x00000001/* Interrupt Support */ +#define PCI_DOE_CAP_IRQ 0x00000ffe/* Interrupt Message Number */ +#define PCI_DOE_CTRL 0x08/* DOE Control Register */ +#define PCI_DOE_CTRL_ABORT 0x00000001/* DOE Abort */ +#define PCI_DOE_CTRL_INT_EN 0x00000002/* DOE Interrupt Enable */ +#define PCI_DOE_CTRL_GO 0x80000000/* DOE Go */ +#define PCI_DOE_STATUS 0x0c/* DOE Status Register */ +#define PCI_DOE_STATUS_BUSY 0x00000001/* DOE Busy */ +#define PCI_DOE_STATUS_INT_STATUS 0x00000002/* DOE Interrupt Status */ +#define PCI_DOE_STATUS_ERROR 0x00000004/* DOE Error */ +#define PCI_DOE_STATUS_DATA_OBJECT_READY 0x80000000/* Data Object Ready */ +#define PCI_DOE_WRITE 0x10/* DOE Write Data Mailbox Register */ +#define PCI_DOE_READ 0x14/* DOE Read Data Mailbox Register */ + +/* DOE Data Object - note not actually registers */ +#define PCI_DOE_DATA_OBJECT_HEADER_1_VID 0x0000ffff +#define PCI_DOE_DATA_OBJECT_HEADER_1_TYPE 0x00ff0000 +#define PCI_DOE_DATA_OBJECT_HEADER_2_LENGTH 0x0003ffff + +#define PCI_DOE_DATA_OBJECT_DISC_REQ_3_INDEX 0x000000ff +#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_VID 0x0000ffff +#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_PROTOCOL 0x00ff0000 +#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_NEXT_INDEX 0xff000000 +#endif /* LINUX_PCI_REGS_H */
Signature · 1 line
2.35.1
Davidlohr Bueso
maintainerRe: [PATCH v9 3/9] PCI: Create PCI library functions in support of DOE mailboxes.
Quoted 4 lines · On Tue, 31 May 2022, [email protected] wrote:
drivers/pci/doe.c new file +4
-0+static void doe_statemachine_work (struct work_struct *work) +{ +struct delayed_work *w =to_delayed_work (work); + struct pci_doe_mb *doe_mb = container_of(w, struct pci_doe_mb,
drivers/pci/doe.c line 196
Quoted 10 lines
drivers/pci/doe.c new file +10
-0+ statemachine); +struct pci_dev *pdev = doe_mb->pdev; +int offset = doe_mb->cap_offset; +struct pci_doe_task *task; +u32 val; +int rc; + +mutex_lock (&doe_mb->task_lock); + task = doe_mb->cur_task; +mutex_unlock (&doe_mb->task_lock);
Instead of a mutex, would it be better to use a rwsem here to protect the state machine and allow for concurrent reads for the work callback? It is a general interface and a trivial change, but not sure how much performance is cared about.
Thanks,
Davidlohr
Davidlohr Bueso
maintainerRe: [PATCH v9 3/9] PCI: Create PCI library functions in support of DOE mailboxes.
Quoted 13 lines · Davidlohr Bueso
Quoted 11 lines · On Tue, 31 May 2022, [email protected] wrote:
drivers/pci/doe.c new file +11
-0+static void doe_statemachine_work (struct work_struct *work) +{ +struct delayed_work *w =to_delayed_work (work); + struct pci_doe_mb *doe_mb = container_of(w, struct pci_doe_mb, + statemachine); +struct pci_dev *pdev = doe_mb->pdev; +int offset = doe_mb->cap_offset; +struct pci_doe_task *task; +u32 val; +int rc; +
Quoted 8 lines
drivers/pci/doe.c line 196
Quoted 3 lines
drivers/pci/doe.c new file +3
-0+mutex_lock (&doe_mb->task_lock); + task = doe_mb->cur_task; +mutex_unlock (&doe_mb->task_lock);Instead of a mutex, would it be better to use a rwsem here to protect the state machine and allow for concurrent reads for the work callback? It is a general interface and a trivial change, but not sure how much performance is cared about.
Actually why is this a sleeping lock at all? Afaict all critical regions are short and just deal with loads and stores of oe_mb->task_lock (and pci_doe_submit_task also checks the doe_mb->flags with the lock held). This could be a spinlock or similarly a rwlock.
Thanks,
Davidlohr
Re: [PATCH v9 3/9] PCI: Create PCI library functions in support of DOE mailboxes.
Quoted 24 lines · Davidlohr Bueso
Quoted 13 lines · Davidlohr Bueso
Quoted 11 lines · On Tue, 31 May 2022, [email protected] wrote:
drivers/pci/doe.c new file +11
-0+static void doe_statemachine_work (struct work_struct *work) +{ +struct delayed_work *w =to_delayed_work (work); + struct pci_doe_mb *doe_mb = container_of(w, struct pci_doe_mb, + statemachine); +struct pci_dev *pdev = doe_mb->pdev; +int offset = doe_mb->cap_offset; +struct pci_doe_task *task; +u32 val; +int rc; +Quoted 8 lines
drivers/pci/doe.c line 196
Quoted 3 lines
drivers/pci/doe.c new file +3
-0+mutex_lock (&doe_mb->task_lock); + task = doe_mb->cur_task; +mutex_unlock (&doe_mb->task_lock);Instead of a mutex, would it be better to use a rwsem here to protect the state machine and allow for concurrent reads for the work callback? It is a general interface and a trivial change, but not sure how much performance is cared about.
Quoted 4 lines
Actually why is this a sleeping lock at all? Afaict all critical regions are short and just deal with loads and stores of
oe_mb->task_lock(andpci_doe_submit_taskalso checks thedoe_mb->flagswith the lock held). This could be a spinlock or similarly a rwlock.
This is a good point... My only excuse is that task_lock used to lock more than just the cur_task so I suspect that I just kept it as a mutex after a rework at some point with out thinking about this deeper.
Thinking about it I don't see a benefit to a rwlock. We don't have multiple readers.
But I've just looked at this code again and I'm not sure that the exclusion is correct with regard to the state machine. I think the state needs to be IDLE before retire_cur_task() is called or the state machine could be in an invalid state when the next task runs. I think there is a bug in the DOE_WAIT_ABORT* cases when not error and not busy. In that case there is a race with the next task getting run the state being DOE_WAIT_ABORT*. In the timeout case we will call the mailbox dead.
I can't remember if Jonathan originally locked the state machine or the task or both.
I think I have fixed it but, I'll look at it again in the morning.
Thanks,
Ira
Quoted 3 lines
Thanks,
Davidlohr
Davidlohr Bueso
maintainerRe: [PATCH v9 3/9] PCI: Create PCI library functions in support of DOE mailboxes.
Quoted 2 lines · Ira Weiny
Thinking about it I don't see a benefit to a rwlock. We don't have multiple readers.
... but you have concurrent workqueues reading the value of cur_task.
Thanks,
Davidlohr
Re: [PATCH v9 3/9] PCI: Create PCI library functions in support of DOE mailboxes.
Quoted 5 lines · Davidlohr Bueso
Quoted 2 lines · Ira Weiny
Thinking about it I don't see a benefit to a rwlock. We don't have multiple readers.
... but you have concurrent workqueues reading the value of
cur_task.
No, concurrent workqueues are reading the value of different DOE mailboxes' cur_task. Each mailbox has it's own lock for its current task.
This is a multiple writers to a single reader pattern. The lock serializes driver requests (possibly from different threads) into the single mailbox as well as signaling when the cur_task is done; retire_cur_task().
At the same time multiple mailboxes can be running parallel.
I don't think taking the lock in doe_statemachine_work() is technically
necessary. But I left it there for completeness because if the queue depth is
increased like it was in Jonathans original code the locking around cur_task will need to be adjusted in this area.
Ira
Quoted 3 lines
Thanks,
Davidlohr
PATCH v9 4/9 cxl/pci: Create PCI DOE mailbox's for memory devices
In reply to [email protected]From: Ira Weiny <[email protected]>
DOE mailbox objects will be needed for various mailbox communications with each memory device.
Iterate each DOE mailbox capability and create PCI DOE mailbox objects as found.
It is not anticipated that this is the final resting place for the iteration of the DOE devices. The support of ports may drive this code into the pcie side. In this imagined architecture the CXL port driver would then query into the PCI device for the DOE mailbox array.
For now this is good enough for the endpoints and the split is similar to the envisioned architecture where getting the mailbox array is separated from the various protocol needs. For example, it is not anticipated that the CDAT code will need to move because it is only needed by the cxl_ports.
Likewise irq's are separated out in a similar design pattern to the PCIe port driver. But a much simpler irq enabling flag is used and only DOE interrupts are supported.
---
Changes from V8:
Move PCI_DOE selection to CXL_BUS to support future patches which move queries into the port code.
Remove Auxiliary device arch
Squash the functionality of the auxiliary driver into this patch.
Split out the irq handling a bit.
Changes from V7:
Minor code clean ups
Rebased on cxl-pending
Changes from V6:
Move all the auxiliary device stuff to the CXL layer
Changes from V5:
Split the CXL specific stuff off from the PCI DOE create auxiliary device code.
--- drivers/cxl/Kconfig | 1 + drivers/cxl/cxlmem.h | 6 +++ drivers/cxl/pci.c | 111 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)
drivers/cxl/Kconfig +1 -0
@@ -2,6 +2,7 @@ menuconfig CXL_BUS tristate "CXL (Compute Express Link) Devices Support" depends on PCI + select PCI_DOE help CXL is a bus that is electrically compatible with PCI Express, but layers three protocols on that signalling (CXL.io, CXL.cache, and
drivers/cxl/cxlmem.h +6 -0
@@ -191,6 +191,8 @@ struct cxl_endpoint_dvsec_info {* @component_reg_phys: register base of component registers * @info: Cached DVSEC information about the device. * @serial: PCIe Device Serial Number +* @doe_mbs: PCI DOE mailbox array +* @num_mbs: Number of DOE mailboxes * @mbox_send: @dev specific transport for transmitting mailbox commands * * See section 8.2.9.5.2 Capacity Configuration and Label Storage for
@@ -224,6 +226,10 @@ struct cxl_dev_state {resource_size_t component_reg_phys;u64 serial; +bool doe_use_irq; +struct pci_doe_mb **doe_mbs; +int num_mbs; +int (*mbox_send)(struct cxl_dev_state *cxlds,struct cxl_mbox_cmd *cmd); };
drivers/cxl/pci.c +111 -0
129 lines not on this page · raw message
Signature · 1 line
2.35.1
Re: [PATCH V9 4/9] cxl/pci: Create PCI DOE mailbox's for memory devices
Quoted 5 lines · On 22-05-31 08:26:27, [email protected] wrote:
From: Ira Weiny <[email protected]>
DOE mailbox objects will be needed for various mailbox communications with each memory device.
Quoted 7 lines
Iterate each DOE mailbox capability and create PCI DOE mailbox objects as found.
It is not anticipated that this is the final resting place for the iteration of the DOE devices. The support of ports may drive this code into the pcie side. In this imagined architecture the CXL port driver would then query into the PCI device for the DOE mailbox array.
Not sure if direction has changed, but initially it would have been the cxl_pci driver who would query this and pass it along when the port driver probes. Personally, I've never had an issue with non cxl_pci drivers using PCI interfaces and semantics, but it is something we've taken specific care to avoid.
Quoted 111 lines
For now this is good enough for the endpoints and the split is similar to the envisioned architecture where getting the mailbox array is separated from the various protocol needs. For example, it is not anticipated that the CDAT code will need to move because it is only needed by the
cxl_ports.Likewise irq's are separated out in a similar design pattern to the PCIe port driver. But a much simpler irq enabling flag is used and only DOE interrupts are supported.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8:
MovePCI_DOEselection toCXL_BUSto support future patches which move queries into the port code.
Remove Auxiliary device arch
Squash the functionality of the auxiliary driver into this patch.
Split out the irq handling a bit.Changes from V7:
Minor code clean ups
Rebased on cxl-pendingChanges from V6:
Move all the auxiliary device stuff to the CXL layerChanges from V5:
Split the CXL specific stuff off from the PCI DOE create auxiliary device code.--- drivers/cxl/Kconfig | 1 + drivers/cxl/cxlmem.h | 6 +++ drivers/cxl/pci.c | 111 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)drivers/cxl/Kconfig +1
-0@@ -2,6 +2,7 @@ menuconfig CXL_BUS tristate "CXL (Compute Express Link) Devices Support" depends on PCI + select PCI_DOE help CXL is a bus that is electrically compatible with PCI Express, but layers three protocols on that signalling (CXL.io, CXL.cache, anddrivers/cxl/cxlmem.h +6
-0@@ -191,6 +191,8 @@ struct cxl_endpoint_dvsec_info {* @component_reg_phys: register base of component registers * @info: Cached DVSEC information about the device. * @serial: PCIe Device Serial Number +* @doe_mbs: PCI DOE mailbox array +* @num_mbs: Number of DOE mailboxes * @mbox_send: @dev specific transport for transmitting mailbox commands * * See section 8.2.9.5.2 Capacity Configuration and Label Storage for @@ -224,6 +226,10 @@ struct cxl_dev_state {resource_size_t component_reg_phys;u64 serial; +bool doe_use_irq; +struct pci_doe_mb **doe_mbs; +int num_mbs; +int (*mbox_send)(struct cxl_dev_state *cxlds,struct cxl_mbox_cmd *cmd); };drivers/cxl/pci.c +22
-0@@ -8,6 +8,7 @@#include <linux/mutex.h> #include <linux/list.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <linux/io.h> #include "cxlmem.h" #include "cxlpci.h" @@ -386,6 +387,113 @@ static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type,return rc; } +static void cxl_pci_free_irq_vectors (void *data) +{ +pci_free_irq_vectors (data); +} + +static void cxl_doe_destroy_mb (void *ds) +{ +struct cxl_dev_state *cxlds = ds; +int i; + +for (i =0 ; i < cxlds->num_mbs; i++) { +if (cxlds->doe_mbs[i]) +pci_doe_destroy_mb (cxlds->doe_mbs[i]); + } +} + +static void cxl_alloc_irq_vectors (struct cxl_dev_state *cxlds) +{ +struct device *dev = cxlds->dev; +struct pci_dev *pdev =to_pci_dev (dev); +int num_irqs =0 ;
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 420
Quoted 10 lines
drivers/cxl/pci.c +10
-0+int off =0 ; +int rc; + +/* Account for all the DOE vectors needed */ +pci_doe_for_each_off (pdev, off) { +int irq =pci_doe_get_irq_num (pdev, off); + +if (irq <0 ) +continue ; + num_irqs =max (num_irqs, irq +1 );
This seems overly complicated. Isn't it just num_irqs++?
Quoted 13 lines
drivers/cxl/pci.c +13
-0+ } + +/* +* Allocate enough vectors for the DOE's +*/ + rc =pci_alloc_irq_vectors (pdev, num_irqs, num_irqs,PCI_IRQ_MSI | +PCI_IRQ_MSIX ); +if (rc != num_irqs) { +pci_err (pdev,"Not enough interrupts; use polling\n" ); +/* Some got allocated; clean them up */ +if (rc >0 ) +cxl_pci_free_irq_vectors (pdev); + cxlds->doe_use_irq = false;
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 443
Quoted 10 lines
drivers/cxl/pci.c +10
-0+return ; + } + + rc =devm_add_action_or_reset (dev, cxl_pci_free_irq_vectors, pdev); +if (rc) { + cxlds->doe_use_irq = false; +return ; + } + + cxlds->doe_use_irq = true;
If you named it doe_poll, you could avoid having to do anything at the end of the function... If you felt like it.
if (failure)
return; if (other_failure) return;
cxld->do_use_poll = false;
Quoted 10 lines
drivers/cxl/pci.c +10
-0+} + +/** +* devm_cxl_pci_create_doe - Scan and set up DOE mailboxes +* +* @cxlds: The CXL device state +* +* RETURNS: 0 on success -ERRNO on failure. +*/ +static int devm_cxl_pci_create_doe (struct cxl_dev_state *cxlds)
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 463
Quoted 10 lines
drivers/cxl/pci.c +10
-0+{ +struct device *dev = cxlds->dev; +struct pci_dev *pdev =to_pci_dev (dev); +u16 off =0 ; +int num_mbs =0 ; +int rc; + +pci_doe_for_each_off (pdev, off) + num_mbs++; +
Do you want to bail here if num_mbs == 0?
Quoted 37 lines
drivers/cxl/pci.c +33
-0+ cxlds->doe_mbs =devm_kcalloc (dev, num_mbs,sizeof (*cxlds->doe_mbs), +GFP_KERNEL ); +if (!cxlds->doe_mbs) +return -ENOMEM ; + +pci_doe_for_each_off (pdev, off) { +struct pci_doe_mb *doe_mb; +int irq =-1 ; + +if (cxlds->doe_use_irq) + irq =pci_doe_get_irq_num (pdev, off); + + doe_mb =pci_doe_create_mb (pdev, off, irq); +if (IS_ERR (doe_mb)) { +pci_err (pdev, +"Failed to create MB object for MB @ %x\n" , + off); + doe_mb =NULL ; + } + + cxlds->doe_mbs[cxlds->num_mbs] = doe_mb; + cxlds->num_mbs++; + } + + rc =devm_add_action_or_reset (dev, cxl_doe_destroy_mb, cxlds); +if (rc) +return rc; + +pci_info (pdev,"Configured %d DOE mailbox's\n" , cxlds->num_mbs); + +return 0 ; +} +static int cxl_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {struct cxl_register_map map;
drivers/cxl/pci.c static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) · line 566
Quoted 5 lines
drivers/cxl/pci.c +2
-0@@ -454,6 +562,9 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (IS_ERR (cxlmd))return PTR_ERR (cxlmd); +cxl_alloc_irq_vectors (cxlds); +devm_cxl_pci_create_doe (cxlds);
If you're not going to check the return value, just make the functions void.
Quoted 7 lines
drivers/cxl/pci.c +1
-0+if (range_len (&cxlds->pmem_range) &&IS_ENABLED (CONFIG_CXL_PMEM )) rc =devm_cxl_add_nvdimm (&pdev->dev, cxlmd);Signature · 1 line
2.35.1
Re: [PATCH V9 4/9] cxl/pci: Create PCI DOE mailbox's for memory devices
Quoted 135 lines · On Tue, 31 May 2022 10:50:20 -0700 Ben Widawsky <[email protected]> wrote:
Quoted 5 lines · On 22-05-31 08:26:27, [email protected] wrote:
From: Ira Weiny <[email protected]>
DOE mailbox objects will be needed for various mailbox communications with each memory device.
Quoted 7 lines
Iterate each DOE mailbox capability and create PCI DOE mailbox objects as found.
It is not anticipated that this is the final resting place for the iteration of the DOE devices. The support of ports may drive this code into the pcie side. In this imagined architecture the CXL port driver would then query into the PCI device for the DOE mailbox array.
Not sure if direction has changed, but initially it would have been the
cxl_pcidriver who would query this and pass it along when the port driver probes. Personally, I've never had an issue with noncxl_pcidrivers using PCI interfaces and semantics, but it is something we've taken specific care to avoid.Quoted 115 lines
For now this is good enough for the endpoints and the split is similar to the envisioned architecture where getting the mailbox array is separated from the various protocol needs. For example, it is not anticipated that the CDAT code will need to move because it is only needed by the
cxl_ports.Likewise irq's are separated out in a similar design pattern to the PCIe port driver. But a much simpler irq enabling flag is used and only DOE interrupts are supported.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8:
MovePCI_DOEselection toCXL_BUSto support future patches which move queries into the port code.
Remove Auxiliary device arch
Squash the functionality of the auxiliary driver into this patch.
Split out the irq handling a bit.Changes from V7:
Minor code clean ups
Rebased on cxl-pendingChanges from V6:
Move all the auxiliary device stuff to the CXL layerChanges from V5:
Split the CXL specific stuff off from the PCI DOE create auxiliary device code.--- drivers/cxl/Kconfig | 1 + drivers/cxl/cxlmem.h | 6 +++ drivers/cxl/pci.c | 111 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)drivers/cxl/Kconfig +1
-0@@ -2,6 +2,7 @@ menuconfig CXL_BUS tristate "CXL (Compute Express Link) Devices Support" depends on PCI + select PCI_DOE help CXL is a bus that is electrically compatible with PCI Express, but layers three protocols on that signalling (CXL.io, CXL.cache, anddrivers/cxl/cxlmem.h +6
-0@@ -191,6 +191,8 @@ struct cxl_endpoint_dvsec_info {* @component_reg_phys: register base of component registers * @info: Cached DVSEC information about the device. * @serial: PCIe Device Serial Number +* @doe_mbs: PCI DOE mailbox array +* @num_mbs: Number of DOE mailboxes * @mbox_send: @dev specific transport for transmitting mailbox commands * * See section 8.2.9.5.2 Capacity Configuration and Label Storage for @@ -224,6 +226,10 @@ struct cxl_dev_state {resource_size_t component_reg_phys;u64 serial; +bool doe_use_irq; +struct pci_doe_mb **doe_mbs; +int num_mbs; +int (*mbox_send)(struct cxl_dev_state *cxlds,struct cxl_mbox_cmd *cmd); };drivers/cxl/pci.c +26
-0@@ -8,6 +8,7 @@#include <linux/mutex.h> #include <linux/list.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <linux/io.h> #include "cxlmem.h" #include "cxlpci.h" @@ -386,6 +387,113 @@ static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type,return rc; } +static void cxl_pci_free_irq_vectors (void *data) +{ +pci_free_irq_vectors (data); +} + +static void cxl_doe_destroy_mb (void *ds) +{ +struct cxl_dev_state *cxlds = ds; +int i; + +for (i =0 ; i < cxlds->num_mbs; i++) { +if (cxlds->doe_mbs[i]) +pci_doe_destroy_mb (cxlds->doe_mbs[i]); + } +} + +static void cxl_alloc_irq_vectors (struct cxl_dev_state *cxlds) +{ +struct device *dev = cxlds->dev; +struct pci_dev *pdev =to_pci_dev (dev); +int num_irqs =0 ; +int off =0 ; +int rc; + +/* Account for all the DOE vectors needed */
Quoted 8 lines
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 420
Quoted 6 lines
drivers/cxl/pci.c +6
-0+pci_doe_for_each_off (pdev, off) { +int irq =pci_doe_get_irq_num (pdev, off); + +if (irq <0 ) +continue ; + num_irqs =max (num_irqs, irq +1 );This seems overly complicated. Isn't it just num_irqs++?
nope.
There is no guarantee the irq values are near zero or contiguous.
If irq is 33 for example, it pretty much implies that there are 34 or more irq vectors used for something on this device, but we don't know what the rest are for.
Trick is used in portdrv to deal with enabling all the irqs needed for the various supported services, which might not be all the irqs the hardware provides.
Maybe worth renaming num_irqs as max_irq or something like that and postpone the +1 to where it is used?
Jonathan
Quoted 2 lines
Quoted 2 lines
drivers/cxl/pci.c +1
-0+ }
Re: [PATCH V9 4/9] cxl/pci: Create PCI DOE mailbox's for memory devices
In reply to Ben WidawskyQuoted 14 lines · Ben Widawsky
Quoted 5 lines · On 22-05-31 08:26:27, [email protected] wrote:
From: Ira Weiny <[email protected]>
DOE mailbox objects will be needed for various mailbox communications with each memory device.
Quoted 7 lines
Iterate each DOE mailbox capability and create PCI DOE mailbox objects as found.
It is not anticipated that this is the final resting place for the iteration of the DOE devices. The support of ports may drive this code into the pcie side. In this imagined architecture the CXL port driver would then query into the PCI device for the DOE mailbox array.
Quoted 5 lines
Not sure if direction has changed, but initially it would have been the
cxl_pcidriver who would query this and pass it along when the port driver probes. Personally, I've never had an issue with noncxl_pcidrivers using PCI interfaces and semantics, but it is something we've taken specific care to avoid.
I really struggled with this and this is why the comment above was added. I agree with you but I think this actually belongs somewhere in the PCI code eventually and the cxl_port should be grabbing the CDAT mailbox from there.
I really think that having the PCIe port driver iterate the DOE mailboxes and then having either CXL or PCIe find the mailboxes they are interested in is the way to go.
But this supports mailbox end points for now.
Quoted 116 lines
Quoted 116 lines
For now this is good enough for the endpoints and the split is similar to the envisioned architecture where getting the mailbox array is separated from the various protocol needs. For example, it is not anticipated that the CDAT code will need to move because it is only needed by the
cxl_ports.Likewise irq's are separated out in a similar design pattern to the PCIe port driver. But a much simpler irq enabling flag is used and only DOE interrupts are supported.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8:
MovePCI_DOEselection toCXL_BUSto support future patches which move queries into the port code.
Remove Auxiliary device arch
Squash the functionality of the auxiliary driver into this patch.
Split out the irq handling a bit.Changes from V7:
Minor code clean ups
Rebased on cxl-pendingChanges from V6:
Move all the auxiliary device stuff to the CXL layerChanges from V5:
Split the CXL specific stuff off from the PCI DOE create auxiliary device code.--- drivers/cxl/Kconfig | 1 + drivers/cxl/cxlmem.h | 6 +++ drivers/cxl/pci.c | 111 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+)drivers/cxl/Kconfig +1
-0@@ -2,6 +2,7 @@ menuconfig CXL_BUS tristate "CXL (Compute Express Link) Devices Support" depends on PCI + select PCI_DOE help CXL is a bus that is electrically compatible with PCI Express, but layers three protocols on that signalling (CXL.io, CXL.cache, anddrivers/cxl/cxlmem.h +6
-0@@ -191,6 +191,8 @@ struct cxl_endpoint_dvsec_info {* @component_reg_phys: register base of component registers * @info: Cached DVSEC information about the device. * @serial: PCIe Device Serial Number +* @doe_mbs: PCI DOE mailbox array +* @num_mbs: Number of DOE mailboxes * @mbox_send: @dev specific transport for transmitting mailbox commands * * See section 8.2.9.5.2 Capacity Configuration and Label Storage for @@ -224,6 +226,10 @@ struct cxl_dev_state {resource_size_t component_reg_phys;u64 serial; +bool doe_use_irq; +struct pci_doe_mb **doe_mbs; +int num_mbs; +int (*mbox_send)(struct cxl_dev_state *cxlds,struct cxl_mbox_cmd *cmd); };drivers/cxl/pci.c +26
-0@@ -8,6 +8,7 @@#include <linux/mutex.h> #include <linux/list.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <linux/io.h> #include "cxlmem.h" #include "cxlpci.h" @@ -386,6 +387,113 @@ static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type,return rc; } +static void cxl_pci_free_irq_vectors (void *data) +{ +pci_free_irq_vectors (data); +} + +static void cxl_doe_destroy_mb (void *ds) +{ +struct cxl_dev_state *cxlds = ds; +int i; + +for (i =0 ; i < cxlds->num_mbs; i++) { +if (cxlds->doe_mbs[i]) +pci_doe_destroy_mb (cxlds->doe_mbs[i]); + } +} + +static void cxl_alloc_irq_vectors (struct cxl_dev_state *cxlds) +{ +struct device *dev = cxlds->dev; +struct pci_dev *pdev =to_pci_dev (dev); +int num_irqs =0 ; +int off =0 ; +int rc; + +/* Account for all the DOE vectors needed */
Quoted 8 lines
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 420
Quoted 6 lines
drivers/cxl/pci.c +6
-0+pci_doe_for_each_off (pdev, off) { +int irq =pci_doe_get_irq_num (pdev, off); + +if (irq <0 ) +continue ; + num_irqs =max (num_irqs, irq +1 );This seems overly complicated. Isn't it just num_irqs++?
See Jonathan's comment. But I'll change it to 'max_irqs'.
Quoted 28 lines
Quoted 14 lines
drivers/cxl/pci.c +13
-0+ } + +/* +* Allocate enough vectors for the DOE's +*/ + rc =pci_alloc_irq_vectors (pdev, num_irqs, num_irqs,PCI_IRQ_MSI | +PCI_IRQ_MSIX ); +if (rc != num_irqs) { +pci_err (pdev,"Not enough interrupts; use polling\n" ); +/* Some got allocated; clean them up */ +if (rc >0 ) +cxl_pci_free_irq_vectors (pdev); + cxlds->doe_use_irq = false;drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 443
Quoted 10 lines
drivers/cxl/pci.c +10
-0+return ; + } + + rc =devm_add_action_or_reset (dev, cxl_pci_free_irq_vectors, pdev); +if (rc) { + cxlds->doe_use_irq = false; +return ; + } + + cxlds->doe_use_irq = true;If you named it
doe_poll, you could avoid having to do anything at the end of the function... If you felt like it.
Quoted 6 lines
if (failure)
return; if (other_failure) return;
cxld->do_use_poll= false;
Actually I could just set false at the top and return on error.
Thanks for the suggestion.
Quoted 15 lines
Quoted 15 lines
drivers/cxl/pci.c +14
-0+} + +/** +* devm_cxl_pci_create_doe - Scan and set up DOE mailboxes +* +* @cxlds: The CXL device state +* +* RETURNS: 0 on success -ERRNO on failure. +*/ +static int devm_cxl_pci_create_doe (struct cxl_dev_state *cxlds) +{ +struct device *dev = cxlds->dev; +struct pci_dev *pdev =to_pci_dev (dev); +u16 off =0 ;
Quoted 8 lines
drivers/cxl/pci.c static int cxl_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type, · line 463
Quoted 6 lines
drivers/cxl/pci.c +6
-0+int num_mbs =0 ; +int rc; + +pci_doe_for_each_off (pdev, off) + num_mbs++; +Do you want to bail here if
num_mbs== 0?
I do! Thanks. I need to skip using irq's above if none are found too.
Quoted 41 lines
Quoted 41 lines
drivers/cxl/pci.c +33
-0+ cxlds->doe_mbs =devm_kcalloc (dev, num_mbs,sizeof (*cxlds->doe_mbs), +GFP_KERNEL ); +if (!cxlds->doe_mbs) +return -ENOMEM ; + +pci_doe_for_each_off (pdev, off) { +struct pci_doe_mb *doe_mb; +int irq =-1 ; + +if (cxlds->doe_use_irq) + irq =pci_doe_get_irq_num (pdev, off); + + doe_mb =pci_doe_create_mb (pdev, off, irq); +if (IS_ERR (doe_mb)) { +pci_err (pdev, +"Failed to create MB object for MB @ %x\n" , + off); + doe_mb =NULL ; + } + + cxlds->doe_mbs[cxlds->num_mbs] = doe_mb; + cxlds->num_mbs++; + } + + rc =devm_add_action_or_reset (dev, cxl_doe_destroy_mb, cxlds); +if (rc) +return rc; + +pci_info (pdev,"Configured %d DOE mailbox's\n" , cxlds->num_mbs); + +return 0 ; +} +static int cxl_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {struct cxl_register_map map;@@ -454,6 +562,9 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (IS_ERR (cxlmd))return PTR_ERR (cxlmd);
Quoted 4 lines
drivers/cxl/pci.c static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) · line 566
Quoted 2 lines
drivers/cxl/pci.c +2
-0+cxl_alloc_irq_vectors (cxlds); +devm_cxl_pci_create_doe (cxlds);If you're not going to check the return value, just make the functions void.
Yea too much rework and I forgot this.
Thanks,
Ira
Quoted 8 lines
Quoted 8 lines
drivers/cxl/pci.c +1
-0+if (range_len (&cxlds->pmem_range) &&IS_ENABLED (CONFIG_CXL_PMEM )) rc =devm_cxl_add_nvdimm (&pdev->dev, cxlmd);Signature · 1 line
2.35.1
PATCH v9 5/9 cxl/port: Find a DOE mailbox which supports CDAT
In reply to [email protected]From: Ira Weiny <[email protected]>
Each CXL device may have multiple DOE mailbox capabilities and each mailbox may support multiple protocols. CXL port devices need to query the CDAT information specifically.
Search the DOE mailboxes for one which supports the CDAT protocol. Cache that mailbox to be used for future queries.
Only support memory devices at this time.
---
Changes from V8
Incorporate feedback from Jonathan
Move all this to the cxl_port object
Changes from V7
Minor code clean ups
Changes from V6
Adjust for aux devices being a CXL only concept Update commit msg.
Ensure devices iterated by auxiliary_find_device() are checked
to be DOE devices prior to checking for the CDAT protocol
From Ben
Ensure reference from auxiliary_find_device() is dropped
--- drivers/cxl/core/pci.c | 28 ++++++++++++++++++++++++++++ drivers/cxl/core/port.c | 2 ++ drivers/cxl/cxl.h | 2 ++ drivers/cxl/cxlpci.h | 1 + 4 files changed, 33 insertions(+)
drivers/cxl/core/pci.c +28 -0
@@ -4,11 +4,14 @@#include <linux/device.h> #include <linux/delay.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <cxlpci.h> #include <cxlmem.h> #include <cxl.h> #include "core.h" +#define CXL_DOE_PROTOCOL_TABLE_ACCESS 2 +/** * DOC: cxl core pci *
@@ -458,3 +461,28 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm)return 0 ; }EXPORT_SYMBOL_NS_GPL (cxl_hdm_decode_init,CXL ); + +void cxl_find_cdat_mb (struct cxl_port *port) +{ +struct device *dev = port->uport; +struct cxl_memdev *cxlmd; +struct cxl_dev_state *cxlds; +int i; + +if (!is_cxl_memdev (dev)) +return ; + + cxlmd =to_cxl_memdev (dev); + cxlds = cxlmd->cxlds; + +for (i =0 ; i < cxlds->num_mbs; i++) { +struct pci_doe_mb *cur = cxlds->doe_mbs[i]; + +if (pci_doe_supports_prot (cur,PCI_DVSEC_VENDOR_ID_CXL , +CXL_DOE_PROTOCOL_TABLE_ACCESS )) { + port->cdat_mb = cur; +return ; + } + } +} +EXPORT_SYMBOL_NS_GPL (cxl_find_cdat_mb,CXL );
drivers/cxl/core/port.c +2 -0
@@ -461,6 +461,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,if (IS_ERR (port))return port; +cxl_find_cdat_mb (port); + dev = &port->dev;if (is_cxl_memdev (uport)) rc =dev_set_name (dev,"endpoint%d" , port->id);
drivers/cxl/cxl.h +2 -0
@@ -267,6 +267,7 @@ struct cxl_nvdimm {* @component_reg_phys: component register capability base address (optional) * @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. +* @cdat_mb: Mailbox which supports the CDAT protocol */ struct cxl_port {struct device dev;
@@ -278,6 +279,7 @@ struct cxl_port {resource_size_t component_reg_phys;bool dead;unsigned int depth; +struct pci_doe_mb *cdat_mb; };/**
drivers/cxl/cxlpci.h +1 -0
@@ -74,4 +74,5 @@ static inline resource_size_t cxl_regmap_to_base(struct pci_dev *pdev,int devm_cxl_port_enumerate_dports (struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm); +void cxl_find_cdat_mb (struct cxl_port *port);#endif /* __CXL_PCI_H__ */
Signature · 1 line
2.35.1
Re: [PATCH V9 5/9] cxl/port: Find a DOE mailbox which supports CDAT
Quoted 56 lines · On 22-05-31 08:26:28, [email protected] wrote:
From: Ira Weiny <[email protected]>
Each CXL device may have multiple DOE mailbox capabilities and each mailbox may support multiple protocols. CXL port devices need to query the CDAT information specifically.
Search the DOE mailboxes for one which supports the CDAT protocol. Cache that mailbox to be used for future queries.
Only support memory devices at this time.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8
Incorporate feedback from Jonathan
Move all this to thecxl_portobjectChanges from V7
Minor code clean upsChanges from V6
Adjust for aux devices being a CXL only concept Update commit msg.
Ensure devices iterated byauxiliary_find_device()are checked
to be DOE devices prior to checking for the CDAT protocol
From Ben
Ensure reference fromauxiliary_find_device()is dropped--- drivers/cxl/core/pci.c | 28 ++++++++++++++++++++++++++++ drivers/cxl/core/port.c | 2 ++ drivers/cxl/cxl.h | 2 ++ drivers/cxl/cxlpci.h | 1 + 4 files changed, 33 insertions(+)drivers/cxl/core/pci.c +3
-0@@ -4,11 +4,14 @@#include <linux/device.h> #include <linux/delay.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <cxlpci.h> #include <cxlmem.h> #include <cxl.h> #include "core.h" +#define CXL_DOE_PROTOCOL_TABLE_ACCESS 2 +/** * DOC: cxl core pci *
drivers/cxl/core/pci.c int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm) · line 465
Quoted 5 lines
drivers/cxl/core/pci.c +2
-0@@ -458,3 +461,28 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm)return 0 ; }EXPORT_SYMBOL_NS_GPL (cxl_hdm_decode_init,CXL ); + +void cxl_find_cdat_mb (struct cxl_port *port)
kdoc would be good for exported symbols IMO. Also if you can come up with a better verb than "find" for something that mutates the port's state, I think that would be beneficial.
I'm not sure why this is exported yet, but I suppose I'll see soon :-)
Quoted 69 lines
drivers/cxl/core/pci.c +23
-0+{ +struct device *dev = port->uport; +struct cxl_memdev *cxlmd; +struct cxl_dev_state *cxlds; +int i; + +if (!is_cxl_memdev (dev)) +return ; + + cxlmd =to_cxl_memdev (dev); + cxlds = cxlmd->cxlds; + +for (i =0 ; i < cxlds->num_mbs; i++) { +struct pci_doe_mb *cur = cxlds->doe_mbs[i]; + +if (pci_doe_supports_prot (cur,PCI_DVSEC_VENDOR_ID_CXL , +CXL_DOE_PROTOCOL_TABLE_ACCESS )) { + port->cdat_mb = cur; +return ; + } + } +} +EXPORT_SYMBOL_NS_GPL (cxl_find_cdat_mb,CXL );drivers/cxl/core/port.c +2
-0@@ -461,6 +461,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,if (IS_ERR (port))return port; +cxl_find_cdat_mb (port); + dev = &port->dev;if (is_cxl_memdev (uport)) rc =dev_set_name (dev,"endpoint%d" , port->id);drivers/cxl/cxl.h +2
-0@@ -267,6 +267,7 @@ struct cxl_nvdimm {* @component_reg_phys: component register capability base address (optional) * @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. +* @cdat_mb: Mailbox which supports the CDAT protocol */ struct cxl_port {struct device dev;@@ -278,6 +279,7 @@ struct cxl_port {resource_size_t component_reg_phys;bool dead;unsigned int depth; +struct pci_doe_mb *cdat_mb; };/** drivers/cxl/cxlpci.h +1
-0@@ -74,4 +74,5 @@ static inline resource_size_t cxl_regmap_to_base(struct pci_dev *pdev,int devm_cxl_port_enumerate_dports (struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm); +void cxl_find_cdat_mb (struct cxl_port *port);#endif /* __CXL_PCI_H__ */ Signature · 1 line
2.35.1
Re: [PATCH V9 5/9] cxl/port: Find a DOE mailbox which supports CDAT
Quoted 51 lines · Ben Widawsky
Quoted 50 lines · On 22-05-31 08:26:28, [email protected] wrote:
From: Ira Weiny <[email protected]>
Each CXL device may have multiple DOE mailbox capabilities and each mailbox may support multiple protocols. CXL port devices need to query the CDAT information specifically.
Search the DOE mailboxes for one which supports the CDAT protocol. Cache that mailbox to be used for future queries.
Only support memory devices at this time.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8
Incorporate feedback from Jonathan
Move all this to thecxl_portobjectChanges from V7
Minor code clean upsChanges from V6
Adjust for aux devices being a CXL only concept Update commit msg.
Ensure devices iterated byauxiliary_find_device()are checked
to be DOE devices prior to checking for the CDAT protocol
From Ben
Ensure reference fromauxiliary_find_device()is dropped--- drivers/cxl/core/pci.c | 28 ++++++++++++++++++++++++++++ drivers/cxl/core/port.c | 2 ++ drivers/cxl/cxl.h | 2 ++ drivers/cxl/cxlpci.h | 1 + 4 files changed, 33 insertions(+)drivers/cxl/core/pci.c +1
-0@@ -4,11 +4,14 @@#include <linux/device.h> #include <linux/delay.h> #include <linux/pci.h> +#include <linux/pci-doe.h> #include <cxlpci.h> #include <cxlmem.h> #include <cxl.h> #include "core.h"
Quoted 13 lines
drivers/cxl/core/pci.c int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm) · line 465
Quoted 11 lines
drivers/cxl/core/pci.c +4
-0+#define CXL_DOE_PROTOCOL_TABLE_ACCESS 2 +/** * DOC: cxl core pci * @@ -458,3 +461,28 @@ int cxl_hdm_decode_init(struct cxl_dev_state *cxlds, struct cxl_hdm *cxlhdm)return 0 ; }EXPORT_SYMBOL_NS_GPL (cxl_hdm_decode_init,CXL ); + +void cxl_find_cdat_mb (struct cxl_port *port)kdoc would be good for exported symbols IMO.
Yes. This was not exported before and I forgot.
Quoted 3 lines
Also if you can come up with a
better verb than "find" for something that mutates the port's state, I think that would be beneficial.
cxl_cache_cdat_mb()?
Ira
Quoted 72 lines
I'm not sure why this is exported yet, but I suppose I'll see soon :-)
Quoted 69 lines
drivers/cxl/core/pci.c +23
-0+{ +struct device *dev = port->uport; +struct cxl_memdev *cxlmd; +struct cxl_dev_state *cxlds; +int i; + +if (!is_cxl_memdev (dev)) +return ; + + cxlmd =to_cxl_memdev (dev); + cxlds = cxlmd->cxlds; + +for (i =0 ; i < cxlds->num_mbs; i++) { +struct pci_doe_mb *cur = cxlds->doe_mbs[i]; + +if (pci_doe_supports_prot (cur,PCI_DVSEC_VENDOR_ID_CXL , +CXL_DOE_PROTOCOL_TABLE_ACCESS )) { + port->cdat_mb = cur; +return ; + } + } +} +EXPORT_SYMBOL_NS_GPL (cxl_find_cdat_mb,CXL );drivers/cxl/core/port.c +2
-0@@ -461,6 +461,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,if (IS_ERR (port))return port; +cxl_find_cdat_mb (port); + dev = &port->dev;if (is_cxl_memdev (uport)) rc =dev_set_name (dev,"endpoint%d" , port->id);drivers/cxl/cxl.h +2
-0@@ -267,6 +267,7 @@ struct cxl_nvdimm {* @component_reg_phys: component register capability base address (optional) * @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. +* @cdat_mb: Mailbox which supports the CDAT protocol */ struct cxl_port {struct device dev;@@ -278,6 +279,7 @@ struct cxl_port {resource_size_t component_reg_phys;bool dead;unsigned int depth; +struct pci_doe_mb *cdat_mb; };/** drivers/cxl/cxlpci.h +1
-0@@ -74,4 +74,5 @@ static inline resource_size_t cxl_regmap_to_base(struct pci_dev *pdev,int devm_cxl_port_enumerate_dports (struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm); +void cxl_find_cdat_mb (struct cxl_port *port);#endif /* __CXL_PCI_H__ */ Signature · 1 line
2.35.1
PATCH v9 6/9 cxl/port: Read CDAT table
In reply to [email protected]From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on /sys/firmware/ACPI/tables/
The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Finally create a complete list of DOE defines within cdat.h for code wishing to decode the CDAT table.
---
Changes from V8:
Fix length print format
Incorporate feedback from Jonathan
Move all this to cxl_port which can help support switches when the time comes.
Changes from V6:
Fix issue with devm use
Move cached cdat data to cxl_dev_state
Use new pci_doe_submit_task()
Ensure the aux driver is locked while processing tasks Rebased on cxl-pending
Changes from V5:
Add proper guards around cdat.h
Split out finding the CDAT DOE mailbox
Use cxl_cdat to group CDAT data together
Adjust to use auxiliary_find_device() to find the DOE device
which supplies the CDAT protocol.
Rebased to latest
Remove dev_dbg(length)
Remove unneeded DOE Table access defines
Move CXL_DOE_PROTOCOL_TABLE_ACCESS define into this patch where
it is used
Changes from V4:
Split this into it's own patch
Rearchitect this such that the memdev driver calls into the DOE driver via the cxl_mem state object. This allows CDAT data to come from any type of cxl_mem object not just PCI DOE. Rebase on new struct cxl_dev_state
--- drivers/cxl/cdat.h | 99 ++++++++++++++++++++++++++++++ drivers/cxl/core/pci.c | 132 +++++++++++++++++++++++++++++++++++++++- drivers/cxl/core/port.c | 43 +++++++++++++ drivers/cxl/cxl.h | 3 + drivers/cxl/cxlpci.h | 1 + 5 files changed, 276 insertions(+), 2 deletions(-) create mode 100644 drivers/cxl/cdat.h
drivers/cxl/cdat.h new file +99 -0
@@ -0,0 +1,99 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __CXL_CDAT_H__ +#define __CXL_CDAT_H__ + +/* +* Coherent Device Attribute table (CDAT) +* +* Specification available from UEFI.org +* +* Whilst CDAT is defined as a single table, the access via DOE maiboxes is +* done one entry at a time, where the first entry is the header. +*/ + +#define CXL_DOE_TABLE_ACCESS_REQ_CODE 0x000000ff +#define CXL_DOE_TABLE_ACCESS_REQ_CODE_READ 0 +#define CXL_DOE_TABLE_ACCESS_TABLE_TYPE 0x0000ff00 +#define CXL_DOE_TABLE_ACCESS_TABLE_TYPE_CDATA 0 +#define CXL_DOE_TABLE_ACCESS_ENTRY_HANDLE 0xffff0000 + +/* +* CDAT entries are little endian and are read from PCI config space which +* is also little endian. +* As such, on a big endian system these will have been reversed. +* This prevents us from making easy use of packed structures. +* Style form pci_regs.h +*/ + +#define CDAT_HEADER_LENGTH_DW 4 +#define CDAT_HEADER_LENGTH_BYTES (CDAT_HEADER_LENGTH_DW * sizeof(u32)) +#define CDAT_HEADER_DW0_LENGTH 0xffffffff +#define CDAT_HEADER_DW1_REVISION 0x000000ff +#define CDAT_HEADER_DW1_CHECKSUM 0x0000ff00 +/* CDAT_HEADER_DW2_RESERVED */ +#define CDAT_HEADER_DW3_SEQUENCE 0xffffffff + +/* All structures have a common first DW */ +#define CDAT_STRUCTURE_DW0_TYPE 0x000000ff +#define CDAT_STRUCTURE_DW0_TYPE_DSMAS 0 +#define CDAT_STRUCTURE_DW0_TYPE_DSLBIS 1 +#define CDAT_STRUCTURE_DW0_TYPE_DSMSCIS 2 +#define CDAT_STRUCTURE_DW0_TYPE_DSIS 3 +#define CDAT_STRUCTURE_DW0_TYPE_DSEMTS 4 +#define CDAT_STRUCTURE_DW0_TYPE_SSLBIS 5 + +#define CDAT_STRUCTURE_DW0_LENGTH 0xffff0000 + +/* Device Scoped Memory Affinity Structure */ +#define CDAT_DSMAS_DW1_DSMAD_HANDLE 0x000000ff +#define CDAT_DSMAS_DW1_FLAGS 0x0000ff00 +#define CDAT_DSMAS_DPA_OFFSET (entry) ((u64)((entry)[3]) << 32 | (entry)[2]) +#define CDAT_DSMAS_DPA_LEN (entry) ((u64)((entry)[5]) << 32 | (entry)[4]) +#define CDAT_DSMAS_NON_VOLATILE (flags) ((flags & 0x04) >> 2) + +/* Device Scoped Latency and Bandwidth Information Structure */ +#define CDAT_DSLBIS_DW1_HANDLE 0x000000ff +#define CDAT_DSLBIS_DW1_FLAGS 0x0000ff00 +#define CDAT_DSLBIS_DW1_DATA_TYPE 0x00ff0000 +#define CDAT_DSLBIS_BASE_UNIT (entry) ((u64)((entry)[3]) << 32 | (entry)[2]) +#define CDAT_DSLBIS_DW4_ENTRY_0 0x0000ffff +#define CDAT_DSLBIS_DW4_ENTRY_1 0xffff0000 +#define CDAT_DSLBIS_DW5_ENTRY_2 0x0000ffff + +/* Device Scoped Memory Side Cache Information Structure */ +#define CDAT_DSMSCIS_DW1_HANDLE 0x000000ff +#define CDAT_DSMSCIS_MEMORY_SIDE_CACHE_SIZE (entry) \ + ((u64)((entry)[3]) << 32 | (entry)[2]) +#define CDAT_DSMSCIS_DW4_MEMORY_SIDE_CACHE_ATTRS 0xffffffff + +/* Device Scoped Initiator Structure */ +#define CDAT_DSIS_DW1_FLAGS 0x000000ff +#define CDAT_DSIS_DW1_HANDLE 0x0000ff00 + +/* Device Scoped EFI Memory Type Structure */ +#define CDAT_DSEMTS_DW1_HANDLE 0x000000ff +#define CDAT_DSEMTS_DW1_EFI_MEMORY_TYPE_ATTR 0x0000ff00 +#define CDAT_DSEMTS_DPA_OFFSET (entry) ((u64)((entry)[3]) << 32 | (entry)[2]) +#define CDAT_DSEMTS_DPA_LENGTH (entry) ((u64)((entry)[5]) << 32 | (entry)[4]) + +/* Switch Scoped Latency and Bandwidth Information Structure */ +#define CDAT_SSLBIS_DW1_DATA_TYPE 0x000000ff +#define CDAT_SSLBIS_BASE_UNIT (entry) ((u64)((entry)[3]) << 32 | (entry)[2]) +#define CDAT_SSLBIS_ENTRY_PORT_X (entry, i) ((entry)[4 + (i) * 2] & 0x0000ffff) +#define CDAT_SSLBIS_ENTRY_PORT_Y (entry, i) (((entry)[4 + (i) * 2] & 0xffff0000) >> 16) +#define CDAT_SSLBIS_ENTRY_LAT_OR_BW (entry, i) ((entry)[4 + (i) * 2 + 1] & 0x0000ffff) + +#define CXL_DOE_PROTOCOL_TABLE_ACCESS 2 + +/** +* struct cxl_cdat - CXL CDAT data +* +* @table: cache of CDAT table +* @length: length of cached CDAT table +*/ +struct cxl_cdat { +void *table; +size_t length; +}; + +#endif /* !__CXL_CDAT_H__ */
drivers/cxl/core/pci.c +130 -2
141 lines not on this page · raw message
drivers/cxl/core/port.c +43 -0
56 lines not on this page · raw message
drivers/cxl/cxl.h +3 -0
@@ -8,6 +8,7 @@#include <linux/bitfield.h> #include <linux/bitops.h> #include <linux/io.h> +#include "cdat.h" /** * DOC: cxl objects
@@ -268,6 +269,7 @@ struct cxl_nvdimm {* @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. * @cdat_mb: Mailbox which supports the CDAT protocol +* @cdat: Cached CDAT data */ struct cxl_port {struct device dev;
@@ -280,6 +282,7 @@ struct cxl_port {bool dead;unsigned int depth;struct pci_doe_mb *cdat_mb; +struct cxl_cdat cdat; };/**
drivers/cxl/cxlpci.h +1 -0
@@ -75,4 +75,5 @@ int devm_cxl_port_enumerate_dports(struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm);void cxl_find_cdat_mb (struct cxl_port *port); +void read_cdat_data (struct cxl_port *port);#endif /* __CXL_PCI_H__ */
Signature · 1 line
2.35.1
Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Quoted 19 lines · On Tue, 31 May 2022 08:26:29 -0700 [email protected] wrote:
From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on
/sys/firmware/ACPI/tables/The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Quoted 7 lines
Finally create a complete list of DOE defines within
cdat.hfor code wishing to decode the CDAT table.Signed-off-by Jonathan Cameron <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Fun question of ownership inline...
...
drivers/cxl/core/pci.c void cxl_find_cdat_mb(struct cxl_port *port) · line 596
Quoted 10 lines
drivers/cxl/core/pci.c +10
-0+void read_cdat_data (struct cxl_port *port) +{ +struct device *dev = &port->dev; +size_t cdat_length; +int ret; + +if (cxl_cdat_get_length (port, &cdat_length)) +return ; + + port->cdat.table =devm_kzalloc (dev, cdat_length,GFP_KERNEL );
boom. See below for why :)
Quoted 74 lines
drivers/cxl/core/pci.c +20
-0+if (!port->cdat.table) { + ret = -ENOMEM ; + goto error; + } + + port->cdat.length = cdat_length; + ret =cxl_cdat_read_table (port, &port->cdat); +if (ret) { +devm_kfree (dev, port->cdat.table); + port->cdat.table =NULL ; + port->cdat.length =0 ; + ret = -EIO ; + goto error; + } + +return ; +error: +dev_err (dev,"CDAT data read error (%d)\n" , ret); +} +EXPORT_SYMBOL_NS_GPL (read_cdat_data,CXL );drivers/cxl/core/port.c +41
-0@@ -320,7 +320,48 @@ static void cxl_port_release(struct device *dev)kfree (port); } +static ssize_t cdat_read (struct file *filp,struct kobject *kobj, +struct bin_attribute *bin_attr,char *buf, +loff_t offset,size_t count) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if (!port->cdat.table) +return 0 ; + +return memory_read_from_buffer (buf, count, &offset, + port->cdat.table, + port->cdat.length); +} + +static BIN_ATTR_RO(cdat, 0); + +static umode_t cxl_port_bin_attr_is_visible (struct kobject *kobj, +struct bin_attribute *attr,int i) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if ((attr == &bin_attr_cdat) && port->cdat.table) +return 0400 ; + +return 0 ; +} + +static struct bin_attribute *cxl_cdat_bin_attributes[] = { + &bin_attr_cdat, +NULL , +}; + +static struct attribute_group cxl_cdat_attribute_group = { + .name ="CDAT" , + .bin_attrs = cxl_cdat_bin_attributes, + .is_bin_visible = cxl_port_bin_attr_is_visible, +}; +static const struct attribute_group *cxl_port_attribute_groups[] = { + &cxl_cdat_attribute_group,o &cxl_base_attribute_group,NULL , };
drivers/cxl/core/port.c struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport, · line 507
Quoted 5 lines
drivers/cxl/core/port.c +2
-0@@ -462,6 +503,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,return port;cxl_find_cdat_mb (port); +/* Cache the data early to ensure is_visible() works */ +read_cdat_data (port);
This uses port as the 'device' for devm_ calls.
Unfortunately if the port driver isn't loaded, it still "successfully" runs. Then if the port driver is probed, you get both a bunch of errors due to devm_ allocations on a device before the driver is loaded.
For extra fun it tries to probe the ports multiple times without freeing the index which is 'interesting'. We had this happen a while ago (unrelated to DOE) but this may be unrelated (or maybe related to the region stuff I'm carrying on my test tree)
As to the question of what the correct fix is... Maybe move them into the port driver probe but then is_visible won't work. Or pass a pointer to the struct device *host down into read_cdat_data and __read_cdat_data calls to handle the allocation. (I tried this and it seems superficially fine).
Jonathan
Quoted 41 lines
drivers/cxl/core/port.c +0
-0dev = &port->dev;if (is_cxl_memdev (uport))drivers/cxl/cxl.h +3
-0@@ -8,6 +8,7 @@#include <linux/bitfield.h> #include <linux/bitops.h> #include <linux/io.h> +#include "cdat.h" /** * DOC: cxl objects @@ -268,6 +269,7 @@ struct cxl_nvdimm {* @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. * @cdat_mb: Mailbox which supports the CDAT protocol +* @cdat: Cached CDAT data */ struct cxl_port {struct device dev;@@ -280,6 +282,7 @@ struct cxl_port {bool dead;unsigned int depth;struct pci_doe_mb *cdat_mb; +struct cxl_cdat cdat; };/** drivers/cxl/cxlpci.h +1
-0@@ -75,4 +75,5 @@ int devm_cxl_port_enumerate_dports(struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm);void cxl_find_cdat_mb (struct cxl_port *port); +void read_cdat_data (struct cxl_port *port);#endif /* __CXL_PCI_H__ */
Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Quoted 25 lines · On Wed, 1 Jun 2022 16:35:40 +0100 Jonathan Cameron…
Quoted 22 lines · On Tue, 31 May 2022 08:26:29 -0700 [email protected] wrote:
From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on
/sys/firmware/ACPI/tables/The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Finally create a complete list of DOE defines within
cdat.hfor code wishing to decode the CDAT table.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Jonathan Cameron <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>Fun question of ownership inline...
And a follow up due to triggering a bug that predated this series...
I'd send a fix, but I'm off on a long weekend shortly :)
Quoted 101 lines
...
drivers/cxl/core/pci.c void cxl_find_cdat_mb(struct cxl_port *port) · line 596
Quoted 10 lines
drivers/cxl/core/pci.c +10
-0+void read_cdat_data (struct cxl_port *port) +{ +struct device *dev = &port->dev; +size_t cdat_length; +int ret; + +if (cxl_cdat_get_length (port, &cdat_length)) +return ; + + port->cdat.table =devm_kzalloc (dev, cdat_length,GFP_KERNEL );boom. See below for why :)
Quoted 74 lines
drivers/cxl/core/pci.c +20
-0+if (!port->cdat.table) { + ret = -ENOMEM ; + goto error; + } + + port->cdat.length = cdat_length; + ret =cxl_cdat_read_table (port, &port->cdat); +if (ret) { +devm_kfree (dev, port->cdat.table); + port->cdat.table =NULL ; + port->cdat.length =0 ; + ret = -EIO ; + goto error; + } + +return ; +error: +dev_err (dev,"CDAT data read error (%d)\n" , ret); +} +EXPORT_SYMBOL_NS_GPL (read_cdat_data,CXL );drivers/cxl/core/port.c +41
-0@@ -320,7 +320,48 @@ static void cxl_port_release(struct device *dev)kfree (port); } +static ssize_t cdat_read (struct file *filp,struct kobject *kobj, +struct bin_attribute *bin_attr,char *buf, +loff_t offset,size_t count) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if (!port->cdat.table) +return 0 ; + +return memory_read_from_buffer (buf, count, &offset, + port->cdat.table, + port->cdat.length); +} + +static BIN_ATTR_RO(cdat, 0); + +static umode_t cxl_port_bin_attr_is_visible (struct kobject *kobj, +struct bin_attribute *attr,int i) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if ((attr == &bin_attr_cdat) && port->cdat.table) +return 0400 ; + +return 0 ; +} + +static struct bin_attribute *cxl_cdat_bin_attributes[] = { + &bin_attr_cdat, +NULL , +}; + +static struct attribute_group cxl_cdat_attribute_group = { + .name ="CDAT" , + .bin_attrs = cxl_cdat_bin_attributes, + .is_bin_visible = cxl_port_bin_attr_is_visible, +}; +static const struct attribute_group *cxl_port_attribute_groups[] = { + &cxl_cdat_attribute_group,o &cxl_base_attribute_group,NULL , };drivers/cxl/core/port.c struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport, · line 507
Quoted 5 lines
drivers/cxl/core/port.c +2
-0@@ -462,6 +503,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,return port;cxl_find_cdat_mb (port); +/* Cache the data early to ensure is_visible() works */ +read_cdat_data (port);This uses port as the 'device' for
devm_calls.
Unfortunately if the port driver isn't loaded, it still "successfully" runs. Then if the port driver is probed, you get both a bunch of errors due todevm_allocations on a device before the driver is loaded.
Quoted 4 lines
For extra fun it tries to probe the ports multiple times without freeing the index which is 'interesting'. We had this happen a while ago (unrelated to DOE) but this may be unrelated (or maybe related to the region stuff I'm carrying on my test tree)
So the extra devices are a result of the obvious initial path of cxl_mem_probe() from module probe and down failing, then bus_rescan_devices coming along from the pmem driver having another go...
So next question is why don't the first set of endpointX devices get cleaned up if the create_endpoint() in cxl/mem.c fails.
I think this is because the cxl_endpoint_autoremove() call hasn't yet happened when we detect the failure to bind a driver and error out of cxl_mem_probe().
So, fix is probably to do the cxl_endpoint_autoremove() unconditionally by moving it before the check on driver binding.
https://elixir.bootlin.com/linux/latest/source/drivers/cxl/mem.c#L67
Move it up a few lines.
Quoted 53 lines
As to the question of what the correct fix is... Maybe move them into the port driver probe but then
is_visiblewon't work. Or pass a pointer to the struct device *host down intoread_cdat_dataand__read_cdat_datacalls to handle the allocation. (I tried this and it seems superficially fine).Jonathan
Quoted 41 lines
drivers/cxl/core/port.c +0
-0dev = &port->dev;if (is_cxl_memdev (uport))drivers/cxl/cxl.h +3
-0@@ -8,6 +8,7 @@#include <linux/bitfield.h> #include <linux/bitops.h> #include <linux/io.h> +#include "cdat.h" /** * DOC: cxl objects @@ -268,6 +269,7 @@ struct cxl_nvdimm {* @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. * @cdat_mb: Mailbox which supports the CDAT protocol +* @cdat: Cached CDAT data */ struct cxl_port {struct device dev;@@ -280,6 +282,7 @@ struct cxl_port {bool dead;unsigned int depth;struct pci_doe_mb *cdat_mb; +struct cxl_cdat cdat; };/** drivers/cxl/cxlpci.h +1
-0@@ -75,4 +75,5 @@ int devm_cxl_port_enumerate_dports(struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm);void cxl_find_cdat_mb (struct cxl_port *port); +void read_cdat_data (struct cxl_port *port);#endif /* __CXL_PCI_H__ */
Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Quoted 33 lines · Jonathan Cameron
Quoted 30 lines · On Wed, 1 Jun 2022 16:35:40 +0100 Jonathan Cameron…
Quoted 26 lines · On Tue, 31 May 2022 08:26:29 -0700 [email protected] wrote:
From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on
/sys/firmware/ACPI/tables/The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Finally create a complete list of DOE defines within
cdat.hfor code wishing to decode the CDAT table.Signed-off-by Jonathan Cameron <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 5 lines
Quoted 1 line
Fun question of ownership inline...
And a follow up due to triggering a bug that predated this series...
I'd send a fix, but I'm off on a long weekend shortly :)
NP I discussed with Dan and the use of dev_groups should allow me to move this to port probe where it belongs. I put it here for the sysfs stuff.
Quoted 117 lines
Quoted 102 lines
...
drivers/cxl/core/pci.c void cxl_find_cdat_mb(struct cxl_port *port) · line 596
Quoted 10 lines
drivers/cxl/core/pci.c +10
-0+void read_cdat_data (struct cxl_port *port) +{ +struct device *dev = &port->dev; +size_t cdat_length; +int ret; + +if (cxl_cdat_get_length (port, &cdat_length)) +return ; + + port->cdat.table =devm_kzalloc (dev, cdat_length,GFP_KERNEL );boom. See below for why :)
Quoted 74 lines
drivers/cxl/core/pci.c +20
-0+if (!port->cdat.table) { + ret = -ENOMEM ; + goto error; + } + + port->cdat.length = cdat_length; + ret =cxl_cdat_read_table (port, &port->cdat); +if (ret) { +devm_kfree (dev, port->cdat.table); + port->cdat.table =NULL ; + port->cdat.length =0 ; + ret = -EIO ; + goto error; + } + +return ; +error: +dev_err (dev,"CDAT data read error (%d)\n" , ret); +} +EXPORT_SYMBOL_NS_GPL (read_cdat_data,CXL );drivers/cxl/core/port.c +41
-0@@ -320,7 +320,48 @@ static void cxl_port_release(struct device *dev)kfree (port); } +static ssize_t cdat_read (struct file *filp,struct kobject *kobj, +struct bin_attribute *bin_attr,char *buf, +loff_t offset,size_t count) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if (!port->cdat.table) +return 0 ; + +return memory_read_from_buffer (buf, count, &offset, + port->cdat.table, + port->cdat.length); +} + +static BIN_ATTR_RO(cdat, 0); + +static umode_t cxl_port_bin_attr_is_visible (struct kobject *kobj, +struct bin_attribute *attr,int i) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_port *port =to_cxl_port (dev); + +if ((attr == &bin_attr_cdat) && port->cdat.table) +return 0400 ; + +return 0 ; +} + +static struct bin_attribute *cxl_cdat_bin_attributes[] = { + &bin_attr_cdat, +NULL , +}; + +static struct attribute_group cxl_cdat_attribute_group = { + .name ="CDAT" , + .bin_attrs = cxl_cdat_bin_attributes, + .is_bin_visible = cxl_port_bin_attr_is_visible, +}; +static const struct attribute_group *cxl_port_attribute_groups[] = { + &cxl_cdat_attribute_group,o &cxl_base_attribute_group,NULL , };drivers/cxl/core/port.c struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport, · line 507
Quoted 5 lines
drivers/cxl/core/port.c +2
-0@@ -462,6 +503,8 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,return port;cxl_find_cdat_mb (port); +/* Cache the data early to ensure is_visible() works */ +read_cdat_data (port);This uses port as the 'device' for
devm_calls.
Unfortunately if the port driver isn't loaded, it still "successfully" runs. Then if the port driver is probed, you get both a bunch of errors due todevm_allocations on a device before the driver is loaded.Quoted 4 lines
For extra fun it tries to probe the ports multiple times without freeing the index which is 'interesting'. We had this happen a while ago (unrelated to DOE) but this may be unrelated (or maybe related to the region stuff I'm carrying on my test tree)
So the extra devices are a result of the obvious initial path of
cxl_mem_probe()from module probe and down failing, thenbus_rescan_devicescoming along from the pmem driver having another go...So next question is why don't the first set of endpointX devices get cleaned up if the
create_endpoint()incxl/mem.cfails.I think this is because the
cxl_endpoint_autoremove()call hasn't yet happened when we detect the failure to bind a driver and error out ofcxl_mem_probe().
Quoted 7 lines
So, fix is probably to do the
cxl_endpoint_autoremove()unconditionally by moving it before the check on driver binding.https://elixir.bootlin.com/linux/latest/source/drivers/cxl/mem.c#L67
Move it up a few lines.
I think I can make it work by moving into the port probe.
Ira
Quoted 56 lines
Quoted 55 lines
As to the question of what the correct fix is... Maybe move them into the port driver probe but then
is_visiblewon't work. Or pass a pointer to the struct device *host down intoread_cdat_dataand__read_cdat_datacalls to handle the allocation. (I tried this and it seems superficially fine).Jonathan
Quoted 41 lines
drivers/cxl/core/port.c +0
-0dev = &port->dev;if (is_cxl_memdev (uport))drivers/cxl/cxl.h +3
-0@@ -8,6 +8,7 @@#include <linux/bitfield.h> #include <linux/bitops.h> #include <linux/io.h> +#include "cdat.h" /** * DOC: cxl objects @@ -268,6 +269,7 @@ struct cxl_nvdimm {* @dead: last ep has been removed, force port re-creation * @depth: How deep this port is relative to the root. depth 0 is the root. * @cdat_mb: Mailbox which supports the CDAT protocol +* @cdat: Cached CDAT data */ struct cxl_port {struct device dev;@@ -280,6 +282,7 @@ struct cxl_port {bool dead;unsigned int depth;struct pci_doe_mb *cdat_mb; +struct cxl_cdat cdat; };/** drivers/cxl/cxlpci.h +1
-0@@ -75,4 +75,5 @@ int devm_cxl_port_enumerate_dports(struct cxl_port *port);struct cxl_dev_state ;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm);void cxl_find_cdat_mb (struct cxl_port *port); +void read_cdat_data (struct cxl_port *port);#endif /* __CXL_PCI_H__ */
Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Quoted 34 lines · Ira
Quoted 33 lines · Jonathan Cameron
Quoted 30 lines · On Wed, 1 Jun 2022 16:35:40 +0100 Jonathan Cameron…
Quoted 26 lines · On Tue, 31 May 2022 08:26:29 -0700 [email protected] wrote:
From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on
/sys/firmware/ACPI/tables/The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Finally create a complete list of DOE defines within
cdat.hfor code wishing to decode the CDAT table.Signed-off-by Jonathan Cameron <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Fun question of ownership inline...
And a follow up due to triggering a bug that predated this series...
I'd send a fix, but I'm off on a long weekend shortly :)
NP I discussed with Dan and the use of
dev_groupsshould allow me to move this to port probe where it belongs. I put it here for the sysfs stuff.
Not to make a habit of replying to my own mails but this works.
So I'm going to go forward with spinning this again.
Ira
Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Quoted 39 lines · On Thu, 2 Jun 2022 15:47:37 -0700 Ira Weiny <[email protected]> wrote:
Quoted 38 lines · Ira
Quoted 37 lines · Jonathan Cameron
Quoted 25 lines · On Wed, 1 Jun 2022 16:35:40 +0100 Jonathan Cameron…
Quoted 22 lines · On Tue, 31 May 2022 08:26:29 -0700 [email protected] wrote:
From: Jonathan Cameron <[email protected]>
The OS will need CDAT data from CXL devices to properly set up interleave sets. Currently this is supported through a DOE mailbox which supports CDAT.
Cache the CDAT data for later parsing. Provide a sysfs binary attribute to allow dumping of the CDAT.
Binary dumping is modeled on
/sys/firmware/ACPI/tables/The ability to dump this table will be very useful for emulation of real devices once they become available as QEMU CXL type 3 device emulation will be able to load this file in.
This does not support table updates at runtime. It will always provide whatever was there when first cached. Handling of table updates can be implemented later.
Finally create a complete list of DOE defines within
cdat.hfor code wishing to decode the CDAT table.Quoted 6 lines
Quoted 4 lines
Signed-off-by Jonathan Cameron <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>Fun question of ownership inline...
And a follow up due to triggering a bug that predated this series...
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
I'd send a fix, but I'm off on a long weekend shortly :)
NP I discussed with Dan and the use of
dev_groupsshould allow me to move this to port probe where it belongs. I put it here for the sysfs stuff.Not to make a habit of replying to my own mails but this works.
So I'm going to go forward with spinning this again.
It's the right solution - cleaner than moving the ownership.
Jonathan
Quoted 2 lines
Ira
PATCH v9 7/9 cxl/port: Introduce cxl_cdat_valid()
In reply to [email protected]From: Ira Weiny <[email protected]>
The CDAT data is protected by a checksum and should be the proper length.
Introduce cxl_cdat_valid() to validate the data. While at it check and store the sequence number.
---
Changes from V8
Move code to cxl/core/pci.c
Changes from V6
Change name to cxl_cdat_valid() as this validates all the CDAT
data not just the header
Add error and debug prints
Changes from V5
New patch, split out
Update cdat_hdr_valid()
Remove revision and cs field parsing
There is no point in these
Add seq check and debug print.
--- drivers/cxl/cdat.h | 2 ++ drivers/cxl/core/pci.c | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+)
drivers/cxl/cdat.h +2 -0
@@ -90,10 +90,12 @@* * @table: cache of CDAT table * @length: length of cached CDAT table +* @seq: Last read Sequence number of the CDAT table */ struct cxl_cdat {void *table;size_t length; +u32 seq; };#endif /* !__CXL_CDAT_H__ */
drivers/cxl/core/pci.c +36 -0
@@ -534,6 +534,40 @@ static int cxl_cdat_get_length(struct cxl_port *port, size_t *length)return rc; } +static bool cxl_cdat_valid (struct device *dev,struct cxl_cdat *cdat) +{ +u32 *table = cdat->table; +u8 *data8 = cdat->table; +u32 length, seq; +u8 check; +int i; + + length =FIELD_GET (CDAT_HEADER_DW0_LENGTH , table[0 ]); +if ((length <CDAT_HEADER_LENGTH_BYTES ) || (length > cdat->length)) { +dev_err (dev,"Invalid length %u (%zu-%zu)\n" , length, +CDAT_HEADER_LENGTH_BYTES , cdat->length); +return false; + } + +for (check =0 , i =0 ; i < length; i++) + check += data8[i]; + +dev_dbg (dev,"CDAT length %u CS %u\n" , length, check); +if (check !=0 ) { +dev_err (dev,"Invalid checksum %u\n" , check); +return false; + } + + seq =FIELD_GET (CDAT_HEADER_DW3_SEQUENCE , table[3 ]); +/* Store the sequence for now. */ +if (cdat->seq != seq) { +dev_info (dev,"CDAT seq change %x -> %x\n" , cdat->seq, seq); + cdat->seq = seq; + } + +return true; +} +static int cxl_cdat_read_table (struct cxl_port *port,struct cxl_cdat *cdat) {
@@ -581,6 +615,8 @@ static int cxl_cdat_read_table(struct cxl_port *port, }while (entry_handle !=0xFFFF ); +if (!rc && !cxl_cdat_valid (&port->dev, cdat)) +return -EIO ;return rc; }
Signature · 1 line
2.35.1
Alison Schofield
maintainerRe: [PATCH V9 7/9] cxl/port: Introduce cxl_cdat_valid()
Quoted 8 lines · Ira Weiny
From: Ira Weiny <[email protected]>
The CDAT data is protected by a checksum and should be the proper length.
Introduce
cxl_cdat_valid()to validate the data. While at it check and store the sequence number.
Store it for ?
Quoted 3 lines
drivers/cxl/core/pci.c +2
-0+static bool cxl_cdat_valid (struct device *dev,struct cxl_cdat *cdat) +{
snip
drivers/cxl/core/pci.c static int cxl_cdat_get_length(struct cxl_port *port, size_t *length) · line 567
Quoted 8 lines
drivers/cxl/core/pci.c +8
-0+ + seq =FIELD_GET (CDAT_HEADER_DW3_SEQUENCE , table[3 ]); +/* Store the sequence for now. */ +if (cdat->seq != seq) { +dev_info (dev,"CDAT seq change %x -> %x\n" , cdat->seq, seq); + cdat->seq = seq; + } +
Wondering when does/will this sequence number come into play?
Quoted 1 line
Re: [PATCH V9 7/9] cxl/port: Introduce cxl_cdat_valid()
Quoted 10 lines · Alison Schofield
Quoted 8 lines · Ira Weiny
From: Ira Weiny <[email protected]>
The CDAT data is protected by a checksum and should be the proper length.
Introduce
cxl_cdat_valid()to validate the data. While at it check and store the sequence number.Store it for ?
To see if a subsequent read shows new data.
Quoted 7 lines
Quoted 4 lines
drivers/cxl/core/pci.c +2
-0+static bool cxl_cdat_valid (struct device *dev,struct cxl_cdat *cdat) +{snip
Quoted 11 lines
drivers/cxl/core/pci.c static int cxl_cdat_get_length(struct cxl_port *port, size_t *length) · line 567
Quoted 8 lines
drivers/cxl/core/pci.c +8
-0+ + seq =FIELD_GET (CDAT_HEADER_DW3_SEQUENCE , table[3 ]); +/* Store the sequence for now. */ +if (cdat->seq != seq) { +dev_info (dev,"CDAT seq change %x -> %x\n" , cdat->seq, seq); + cdat->seq = seq; + } +Wondering when does/will this sequence number come into play?
Not until we start reacting to changes in CDAT.
Ira
PATCH v9 8/9 cxl/port: Retry reading CDAT on failure
In reply to [email protected]From: Ira Weiny <[email protected]>
The CDAT read may fail for a number of reasons but mainly it is possible to get different parts of a valid state. The checksum in the CDAT table protects against this.
Now that the cdat data is validated issue a retries if the CDAT read fails. For now 5 retries are implemented.
---
Changes from V8
Move code to cxl/core/pci.c
Changes from V6
Move to pci.c
Fix retries count
Change to 5 retries
Changes from V5:
New patch -- easy to push off or drop.
--- drivers/cxl/core/pci.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-)
drivers/cxl/core/pci.c +21 -11
@@ -620,20 +620,18 @@ static int cxl_cdat_read_table(struct cxl_port *port,return rc; } -void read_cdat_data (struct cxl_port *port) +static int __read_cdat_data (struct cxl_port *port) {struct device *dev = &port->dev;size_t cdat_length;int ret;if (cxl_cdat_get_length (port, &cdat_length)) -return ; +return 0 ; port->cdat.table =devm_kzalloc (dev, cdat_length,GFP_KERNEL ); -if (!port->cdat.table) { - ret = -ENOMEM ; - goto error; - } +if (!port->cdat.table) +return -ENOMEM ; port->cdat.length = cdat_length; ret =cxl_cdat_read_table (port, &port->cdat);
@@ -641,12 +639,24 @@ void read_cdat_data(struct cxl_port *port)devm_kfree (dev, port->cdat.table); port->cdat.table =NULL ; port->cdat.length =0 ; - ret = -EIO ; - goto error; +return -EIO ; } -return ; -error: -dev_err (dev,"CDAT data read error (%d)\n" , ret); +return 0 ; +} + +void read_cdat_data (struct cxl_port *port) +{ +int retries =5 ; +int rc; + +while (retries--) { + rc =__read_cdat_data (port); +if (!rc) +break ; +dev_err (&port->dev, +"CDAT data read error rc=%d (retries %d)\n" , + rc, retries); + } }EXPORT_SYMBOL_NS_GPL (read_cdat_data,CXL );
Signature · 1 line
2.35.1
Alison Schofield
maintainerRe: [PATCH V9 8/9] cxl/port: Retry reading CDAT on failure
Quoted 12 lines · Ira Weiny
From: Ira Weiny <[email protected]>
The CDAT read may fail for a number of reasons but mainly it is possible to get different parts of a valid state. The checksum in the CDAT table protects against this.
Now that the cdat data is validated issue a retries if the CDAT read fails. For now 5 retries are implemented.
Signed-off-by Ira Weiny <[email protected]>---
snip
Quoted 4 lines
drivers/cxl/core/pci.c +4
-0+ +void read_cdat_data (struct cxl_port *port) +{ +int retries =5 ;
drivers/cxl/core/pci.c void read_cdat_data(struct cxl_port *port) · line 660
Quoted 10 lines
drivers/cxl/core/pci.c +10
-0+int rc; + +while (retries--) { + rc =__read_cdat_data (port); +if (!rc) +break ; +dev_err (&port->dev, +"CDAT data read error rc=%d (retries %d)\n" , + rc, retries); + }
Perhaps dev_dbg() on retries and dev_err() only when retries are exhausted.
Quoted 5 lines
}
EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL);Signature · 1 line
2.35.1
Re: [PATCH V9 8/9] cxl/port: Retry reading CDAT on failure
Quoted 16 lines · Alison Schofield
Quoted 12 lines · Ira Weiny
From: Ira Weiny <[email protected]>
The CDAT read may fail for a number of reasons but mainly it is possible to get different parts of a valid state. The checksum in the CDAT table protects against this.
Now that the cdat data is validated issue a retries if the CDAT read fails. For now 5 retries are implemented.
Signed-off-by Ira Weiny <[email protected]>---
snip
Quoted 16 lines
Quoted 4 lines
drivers/cxl/core/pci.c +4
-0+ +void read_cdat_data (struct cxl_port *port) +{ +int retries =5 ;drivers/cxl/core/pci.c void read_cdat_data(struct cxl_port *port) · line 660
Quoted 10 lines
drivers/cxl/core/pci.c +10
-0+int rc; + +while (retries--) { + rc =__read_cdat_data (port); +if (!rc) +break ; +dev_err (&port->dev, +"CDAT data read error rc=%d (retries %d)\n" , + rc, retries); + }Perhaps
dev_dbg()on retries anddev_err()only when retries are exhausted.
Yes thanks!
Ira
Quoted 7 lines
Quoted 7 lines
}
EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL);Signature · 1 line
2.35.1
Davidlohr Bueso
maintainerRe: [PATCH v9 8/9] cxl/port: Retry reading CDAT on failure
In reply to [email protected]Quoted 74 lines · On Tue, 31 May 2022, [email protected] wrote:
From: Ira Weiny <[email protected]>
The CDAT read may fail for a number of reasons but mainly it is possible to get different parts of a valid state. The checksum in the CDAT table protects against this.
Now that the cdat data is validated issue a retries if the CDAT read fails. For now 5 retries are implemented.
Signed-off-by Ira Weiny <[email protected]>---
Changes from V8
Move code tocxl/core/pci.cChanges from V6
Move topci.c
Fix retries count
Change to 5 retriesChanges from V5:
New patch -- easy to push off or drop.
---drivers/cxl/core/pci.c| 32 +++++++++++++++++++++-----------1 file changed, 21 insertions(+), 11 deletions(-)drivers/cxl/core/pci.c +13
-11@@ -620,20 +620,18 @@ static int cxl_cdat_read_table(struct cxl_port *port,return rc; } -void read_cdat_data (struct cxl_port *port) +static int __read_cdat_data (struct cxl_port *port) {struct device *dev = &port->dev;size_t cdat_length;int ret;if (cxl_cdat_get_length (port, &cdat_length)) -return ; +return 0 ; port->cdat.table =devm_kzalloc (dev, cdat_length,GFP_KERNEL ); -if (!port->cdat.table) { - ret = -ENOMEM ; - goto error; - } +if (!port->cdat.table) +return -ENOMEM ; port->cdat.length = cdat_length; ret =cxl_cdat_read_table (port, &port->cdat);@@ -641,12 +639,24 @@ void read_cdat_data(struct cxl_port *port)devm_kfree (dev, port->cdat.table); port->cdat.table =NULL ; port->cdat.length =0 ; - ret = -EIO ; - goto error; +return -EIO ; } -return ; -error: -dev_err (dev,"CDAT data read error (%d)\n" , ret); +return 0 ; +} + +void read_cdat_data (struct cxl_port *port) +{ +int retries =5 ; +int rc; +
drivers/cxl/core/pci.c void read_cdat_data(struct cxl_port *port) · line 662
Quoted 10 lines
drivers/cxl/core/pci.c +8
-0+while (retries--) { + rc =__read_cdat_data (port); +if (!rc) +break ; +dev_err (&port->dev, +"CDAT data read error rc=%d (retries %d)\n" , + rc, retries); + } }EXPORT_SYMBOL_NS_GPL (read_cdat_data,CXL );
Better a single final error message after exhausting all retries instead of each time.
Thanks,
Davidlohr
PATCH v9 9/9 cxl/port: Parse out DSMAS data from CDAT table
In reply to [email protected]From: Ira Weiny <[email protected]>
CXL Ports with memory devices attached need the information from the Device Scoped Memory Affinity Structure (DSMAS). This information is contained within the CDAT table buffer which is previously read and cached in the port device.
If CDAT data is available, parse and cache DSMAS data from the table. Store this data in unmarshaled struct dsmas data structures for ease of use later.
---
Changes from V8
Adjust to the cdat data being in cxl_port
Changes from V7
Rebased on cxl-pending
Changes from V6
Move to port.c
It is not an error if no DSMAS data is found
Changes from V5
Fix up sparse warnings
Split out cdat_hdr_valid()
Update cdat_hdr_valid()
Remove revision and cs field parsing
There is no point in these
Add seq check and debug print.
From Jonathan
Add spaces around '+' and '/' use devm_krealloc() for dmas_ary
--- drivers/cxl/cdat.h | 17 +++++++++++ drivers/cxl/core/pci.c | 65 ++++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxl.h | 2 ++ drivers/cxl/cxlmem.h | 4 +++ drivers/cxl/cxlpci.h | 1 + drivers/cxl/mem.c | 1 + 6 files changed, 90 insertions(+)
drivers/cxl/cdat.h +17 -0
@@ -85,6 +85,23 @@#define CXL_DOE_PROTOCOL_TABLE_ACCESS 2 +/** +* struct cxl_dsmas - host unmarshaled version of DSMAS data +* +* As defined in the Coherent Device Attribute Table (CDAT) specification this +* represents a single DSMAS entry in that table. +* +* @dpa_base: The lowest Device Physical Address associated with this DSMAD +* @length: Length in bytes of this DSMAD +* @non_volatile: If set, the memory region represents Non-Volatile memory +*/ +struct cxl_dsmas { +u64 dpa_base; +u64 length; +/* Flags */ +u8 non_volatile:1 ; +}; +/** * struct cxl_cdat - CXL CDAT data *
drivers/cxl/core/pci.c +65 -0
68 lines not on this page · raw message
drivers/cxl/cxl.h +2 -0
@@ -10,6 +10,8 @@#include <linux/io.h> #include "cdat.h" +#include "cdat.h" +/** * DOC: cxl objects *
drivers/cxl/cxlmem.h +4 -0
@@ -36,6 +36,8 @@* @cxlds: The device state backing this device * @detach_work: active memdev lost a port in its ancestry * @id: id number of this memdev instance. +* @dsmas_ary: Array of DSMAS entries as parsed from the CDAT table +* @nr_dsmas: Number of entries in dsmas_ary */ struct cxl_memdev {struct device dev;
@@ -43,6 +45,8 @@ struct cxl_memdev {struct cxl_dev_state *cxlds;struct work_struct detach_work;int id; +struct cxl_dsmas *dsmas_ary; +int nr_dsmas; };static inline struct cxl_memdev *to_cxl_memdev (struct device *dev)
drivers/cxl/cxlpci.h +1 -0
@@ -76,4 +76,5 @@ struct cxl_dev_state;int cxl_hdm_decode_init (struct cxl_dev_state *cxlds,struct cxl_hdm *cxlhdm);void cxl_find_cdat_mb (struct cxl_port *port);void read_cdat_data (struct cxl_port *port); +void parse_dsmas (struct cxl_memdev *cxlmd,struct cxl_port *port);#endif /* __CXL_PCI_H__ */
drivers/cxl/mem.c +1 -0
@@ -35,6 +35,7 @@ static int create_endpoint(struct cxl_memdev *cxlmd,if (IS_ERR (endpoint))return PTR_ERR (endpoint); +parse_dsmas (cxlmd, endpoint);dev_dbg (&cxlmd->dev,"add: %s\n" ,dev_name (&endpoint->dev));if (!endpoint->dev.driver) {
Signature · 1 line
2.35.1