MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal
Subsystems (3)
PATCH 1/1 MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal
Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference in MAINTAINERS.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference.
Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA DRIVERS.
---
Leon, please pick this minor non-urgent clean-up patch on top of the commit above.
MAINTAINERS | 1 - 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
@@ -12695,7 +12695,6 @@ L: [email protected] S: Supported W: http://www.mellanox.com Q: https://patchwork.kernel.org/project/netdevbpf/list/ -F: drivers/net/ethernet/mellanox/mlx5/core/accel/* F: drivers/net/ethernet/mellanox/mlx5/core/en_accel/* F: drivers/net/ethernet/mellanox/mlx5/core/fpga/* F: include/linux/mlx5/mlx5_ifc_fpga.h
Signature · 1 line
2.17.1
Quoted 7 lines · Lukas Bulwahn
Commit
40379a0084c2("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directorydrivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference inMAINTAINERS.Hence,
./scripts/get_maintainer.pl--self-test=patterns complains about a broken reference.
Quoted 7 lines
Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA DRIVERS.
Signed-off-by Lukas Bulwahn <[email protected]>---
Leon, please pick this minor non-urgent clean-up patch on top of the commit above.
Thanks, we will submit it once net-next will be open.
Jakub Kicinski
maintainerQuoted 11 lines · On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote:
Quoted 10 lines · Lukas Bulwahn
Commit
40379a0084c2("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directorydrivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference inMAINTAINERS.Hence,
./scripts/get_maintainer.pl--self-test=patterns complains about a broken reference.Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA DRIVERS.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukas Bulwahn <[email protected]>---
Leon, please pick this minor non-urgent clean-up patch on top of the commit above.Thanks, we will submit it once net-next will be open.
It should go via net FWIW.
Quoted 12 lines · Jakub Kicinski
Quoted 11 lines · On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote:
Quoted 10 lines · Lukas Bulwahn
Commit
40379a0084c2("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directorydrivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference inMAINTAINERS.Hence,
./scripts/get_maintainer.pl--self-test=patterns complains about a broken reference.Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA DRIVERS.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Lukas Bulwahn <[email protected]>---
Leon, please pick this minor non-urgent clean-up patch on top of the commit above.Thanks, we will submit it once net-next will be open.
It should go via net FWIW.
I'm slightly confused here.
According to net policy, the patches that goes there should have Fixes line, but Fixes lines are added for bugs [1].
This forgotten line in MAINTAINERS doesn't cause to any harm to users/developers.
So when should I put Fixes line in netdev?
Thanks
Jakub Kicinski
maintainerQuoted 5 lines · On Wed, 1 Jun 2022 21:08:06 +0300 Leon Romanovsky wrote:
Quoted 3 lines · Jakub Kicinski
Quoted 1 line
Thanks, we will submit it once net-next will be open.
It should go via net FWIW.
Quoted 7 lines
I'm slightly confused here.
According to net policy, the patches that goes there should have Fixes line, but Fixes lines are added for bugs [1].
This forgotten line in
MAINTAINERSdoesn't cause to any harm to users/developers.
Fair, maybe I worded it too strongly. I should have said something like "FWIW it's okay for MAINTAINERS updates to go via net".
Documentation/ patches and MAINTAINERS are special, they can go into net without a Fixes tag so that changes to get_maintainer output and
https://www.kernel.org/doc/html/latest/ propagate quickly.
Quoted 3 lines
So when should I put Fixes line in netdev?
Quoted 14 lines · Jakub Kicinski
Quoted 5 lines · On Wed, 1 Jun 2022 21:08:06 +0300 Leon Romanovsky wrote:
Quoted 3 lines · Jakub Kicinski
Quoted 1 line
Thanks, we will submit it once net-next will be open.
It should go via net FWIW.
Quoted 7 lines
I'm slightly confused here.
According to net policy, the patches that goes there should have Fixes line, but Fixes lines are added for bugs [1].
This forgotten line in
MAINTAINERSdoesn't cause to any harm to users/developers.
Quoted 6 lines
Fair, maybe I worded it too strongly. I should have said something like "FWIW it's okay for
MAINTAINERSupdates to go via net".
Documentation/patches andMAINTAINERSare special, they can go into net without a Fixes tag so that changes toget_maintaineroutput and
https://www.kernel.org/doc/html/latest/ propagate quickly.
Awesome, thanks
Quoted 5 lines
Quoted 4 lines
So when should I put Fixes line in netdev?
This patch was applied to netdev/net.git (master) by Saeed Mahameed <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Saeed Mahameed <[email protected]>:
Quoted 8 lines · On Wed, 1 Jun 2022 06:57:38 +0200 you wrote:
Commit
40379a0084c2("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directorydrivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference inMAINTAINERS.Hence,
./scripts/get_maintainer.pl--self-test=patterns complains about a broken reference.[...]
Here is the summary with links:
- MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal
https://git.kernel.org/netdev/net/c/ed872f92fd09
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Jakub Kicinski
maintainerQuoted 10 lines · On Fri, 10 Jun 2022 05:20:14 +0000 [email protected] wrote:
Hello:
This patch was applied to netdev/net.git (master)
by Saeed Mahameed <[email protected]>:Quoted 4 lines · On Wed, 1 Jun 2022 06:57:38 +0200 you wrote:
Commit
40379a0084c2("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directorydrivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference inMAINTAINERS.
Quoted 8 lines
Quoted 4 lines
Hence,
./scripts/get_maintainer.pl--self-test=patterns complains about a broken reference.[...]
Here is the summary with links:
-MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removalhttps://git.kernel.org/netdev/net/c/ed872f92fd09
What luck. I was trying to see if pw-bot will respond to the PR rather than the series if I mark the series as accepted first but apparently it found this random posting and replied to it instead :S
That's a roundabout way of saying that I pulled "mlx5 fixes 2022-06-08", thanks!