Skip to contentSkip to conversation

drivers: cache: ncore: Disable snoop filter

PATCH In review [email protected] 2 participants 2 messages Jun 1, 2022 – Jun 16, 2022 Standalone cache controller drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: cache: ncore: Disable snoop filter

From: Dinesh Maniyam <[email protected]>

There is hardware bug in NCORE CCU IP and it is causing an issue in the coherent directory tracking of outstanding cache lines.
The workaround is disabling snoop filter.

---
 drivers/cache/cache-ncore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/cache/cache-ncore.c +3 -3
index 3beff780de..117d2b91ab 100644
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
+ * Copyright (C) 2019-2022 Intel Corporation <www.intel.com>
  *
  */
 #include <dm.h>
@@ -81,8 +81,8 @@ static void ncore_ccu_init_dirs(void __iomem *base)
 				hang();
 			}
 
-			/* Enable snoop filter, a bit per snoop filter */
-			setbits_le32((ulong)CCU_DIR_REG_ADDR(base, DIRUSFER, i),
+			/* Disable snoop filter, a bit per snoop filter */
+			clrbits_le32((ulong)CCU_DIR_REG_ADDR(base, DIRUSFER, i),
 				     BIT(f));
 		}
 	}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 51 lines

-----Original Message-----
From: Maniyam, Dinesh <[email protected]>
Sent: Wednesday, 1 June, 2022 3:57 PM
To: [email protected]
Cc: Vasut, Marek <[email protected]>; Simon Goldschmidt <[email protected]>; Chee, Tien Fong <[email protected]>; Hea, Kok Kiang <[email protected]>; Gan, Yau Wai <[email protected]>; Kho, Sin Hui <[email protected]>; Lokanathan, Raaj <[email protected]>; Maniyam, Dinesh <[email protected]>
Subject: [PATCH] drivers: cache: ncore: Disable snoop filter

From: Dinesh Maniyam <[email protected]>

There is hardware bug in NCORE CCU IP and it is causing an issue in the coherent directory tracking of outstanding cache lines.
The workaround is disabling snoop filter.

---
 drivers/cache/cache-ncore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/cache/cache-ncore.c index renamed from drivers/cache/cache-ncore.c +0 -0

3beff780de..117d2b91ab 100644

drivers/cache/cache-ncore.c +3 -3
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
+ * Copyright (C) 2019-2022 Intel Corporation <www.intel.com>
  *
  */
 #include <dm.h>
@@ -81,8 +81,8 @@ static void ncore_ccu_init_dirs(void __iomem *base)
 				hang();
 			}
 
-			/* Enable snoop filter, a bit per snoop filter */
-			setbits_le32((ulong)CCU_DIR_REG_ADDR(base,
 DIRUSFER, i),
+			/* Disable snoop filter, a bit per snoop filter */
+			clrbits_le32((ulong)CCU_DIR_REG_ADDR(base,
 DIRUSFER, i),
 				     BIT(f));
drivers/cache/cache-ncore.c +0 -1
 		}
 	}
--
Quoted 1 line

2.25.1

Regards
Tien Fong