memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
Subsystems (3)
PATCH v2 1/1 memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
The reference taken by 'of_find_device_by_node()' must be released when not needed anymore.
Add the corresponding 'put_device()' in the error handling paths.
---
changes in v2:
- add put_device() in return path -ENODEV.
I don't add put_device in normal path(return 0) because it will set *com_dev=&smi_com_pdev->dev; and escape to the caller.
v1 link:
https://lore.kernel.org/all/[email protected]/
--- drivers/memory/mtk-smi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/memory/mtk-smi.c +4 -1
@@ -404,13 +404,16 @@ static int mtk_smi_device_link_common(struct device *dev, struct device **com_deof_node_put (smi_com_node);if (smi_com_pdev) {/* smi common is the supplier, Make sure it is ready before */ -if (!platform_get_drvdata (smi_com_pdev)) +if (!platform_get_drvdata (smi_com_pdev)) { +put_device (&smi_com_pdev->dev);return -EPROBE_DEFER ; + } smi_com_dev = &smi_com_pdev->dev; link =device_link_add (dev, smi_com_dev,DL_FLAG_PM_RUNTIME |DL_FLAG_STATELESS );if (!link) {dev_err (dev,"Unable to link smi-common dev\n" ); +put_device (&smi_com_pdev->dev);return -ENODEV ; } *com_dev = smi_com_dev;
Signature · 1 line
2.25.1
Quoted 5 lines · Miaoqian Lin
The reference taken by '
of_find_device_by_node()' must be released when not needed anymore.
Add the corresponding 'put_device()' in the error handling paths.Fixes 4740475 ("memory: mtk-smi: Add device link for smi-sub-common")
This is not correct SHA. Read:Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Krzysztof Kozlowski
AppliedQuoted 5 lines · Miaoqian Lin
The reference taken by '
of_find_device_by_node()' must be released when not needed anymore.
Add the corresponding 'put_device()' in the error handling paths.
Applied, thanks!
[1/1] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
https://git.kernel.org/krzk/linux-mem-ctrl/c/038ae37c510fd57cbc543ac82db1e7b23b28557a
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>