drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full
Subsystems (2)
PATCH RESEND 1/1 drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full
In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev); We need to use put_device() instead freeing directly.
Fixes 068a002 ("drm: Add MIPI DSI bus support")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_mipi_dsi.c +1 -1
@@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, ret =mipi_dsi_device_add (dsi);if (ret) {drm_err (host,"failed to add DSI device %d\n" , ret); -kfree (dsi); +put_device (&dsi->dev);return ERR_PTR (ret); }
Signature · 1 line
2.25.1
Quoted 5 lines · Miaoqian Lin
In
mipi_dsi_device_alloc(), it callsdevice_initialize(&dsi->dev); We need to useput_device()instead freeing directly.Fixes 068a002 ("drm: Add MIPI DSI bus support")Signed-off-by Miaoqian Lin <[email protected]>
Looks correct.
Reviewed-by Andrzej Hajda <[email protected]>
Regards
Andrzej
Quoted 17 lines
--- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_mipi_dsi.c +1
-1@@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, ret =mipi_dsi_device_add (dsi);if (ret) {drm_err (host,"failed to add DSI device %d\n" , ret); -kfree (dsi); +put_device (&dsi->dev);return ERR_PTR (ret); }