Skip to contentSkip to conversation

netconfig: Switch to l_netconfig

PATCH New Andrew Zaborowski 1 participant 1 message Jun 1, 2022 Kbuild

lore
Share & tools
lore

Andrew Zaborowski

author
#0 lore raw

PATCH 1/1 netconfig: Switch to l_netconfig

This patch depends on ell patches that are mostly on the ell list but are blocked by a release or other factors, posting this for early review. This leaves IWD's netconfig.h mostly unchanged but the implementation is switched over to use l_netconfig.

The struct netconfig declaration is nearly empty now but contains the resolver client, the data received from FILS and some state that mirrors l_netconfig state and could be replaced by using l_netconfig getters for the settings which have only setters at this time.

A minor behaviour change is that a netconfig failure, such as DHCP error or timeout, would now cause station to signal an DBus error and continue with autoconnect instead of being stuck in netconfig.

---
 Makefile.am     |    6 +-
 src/netconfig.c | 1642 +++++++++++------------------------------------
 src/netconfig.h |    1 +
 src/station.c   |   88 +--
 4 files changed, 413 insertions(+), 1324 deletions(-)
Makefile.am +4 -2
index 80377613..bcb313d7 100644
@@ -62,7 +62,8 @@ ell_headers = ell/util.h \
 			ell/icmp6.h \
 			ell/dhcp6.h \
 			ell/acd.h \
-			ell/cleanup.h
+			ell/cleanup.h \
+			ell/netconfig.h
 
 ell_sources = ell/private.h \
 			ell/missing.h \
@@ -141,7 +142,8 @@ ell_sources = ell/private.h \
 			ell/icmp6-private.h \
 			ell/dhcp6-lease.c \
 			ell/dhcp6-transport.c \
-			ell/acd.c
+			ell/acd.c \
+			ell/netconfig.c
 
 ell_shared = ell/useful.h ell/asn1-private.h
 
src/netconfig.c +359 -1283

1,963 lines not on this page · raw message

src/netconfig.h +1 -0
index c9ac6f8f..b42e9cc8 100644
@@ -26,6 +26,7 @@ struct ie_fils_ip_addr_response_info;
 
 enum netconfig_event {
 	NETCONFIG_EVENT_CONNECTED,
+	NETCONFIG_EVENT_FAILED,
 };
 
 typedef void (*netconfig_notify_func_t)(enum netconfig_event event,
src/station.c +49 -39

112 lines not on this page · raw message

Signature · 1 line
2.34.1