Skip to contentSkip to conversation

target/ppc: avoid int32 multiply overflow in int_helper.c

PATCH Applied Daniel Henrique Barboza 3 participants 4 messages Jun 2, 2022 – Jun 6, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/ppc: avoid int32 multiply overflow in int_helper.c

Coverity is not thrilled about the multiply operations being done in ger_rank8() and ger_rank2(), giving an error like the following:

Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Potentially overflowing expression "sextract32(a, 4 * i, 4) *
sextract32(b, 4 * i, 4)" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "int64_t" (64 bits, signed).

Fix both instances where this occur by adding an int64_t cast in the first operand, forcing the result to be 64 bit.

Fixes Coverity CID 1489444, 1489443
Fixes 345531533f26 ("target/ppc: Implemented xvi*ger* instructions")
Cc Lucas Mateus Castro (alqotel) <[email protected]>
Cc Richard Henderson <[email protected]>
---
 target/ppc/int_helper.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
target/ppc/int_helper.c +3 -2
index 105b626d1b..eb65ab4d82 100644
@@ -789,7 +789,7 @@ static int64_t ger_rank8(uint32_t a, uint32_t b, uint32_t mask)
     int64_t psum = 0;
     for (int i = 0; i < 8; i++, mask >>= 1) {
         if (mask & 1) {
-            psum += sextract32(a, 4 * i, 4) * sextract32(b, 4 * i, 4);
+            psum += (int64_t)sextract32(a, 4 * i, 4) * sextract32(b, 4 * i, 4);
         }
     }
     return psum;
@@ -811,7 +811,8 @@ static int64_t ger_rank2(uint32_t a, uint32_t b, uint32_t mask)
     int64_t psum = 0;
     for (int i = 0; i < 2; i++, mask >>= 1) {
         if (mask & 1) {
-            psum += sextract32(a, 16 * i, 16) * sextract32(b, 16 * i, 16);
+            psum += (int64_t)sextract32(a, 16 * i, 16) *
+                             sextract32(b, 16 * i, 16);
         }
     }
     return psum;
Signature · 1 line
2.36.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Daniel Henrique Barboza

Coverity is not thrilled about the multiply operations being done in ger_rank8() and ger_rank2(), giving an error like the following:

Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Potentially overflowing expression "sextract32(a, 4 * i, 4) *
sextract32(b, 4 * i, 4)" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "int64_t" (64 bits, signed).

Quoted 8 lines

Fix both instances where this occur by adding an int64_t cast in the first operand, forcing the result to be 64 bit.

Fixes Coverity CID 1489444, 1489443
Fixes 345531533f26 ("target/ppc: Implemented xvi*ger* instructions")
Cc Lucas Mateus Castro (alqotel) <[email protected]>
Cc Richard Henderson <[email protected]>

r~

#2 lore raw
In reply to Daniel Henrique Barboza
Quoted 12 lines · Daniel Henrique Barboza

Coverity is not thrilled about the multiply operations being done in ger_rank8() and ger_rank2(), giving an error like the following:

Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Potentially overflowing expression "sextract32(a, 4 * i, 4) *
sextract32(b, 4 * i, 4)" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "int64_t" (64 bits, signed).

Fix both instances where this occur by adding an int64_t cast in the first operand, forcing the result to be 64 bit.

Quoted 6 lines
Fixes Coverity CID 1489444, 1489443
Fixes 345531533f26 ("target/ppc: Implemented xvi*ger* instructions")
Cc Lucas Mateus Castro (alqotel)<[email protected]>
Cc Richard Henderson<[email protected]>

---

Signature · 5 lines
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO <https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
#3 lore raw
In reply to Daniel Henrique Barboza

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,

Daniel

Quoted 44 lines · Daniel Henrique Barboza

Coverity is not thrilled about the multiply operations being done in ger_rank8() and ger_rank2(), giving an error like the following:

Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Potentially overflowing expression "sextract32(a, 4 * i, 4) *
sextract32(b, 4 * i, 4)" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "int64_t" (64 bits, signed).

Fix both instances where this occur by adding an int64_t cast in the first operand, forcing the result to be 64 bit.

Fixes Coverity CID 1489444, 1489443
Fixes 345531533f26 ("target/ppc: Implemented xvi*ger* instructions")
Cc Lucas Mateus Castro (alqotel) <[email protected]>
Cc Richard Henderson <[email protected]>
---
  target/ppc/int_helper.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
target/ppc/int_helper.c +3 -2
index 105b626d1b..eb65ab4d82 100644
@@ -789,7 +789,7 @@ static int64_t ger_rank8(uint32_t a, uint32_t b, uint32_t mask)
      int64_t psum = 0;
      for (int i = 0; i < 8; i++, mask >>= 1) {
          if (mask & 1) {
-            psum += sextract32(a, 4 * i, 4) * sextract32(b, 4 * i, 4);
+            psum += (int64_t)sextract32(a, 4 * i, 4) * sextract32(b, 4 * i, 4);
          }
      }
      return psum;
@@ -811,7 +811,8 @@ static int64_t ger_rank2(uint32_t a, uint32_t b, uint32_t mask)
      int64_t psum = 0;
      for (int i = 0; i < 2; i++, mask >>= 1) {
          if (mask & 1) {
-            psum += sextract32(a, 16 * i, 16) * sextract32(b, 16 * i, 16);
+            psum += (int64_t)sextract32(a, 16 * i, 16) *
+                             sextract32(b, 16 * i, 16);
          }
      }
      return psum;