Skip to contentSkip to conversation

polarfire soc kconfig/maintainers updates

PATCH In review Conor Dooley 4 participants 12 messages May 5, 2022 – Jun 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v4 cover polarfire soc kconfig/maintainers updates

Hey Palmer,

As I said yesterday on IRC, for v4 of this patchset I have removed the kconfig changes, pending deciding on a better/consistent way of using the SOC_FOO symbols in kconfig.socs.
The only remaining patch in this set is now the MAINTAINERS update which was patch 4/4 in v3.

Thanks,
Conor.

Conor Dooley (1):
MAINTAINERS: add polarfire rng, pci and clock drivers

 MAINTAINERS | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.35.2
#1 lore raw

PATCH v4 1/1 MAINTAINERS: add polarfire rng, pci and clock drivers

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

---
 MAINTAINERS | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +4 -1
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N:	riscv
 K:	riscv
 
 RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
-M:	Lewis Hanly <[email protected]>
 M:	Conor Dooley <[email protected]>
+M:	Daire McNamara <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	arch/riscv/boot/dts/microchip/
+F:	drivers/char/hw_random/mpfs-rng.c
+F:	drivers/clk/microchip/clk-mpfs.c
 F:	drivers/mailbox/mailbox-mpfs.c
+F:	drivers/pci/controller/pcie-microchip-host.c
 F:	drivers/soc/microchip/
 F:	include/soc/microchip/mpfs.h
 
Signature · 1 line
2.35.2
#2 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)
Thanks,
Conor.

Quoted 25 lines
---
  MAINTAINERS | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +4 -1
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N:	riscv
  K:	riscv
 
  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
-M:	Lewis Hanly <[email protected]>
  M:	Conor Dooley <[email protected]>
+M:	Daire McNamara <[email protected]>
  L:	[email protected]
  S:	Supported
  F:	arch/riscv/boot/dts/microchip/
+F:	drivers/char/hw_random/mpfs-rng.c
+F:	drivers/clk/microchip/clk-mpfs.c
  F:	drivers/mailbox/mailbox-mpfs.c
+F:	drivers/pci/controller/pcie-microchip-host.c
  F:	drivers/soc/microchip/
  F:	include/soc/microchip/mpfs.h
 
#3 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 10 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)

Sorry, I didn't realize this was aimed at the RISC-V tree. I'm fine taking it, but it seems like these should have gone in along with the drivers.

Arnd: maybe this is really an SOC tree sort of thing? No big deal either way on my end, just let me know.

Quoted 29 lines

Thanks,
Conor.

Quoted 25 lines
---
  MAINTAINERS | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +4 -1
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N:	riscv
  K:	riscv
 
  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
-M:	Lewis Hanly <[email protected]>
  M:	Conor Dooley <[email protected]>
+M:	Daire McNamara <[email protected]>
  L:	[email protected]
  S:	Supported
  F:	arch/riscv/boot/dts/microchip/
+F:	drivers/char/hw_random/mpfs-rng.c
+F:	drivers/clk/microchip/clk-mpfs.c
  F:	drivers/mailbox/mailbox-mpfs.c
+F:	drivers/pci/controller/pcie-microchip-host.c
  F:	drivers/soc/microchip/
  F:	include/soc/microchip/mpfs.h
 
#4 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 9 lines · Palmer Dabbelt

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 6 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 5 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Hey Palmer,
I know youre busy etc but just a reminder :)

Sorry, I didn't realize this was aimed at the RISC-V tree.  I'm fine taking it, but it seems like these should have gone in along with the drivers.

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

Quoted 33 lines

Arnd: maybe this is really an SOC tree sort of thing?  No big deal either way on my end, just let me know.

Quoted 29 lines

Thanks,
Conor.

Quoted 25 lines

---
  MAINTAINERS | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N: riscv

  K: riscv

  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT -M:  Lewis Hanly <[email protected]>
  M: Conor Dooley <[email protected]> +M:  Daire McNamara <[email protected]>
  L: [email protected]
  S: Supported
  F: arch/riscv/boot/dts/microchip/

MAINTAINERS +2 -0
+F:  drivers/char/hw_random/mpfs-rng.c
+F:  drivers/clk/microchip/clk-mpfs.c

  F: drivers/mailbox/mailbox-mpfs.c
+F:  drivers/pci/controller/pcie-microchip-host.c
  F: drivers/soc/microchip/
  F: include/soc/microchip/mpfs.h

#5 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 15 lines · On Mon, 23 May 2022 13:00:01 PDT (-0700), [email protected] wrote:
Quoted 14 lines · Palmer Dabbelt

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 10 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)

Quoted 7 lines
Quoted 3 lines

Sorry, I didn't realize this was aimed at the RISC-V tree.  I'm fine taking it, but it seems like these should have gone in along with the drivers.

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

Sorry if I'm being overly pedantic about this one...

Quoted 35 lines
Quoted 34 lines

Arnd: maybe this is really an SOC tree sort of thing?  No big deal either way on my end, just let me know.

Quoted 29 lines

Thanks,
Conor.

Quoted 25 lines

---
  MAINTAINERS | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N: riscv

  K: riscv

  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT -M:  Lewis Hanly <[email protected]>
  M: Conor Dooley <[email protected]> +M:  Daire McNamara <[email protected]>
  L: [email protected]
  S: Supported
  F: arch/riscv/boot/dts/microchip/

MAINTAINERS +2 -0
+F:  drivers/char/hw_random/mpfs-rng.c
+F:  drivers/clk/microchip/clk-mpfs.c

  F: drivers/mailbox/mailbox-mpfs.c
+F:  drivers/pci/controller/pcie-microchip-host.c
  F: drivers/soc/microchip/
  F: include/soc/microchip/mpfs.h

#6 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 26 lines · Palmer Dabbelt

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 15 lines · On Mon, 23 May 2022 13:00:01 PDT (-0700), [email protected] wrote:
Quoted 14 lines · Palmer Dabbelt

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 10 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)

Quoted 7 lines
Quoted 3 lines

Sorry, I didn't realize this was aimed at the RISC-V tree. I'm fine taking it, but it seems like these should have gone in along with the drivers.

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

Quoted 6 lines

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

Sorry if I'm being overly pedantic about this one...

I don't mind. Maybe this should go via Andrew next cycle or w/e? There's obviously no hurry etc

Quoted 42 lines
Quoted 20 lines
Quoted 20 lines

Arnd: maybe this is really an SOC tree sort of thing? No big deal either way on my end, just let me know.

Quoted 14 lines

Thanks,
Conor.

Quoted 11 lines
---
  MAINTAINERS | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N: riscv
  K: riscv
 
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
MAINTAINERS +1 -1
  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT
-M:  Lewis Hanly <[email protected]>
  M: Conor Dooley <[email protected]>
+M:  Daire McNamara <[email protected]>
  L: [email protected]
  S: Supported
  F: arch/riscv/boot/dts/microchip/
Quoted 8 lines
Quoted 8 lines

MAINTAINERS N: riscv · line 16953

Quoted 7 lines
MAINTAINERS +3 -0
+F:  drivers/char/hw_random/mpfs-rng.c
+F:  drivers/clk/microchip/clk-mpfs.c
  F: drivers/mailbox/mailbox-mpfs.c
+F:  drivers/pci/controller/pcie-microchip-host.c
  F: drivers/soc/microchip/
  F: include/soc/microchip/mpfs.h
 

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#7 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 11 lines · On Thu, Jun 02, 2022 at 04:39:08AM +0000, [email protected] wrote:
Quoted 6 lines · Palmer Dabbelt

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

Sorry if I'm being overly pedantic about this one...

I don't mind. Maybe this should go via Andrew next cycle or w/e? There's obviously no hurry etc

My turn to be overly pedantic :) IMHO there's no benefit in delaying MAINTAINERS updates. There's zero risk, and delaying only means people will miss out on bug reports and other things they should learn about.

Bjorn

#8 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 10 lines · On Thu, 02 Jun 2022 09:31:52 PDT (-0700), [email protected] wrote:
Quoted 9 lines · On Thu, Jun 02, 2022 at 04:39:08AM +0000, [email protected] wrote:
Quoted 6 lines · Palmer Dabbelt

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

Sorry if I'm being overly pedantic about this one...

Quoted 7 lines
Quoted 2 lines

I don't mind. Maybe this should go via Andrew next cycle or w/e? There's obviously no hurry etc

My turn to be overly pedantic :) IMHO there's no benefit in delaying MAINTAINERS updates. There's zero risk, and delaying only means people will miss out on bug reports and other things they should learn about.

If by "delay" you mean wait until a merge window, then I definately agree -- that's just more cofusing for folks to have defacto maintainership outside of the tree, might as well get these in. It's not like a MAINTAINERS update is going to introduce a regression or anything.

I'm just delaying because I just want to wait to make sure folks from the subsystems are OK with the updates, as these aren't really anything to do with RISC-V so it's not really my decision to make.

Acked-by
#9 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

In reply to Palmer Dabbelt
Quoted 20 lines · Palmer Dabbelt
Quoted 19 lines · On Mon, 23 May 2022 13:00:01 PDT (-0700), [email protected] wrote:
Quoted 17 lines · Palmer Dabbelt

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 10 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)

Sorry, I didn't realize this was aimed at the RISC-V tree.  I'm fine taking it, but it seems like these should have gone in along with the drivers.

Quoted 8 lines
Quoted 3 lines

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

Fine with me, if you want it:

Quoted 33 lines
Quoted 33 lines
Quoted 32 lines

Arnd: maybe this is really an SOC tree sort of thing?  No big deal either way on my end, just let me know.

Quoted 29 lines

Thanks,
Conor.

Quoted 25 lines

---
  MAINTAINERS | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index fd768d43e048..d7602658b0a5 100644
@@ -16939,12 +16939,15 @@ N: riscv

  K: riscv

  RISC-V/MICROCHIP POLARFIRE SOC SUPPORT -M:  Lewis Hanly <[email protected]>
  M: Conor Dooley <[email protected]> +M:  Daire McNamara <[email protected]>
  L: [email protected]
  S: Supported
  F: arch/riscv/boot/dts/microchip/

MAINTAINERS +2 -0
+F:  drivers/char/hw_random/mpfs-rng.c
+F:  drivers/clk/microchip/clk-mpfs.c

  F: drivers/mailbox/mailbox-mpfs.c
+F:  drivers/pci/controller/pcie-microchip-host.c
  F: drivers/soc/microchip/
  F: include/soc/microchip/mpfs.h

maintainer Acked-by
#10 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

In reply to Palmer Dabbelt

Quoting Palmer Dabbelt (2022-06-01 18:55:40)

Quoted 20 lines · On Mon, 23 May 2022 13:00:01 PDT (-0700), [email protected] wrote:
Quoted 19 lines · Palmer Dabbelt
Quoted 17 lines

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 10 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 6 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Hey Palmer,
I know youre busy etc but just a reminder :)

Sorry, I didn't realize this was aimed at the RISC-V tree.�� I'm fine taking it, but it seems like these should have gone in along with the drivers.

Quoted 9 lines
Quoted 3 lines

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

#11 lore raw

Re: [PATCH v4 1/1] MAINTAINERS: add polarfire rng, pci and clock drivers

Quoted 25 lines · Stephen Boyd

Quoting Palmer Dabbelt (2022-06-01 18:55:40)

Quoted 24 lines · On Mon, 23 May 2022 13:00:01 PDT (-0700), [email protected] wrote:
Quoted 22 lines · Palmer Dabbelt
Quoted 9 lines

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 6 lines · On Mon, 23 May 2022 04:42:53 PDT (-0700), [email protected] wrote:
Quoted 5 lines · Conor Dooley

Hardware random, PCI and clock drivers for the PolarFire SoC have been upstreamed but are not covered by the MAINTAINERS entry, so add them. Daire is the author of the clock & PCI drivers, so add him as a maintainer in place of Lewis.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Hey Palmer,
I know youre busy etc but just a reminder :)

Sorry, I didn't realize this was aimed at the RISC-V tree.�� I'm fine taking it, but it seems like these should have gone in along with the drivers.

Yeah, sorry. In hindsight it should've but that ship has sailed. I sent the rng bundled this way b/c I didn't want to end up a conflict. Obv. there's not a rush so I can always split it back out if needs be.

Quoted 8 lines
Quoted 5 lines

I'm adding a bunch of subsystem maintainers just to check again. I don't have any problem with it, just not really a RISC-V thing and don't wan to make a mess. I've stashed it over at palmer/pcsoc-maintainers for now.

+CC Herbert for the last one.

This is likely to generate a conflict in -next though b/c my spi driver that was applied for 5.20 also touches this entry. It really pisses me off that I allowed this to happen & become a burden..

What am I "meant" to do here? Do the merges myself & provide the conflict resolution? Or for something as obvious as this is it enough to notify that there will be one?

Sorry,
Conor.