Skip to contentSkip to conversation

soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq

PATCH RESEND Superseded Miaoqian Lin 2 participants 2 messages Jun 3, 2022 Arm/Aspeed machine support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq

platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes 524feb799408 ("soc: add aspeed folder and misc drivers")

---

In previous thread:

---
 drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/aspeed/aspeed-lpc-snoop.c +2 -2
index eceeaf8dfbeb..c4a03b3a5cf8 100644
@@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
 	int rc;
 
 	lpc_snoop->irq = platform_get_irq(pdev, 0);
-	if (!lpc_snoop->irq)
-		return -ENODEV;
+	if (lpc_snoop->irq < 0)
+		return lpc_snoop->irq;
 
 	rc = devm_request_irq(dev, lpc_snoop->irq,
 			      aspeed_lpc_snoop_irq, IRQF_SHARED,
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 11 lines · Miaoqian Lin

platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes 524feb799408 ("soc: add aspeed folder and misc drivers")

That's not the commit that introduced this code, that's simply a commit that moved the drivers.

Quoted 28 lines

---

In previous thread:

---
 drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/aspeed/aspeed-lpc-snoop.c +2 -3
index eceeaf8dfbeb..c4a03b3a5cf8 100644
@@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
        int rc;
 
        lpc_snoop->irq = platform_get_irq(pdev, 0);
-       if (!lpc_snoop->irq)
-               return -ENODEV;
+       if (lpc_snoop->irq < 0)
+               return lpc_snoop->irq;
 
        rc = devm_request_irq(dev, lpc_snoop->irq,
                              aspeed_lpc_snoop_irq, IRQF_SHARED,
--

2.25.1