net: ipa: compute proper aggregation limit
Subsystems (3)
PATCH 1/1 net: ipa: compute proper aggregation limit
commit c5794097b269f15961ed78f7f27b50e51766dec9 upstream.
The aggregation byte limit for an endpoint is currently computed based on the endpoint's receive buffer size.
However, some bytes at the front of each receive buffer are reserved on the assumption that--as with SKBs--it might be useful to insert data (such as headers) before what lands in the buffer.
The aggregation byte limit currently doesn't take into account that reserved space, and as a result, aggregation could require space past that which is available in the buffer.
Fix this by reducing the size used to compute the aggregation byte limit by the NET_SKB_PAD offset reserved for each receive buffer.
---
The original commit doesn't cherry-pick cleanly to v5.10.119. -Alex
drivers/net/ipa/ipa_endpoint.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +3 -1
@@ -610,12 +610,14 @@ static void ipa_endpoint_init_aggr(struct ipa_endpoint *endpoint)if (endpoint->data->aggregation) {if (!endpoint->toward_ipa) { +u32 buffer_size;u32 limit; val |=u32_encode_bits (IPA_ENABLE_AGGR ,AGGR_EN_FMASK ); val |=u32_encode_bits (IPA_GENERIC ,AGGR_TYPE_FMASK ); - limit =ipa_aggr_size_kb (IPA_RX_BUFFER_SIZE ); + buffer_size =IPA_RX_BUFFER_SIZE -NET_SKB_PAD ; + limit =ipa_aggr_size_kb (buffer_size); val |=u32_encode_bits (limit,AGGR_BYTE_LIMIT_FMASK ); limit =IPA_AGGR_TIME_LIMIT_DEFAULT ;
Signature · 1 line
2.32.0
PATCH 1/1 net: ipa: compute proper aggregation limit
commit c5794097b269f15961ed78f7f27b50e51766dec9 upstream.
The aggregation byte limit for an endpoint is currently computed based on the endpoint's receive buffer size.
However, some bytes at the front of each receive buffer are reserved on the assumption that--as with SKBs--it might be useful to insert data (such as headers) before what lands in the buffer.
The aggregation byte limit currently doesn't take into account that reserved space, and as a result, aggregation could require space past that which is available in the buffer.
Fix this by reducing the size used to compute the aggregation byte limit by the NET_SKB_PAD offset reserved for each receive buffer.
---
The original commit doesn't cherry-pick cleanly to v5.15.44 or v5.17.12 -Alex
drivers/net/ipa/ipa_endpoint.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +3 -1
@@ -722,13 +722,15 @@ static void ipa_endpoint_init_aggr(struct ipa_endpoint *endpoint)if (endpoint->data->aggregation) {if (!endpoint->toward_ipa) { +u32 buffer_size;bool close_eof;u32 limit; val |=u32_encode_bits (IPA_ENABLE_AGGR ,AGGR_EN_FMASK ); val |=u32_encode_bits (IPA_GENERIC ,AGGR_TYPE_FMASK ); - limit =ipa_aggr_size_kb (IPA_RX_BUFFER_SIZE ); + buffer_size =IPA_RX_BUFFER_SIZE -NET_SKB_PAD ; + limit =ipa_aggr_size_kb (buffer_size); val |=aggr_byte_limit_encoded (version, limit); limit =IPA_AGGR_TIME_LIMIT ;
Signature · 1 line
2.32.0
PATCH 1/1 net: ipa: compute proper aggregation limit
In reply to Alex Eldercommit c5794097b269f15961ed78f7f27b50e51766dec9 upstream.
The aggregation byte limit for an endpoint is currently computed based on the endpoint's receive buffer size.
However, some bytes at the front of each receive buffer are reserved on the assumption that--as with SKBs--it might be useful to insert data (such as headers) before what lands in the buffer.
The aggregation byte limit currently doesn't take into account that reserved space, and as a result, aggregation could require space past that which is available in the buffer.
Fix this by reducing the size used to compute the aggregation byte limit by the NET_SKB_PAD offset reserved for each receive buffer.
---
The original commit *does* cleanly cherry-pick onto v5.18.1. -Alex
drivers/net/ipa/ipa_endpoint.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/ipa/ipa_endpoint.c +6 -3
@@ -130,9 +130,10 @@ static bool ipa_endpoint_data_valid_one(struct ipa *ipa, u32 count,*/ if (data->endpoint.config.aggregation) { limit +=SZ_1K *aggr_byte_limit_max (ipa->version); -if (buffer_size > limit) { +if (buffer_size -NET_SKB_PAD > limit) {dev_err (dev,"RX buffer size too large for aggregated RX endpoint %u (%u > %u)\n" , - data->endpoint_id, buffer_size, limit); + data->endpoint_id, + buffer_size -NET_SKB_PAD , limit);return false; }
@@ -739,6 +740,7 @@ static void ipa_endpoint_init_aggr(struct ipa_endpoint *endpoint)if (endpoint->data->aggregation) {if (!endpoint->toward_ipa) {const struct ipa_endpoint_rx_data *rx_data; +u32 buffer_size;bool close_eof;u32 limit;
@@ -746,7 +748,8 @@ static void ipa_endpoint_init_aggr(struct ipa_endpoint *endpoint) val |=u32_encode_bits (IPA_ENABLE_AGGR ,AGGR_EN_FMASK ); val |=u32_encode_bits (IPA_GENERIC ,AGGR_TYPE_FMASK ); - limit =ipa_aggr_size_kb (rx_data->buffer_size); + buffer_size = rx_data->buffer_size; + limit =ipa_aggr_size_kb (buffer_size -NET_SKB_PAD ); val |=aggr_byte_limit_encoded (version, limit); limit =IPA_AGGR_TIME_LIMIT ;
Signature · 1 line
2.32.0
Greg KH
maintainerQuoted 16 lines · Alex Elder
commit
c5794097b269f15961ed78f7f27b50e51766dec9upstream.The aggregation byte limit for an endpoint is currently computed based on the endpoint's receive buffer size.
However, some bytes at the front of each receive buffer are reserved on the assumption that--as with SKBs--it might be useful to insert data (such as headers) before what lands in the buffer.
The aggregation byte limit currently doesn't take into account that reserved space, and as a result, aggregation could require space past that which is available in the buffer.
Fix this by reducing the size used to compute the aggregation byte limit by the
NET_SKB_PADoffset reserved for each receive buffer.
Quoted 6 lines
Cc <[email protected]> # 5.10.xFixes 84f9bd12d46db ("soc: qcom: ipa: IPA endpoints");Signed-off-by Alex Elder <[email protected]>Signed-off-by David S. Miller <[email protected]>---
The original commit doesn't cherry-pick cleanly to v5.10.119. -Alex
All now queued up, thanks.
greg k-h