phy: ti: j721e-wiz: Fix refcount leak in wiz_get_lane_phy_types
PATCH v2 1/1 phy: ti: j721e-wiz: Fix refcount leak in wiz_get_lane_phy_types
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Fixes 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
Signed-off-by Miaoqian Lin <[email protected]>
---
changes in v2:
- update Fixes tag.
v1 Link: https://lore.kernel.org/r/[email protected]
--- drivers/phy/ti/phy-j721e-wiz.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/phy/ti/phy-j721e-wiz.c +2 -0
@@ -1113,6 +1113,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz) ret =of_property_read_u32 (subnode,"reg" , ®);if (ret) {of_node_put (subnode); +of_node_put (serdes);dev_err (dev,"%s: Reading \"reg\" from \"%s\" failed: %d\n" , __func__, subnode->name, ret);
@@ -1127,6 +1128,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)for (i = reg; i < reg + num_lanes; i++) wiz->lane_phy_type[i] = phy_type; } +of_node_put (serdes);return 0 ; }
Signature · 7 lines
2.25.1 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy