PCI: brcmstb: Fix refcount leak in brcm_pcie_probe
Subsystems (5)
PATCH v2 1/1 PCI: brcmstb: Fix refcount leak in brcm_pcie_probe
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
---
changes in v2:
- update Fixes tag.
v1 Link: https://lore.kernel.org/r/[email protected]
--- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pci/controller/pcie-brcmstb.c +2 -0
@@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret =brcm_pcie_enable_msi (pcie);if (ret) {dev_err (pcie->dev,"probe of internal MSI failed" ); +of_node_put (msi_np); goto fail; } +of_node_put (msi_np); } bridge->ops = pcie->type ==BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;
Signature · 1 line
2.25.1
Quoted 7 lines · Miaoqian Lin
of_parse_phandle()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 40ca1bf580ef ("PCI: brcmstb: Add MSI support")Signed-off-by Miaoqian Lin <[email protected]>
Quoted 7 lines
---
changes in v2:
- update Fixes tag.
v1 Link: https://lore.kernel.org/r/[email protected]--- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 6 lines · Miaoqian Lin
of_parse_phandle()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 40ca1bf580ef ("PCI: brcmstb: Add MSI support")Signed-off-by Miaoqian Lin <[email protected]>
Applied with Rob's reviewed-by to pci/ctrl/brcmstb for v5.20, thanks!
Quoted 31 lines
---
changes in v2:
- update Fixes tag.
v1 Link: https://lore.kernel.org/r/[email protected]--- drivers/pci/controller/pcie-brcmstb.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/pcie-brcmstb.c +2
-0@@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret =brcm_pcie_enable_msi (pcie);if (ret) {dev_err (pcie->dev,"probe of internal MSI failed" ); +of_node_put (msi_np); goto fail; } +of_node_put (msi_np); } bridge->ops = pcie->type ==BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops;Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel