manuals: SYSTEMD_SERVICE allows multiple services
PATCH 1/2 manuals: SYSTEMD_SERVICE allows multiple services
State that SYSTEMD_SERVICE allows for multiple space separated systemd services
--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)
documentation/ref-manual/variables.rst +2 -0
@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified with each one separated by a space. + When you specify this file in your recipe, use a package name override to indicate the package to which the value applies. Here is an example from the connman recipe::
Signature · 1 line
2.25.1
PATCH 2/2 manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES
Add detail that package overrides are only available if specified in SYSTEMD_PACKAGES.
--- documentation/ref-manual/variables.rst | 4 ++++ 1 file changed, 4 insertions(+)
documentation/ref-manual/variables.rst +4 -0
@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents. SYSTEMD_SERVICE:${PN} = "connman.service" + The package overrides that can be specified are directly related to the value of + term: SYSTEMD_PACKAGES. Overrides not included in term: SYSTEMD_PACKAGES + will be silently ignored. + :term:`SYSVINIT_ENABLED_GETTYS` When using :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
Signature · 1 line
2.25.1
Re: [yocto] [PATCH 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES
Hi again Paulo,
Quoted 11 lines · Paulo Neves
Add detail that package overrides are only available if specified in
SYSTEMD_PACKAGES.--- documentation/ref-manual/variables.rst | 4 ++++ 1 file changed, 4 insertions(+)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7669
Quoted 6 lines
documentation/ref-manual/variables.rst +3
-0@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents. SYSTEMD_SERVICE:${PN} = "connman.service" + The package overrides that can be specified are directly related to the value of + term: SYSTEMD_PACKAGES. Overrides not included in term: SYSTEMD_PACKAGES + will be silently ignored.
You should use instead:
:term:SYSTEMD_PACKAGES
Would you mind sending an update to [email protected] with your "Signed-off-by" information, please?
Thanks in advance
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Paulo
Thanks for the patches!
Quoted 11 lines · Paulo Neves
State that
SYSTEMD_SERVICEallows for multiple space separated systemd services--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7659
Quoted 4 lines
documentation/ref-manual/variables.rst +1
-0@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified with each one separated by a space.
I'd propose a slightly simpler sentence:
"... can be specified, each one separated ..."
Would you mind sending the patch again to [email protected], and this time with "Signed-off-by" information (from "git commit -s"), please?
I was going to accept your patch directly, but this is required.
Thanks in advance
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi again Paulo and developers,
Quoted 11 lines · Paulo Neves
State that
SYSTEMD_SERVICEallows for multiple space separated systemd services--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7659
Quoted 4 lines
documentation/ref-manual/variables.rst +1
-0@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified with each one separated by a space.
Wouldn't it make more sense to call the variable "SYSTEMD_SERVICES" instead? We could add a new variable and deprecate the old one.
What do you think? Would it be worth the trouble?
Cheers
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
I think so, given we have a deprecation mechanism enforced in code.
The confusion definitely came up, and this is why a documentation clarification was needed.
Paulo Neves
Quoted 27 lines · Michael Opdenacker
Hi again Paulo and developers,
Quoted 11 lines · Paulo Neves
State that
SYSTEMD_SERVICEallows for multiple space separated systemd services--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)documentation/ref-manual/variables.rst +0
-0documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7659
Quoted 4 lines
documentation/ref-manual/variables.rst +1
-0@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified with each one separated by a space.Wouldn't it make more sense to call the variable "
SYSTEMD_SERVICES" instead? We could add a new variable and deprecate the old one.What do you think? Would it be worth the trouble?
Cheers
Michael.
Hi Paulo
Quoted 3 lines · Paulo Neves
I think so, given we have a deprecation mechanism enforced in code. The confusion definitely came up, and this is why a documentation clarification was needed.
That's done on the documentation side. Then, what about proposing a patch to openembedded-core to introduce a new SYSTEMD_SERVICES variable and deprecate SYSTEMD_SERVICE?
Cheers
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/2 manuals: SYSTEMD_SERVICE allows multiple services
In reply to Paulo NevesState that SYSTEMD_SERVICE allows for multiple space separated systemd services
--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)
documentation/ref-manual/variables.rst +2 -0
@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified, each one separated by a space. + When you specify this file in your recipe, use a package name override to indicate the package to which the value applies. Here is an example from the connman recipe::
Signature · 1 line
2.25.1
PATCH v2 2/2 manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES
Add detail that package overrides are only available if specified in SYSTEMD_PACKAGES.
--- documentation/ref-manual/variables.rst | 4 ++++ 1 file changed, 4 insertions(+)
documentation/ref-manual/variables.rst +4 -0
@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents. SYSTEMD_SERVICE:${PN} = "connman.service" + The package overrides that can be specified are directly related to the value of + term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES` + will be silently ignored. + :term:`SYSVINIT_ENABLED_GETTYS` When using :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
Signature · 1 line
2.25.1
Re: [yocto] [PATCH v2 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES
Hi Paulo
Quoted 13 lines · Paulo Neves
Add detail that package overrides are only available if specified in
SYSTEMD_PACKAGES.Signed-off-by Paulo Neves <[email protected]>--- documentation/ref-manual/variables.rst | 4 ++++ 1 file changed, 4 insertions(+)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7673
Quoted 10 lines
documentation/ref-manual/variables.rst +4
-0@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents. SYSTEMD_SERVICE:${PN} = "connman.service" + The package overrides that can be specified are directly related to the value of + term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES` + will be silently ignored. + :term:`SYSVINIT_ENABLED_GETTYS` When using :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
Thanks for the patch. Merged into yocto-docs' master-next
Don't forget to copy the [email protected] mailing list next time.
Thanks again
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [yocto] [PATCH v2 2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES
Hi Michael,
My sincere apologies. Will try to improve next time
Paulo Neves
Quoted 34 lines · Michael Opdenacker
Hi Paulo
Quoted 13 lines · Paulo Neves
Add detail that package overrides are only available if specified in
SYSTEMD_PACKAGES.Signed-off-by Paulo Neves <[email protected]>--- documentation/ref-manual/variables.rst | 4 ++++ 1 file changed, 4 insertions(+)documentation/ref-manual/variables.rst +0
-0documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7673
Quoted 10 lines
documentation/ref-manual/variables.rst +4
-0@@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents. SYSTEMD_SERVICE:${PN} = "connman.service" + The package overrides that can be specified are directly related to the value of + term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES` + will be silently ignored. + :term:`SYSVINIT_ENABLED_GETTYS` When using :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,Thanks for the patch. Merged into yocto-docs' master-next
Don't forget to copy the [email protected] mailing list next time.
Thanks again
Michael.
Michael Opdenacker
AppliedQuoted 13 lines · Paulo Neves
State that
SYSTEMD_SERVICEallows for multiple space separated systemd servicesSigned-off-by Paulo Neves <[email protected]>--- documentation/ref-manual/variables.rst | 2 ++ 1 file changed, 2 insertions(+)documentation/ref-manual/variables.rst +0
-0
documentation/ref-manual/variables.rst system and gives an overview of their function and contents. · line 7663
Quoted 8 lines
documentation/ref-manual/variables.rst +2
-0@@ -7656,6 +7656,8 @@ system and gives an overview of their function and contents. When inheriting the :ref:`systemd <ref-classes-systemd>` class, this variable specifies the systemd service name for a package. + Multiple services can be specified, each one separated by a space. + When you specify this file in your recipe, use a package name override to indicate the package to which the value applies. Here is an example from the connman recipe::
Merged into master-next too.
Thanks!
Michael.
Signature · 3 lines
Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com