Skip to contentSkip to conversation

Remove outdated meta-rust dependency text in README

PATCH In review Federico Pellegrin 2 participants 3 messages Jun 4, 2022 – Jun 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove outdated meta-rust dependency text in README

Since ~16 months the base of meta-rust was merged into meta-oe, down to honister as far as I can see, and therefore the indications to use meta-rust are really not needed and may just create extra work and possibly problems to users.

---
 README | 12 ------------
 1 file changed, 12 deletions(-)
README +0 -12
index 081669f..a9b3600 100644
@@ -62,18 +62,6 @@ other layers needed. e.g.:
     /path/to/meta-openembedded/meta-networking \
     /path/to/layer/meta-security "
 
-Optional Rust dependancy
-======================================
-If you want to use the latest Suricata that needs rust, you will need to clone
-
-  URI: https://github.com/meta-rust/meta-rust.git
-  branch: master
-
-  BBLAYERS += "/path/to/layer/meta-rust"
-
-This will activate the dynamic-layer mechanism and pull in the newer suricata
-
-
 
 Maintenance
 ======================================
Signature · 1 line
2.34.3
#1 lore raw
Quoted 13 lines · Federico Pellegrin

Since ~16 months the base of meta-rust was merged into meta-oe, down to honister as far as I can see, and therefore the indications to use meta-rust are really not needed and may just create extra work and possibly problems to users.

---
  README | 12 ------------
  1 file changed, 12 deletions(-)
README +0 -0
index 081669f..a9b3600 100644

README other layers needed. e.g.: · line 63

Quoted 2 lines
README +0 -0
@@ -62,18 +62,6 @@ other layers needed. e.g.:
      /path/to/meta-openembedded/meta-networking \
      /path/to/layer/meta-security "

thanks for the patch.

did I miss some rust changes in https://git.yoctoproject.org/meta-security/commit/?h=master-next&id=edf8b109e77f6d3f2740e09bdc89f0aaf2885dc4 ?

- armin

Quoted 16 lines
README +0 -12
-Optional Rust dependancy
-======================================
-If you want to use the latest Suricata that needs rust, you will need to clone
-
-  URI: https://github.com/meta-rust/meta-rust.git
-  branch: master
-
-  BBLAYERS += "/path/to/layer/meta-rust"
-
-This will activate the dynamic-layer mechanism and pull in the newer suricata
-
-
 
  Maintenance
  ======================================
#2 lore raw

Hi Armin,
Sorry if it was unclear or if I misunderstood something.

As far as I could see and tried as I had to build it yesterday, I can now build suricata without adding meta-rust as the rust support (compilers etc) is now already in oe-core, ie:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/rust
and
https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/cargo
Some relevant discussion: https://github.com/meta-rust/meta-rust/pull/364

The note in README may still just apply to versions < honister I believe (ie. dunfell is the only not EOL-ed). For more recent versions it may just potentially create confusion IMO.

Cheers,
Federico

Il giorno dom 5 giu 2022 alle ore 00:58 akuster808 <[email protected]> ha scritto:

Quoted 47 lines · Federico Pellegrin
Quoted 13 lines

Since ~16 months the base of meta-rust was merged into meta-oe, down to honister as far as I can see, and therefore the indications to use meta-rust are really not needed and may just create extra work and possibly problems to users.

---
  README | 12 ------------
  1 file changed, 12 deletions(-)
README +0 -0
index 081669f..a9b3600 100644

README other layers needed. e.g.: · line 63

Quoted 2 lines
README +0 -0
@@ -62,18 +62,6 @@ other layers needed. e.g.:
      /path/to/meta-openembedded/meta-networking \
      /path/to/layer/meta-security "

thanks for the patch.

did I miss some rust changes in

https://git.yoctoproject.org/meta-security/commit/?h=master-next&id=edf8b109e77f6d3f2740e09bdc89f0aaf2885dc4
?

- armin

README other layers needed. e.g.:

Quoted 4 lines
README +0 -3
-Optional Rust dependancy
-======================================
-If you want to use the latest Suricata that needs rust, you will need

to clone

README other layers needed. e.g.:

Quoted 7 lines
README +0 -7
-
-  URI: https://github.com/meta-rust/meta-rust.git
-  branch: master
-
-  BBLAYERS += "/path/to/layer/meta-rust"
-
-This will activate the dynamic-layer mechanism and pull in the newer

suricata

Quoted 5 lines
README +0 -2
-
-
 
  Maintenance
  ======================================