Skip to contentSkip to conversation

arm64: dts: imx8mn-bsh-smm-s2/pro: Add pmic clock connection

PATCH In review Michael Trimarchi 1 participant 2 messages Jun 4, 2022 – Jun 5, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mn-bsh-smm-s2/pro: Add pmic clock connection

pmic clock is connected to svns_rtc using RTC_XTALI pin, and wifi/bluetooth chipset

---
 .../boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi     | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi +9 -0
index c11895d9d582..a21ec0d1d003 100644
@@ -28,6 +28,8 @@ usdhc2_pwrseq: usdhc2-pwrseq {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_usdhc2_pwrseq>;
 		reset-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
+		clocks = <&bd71847>;
+		clock-names = "ext_clock";
 	};
 };
 
@@ -214,6 +216,11 @@ &i2c4 {
 	status = "okay";
 };
 
+&snvs_rtc {
+	clocks = <&bd71847>;
+	clock-names = "snvs-rtc";
+};
+
 &uart2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart2>;
@@ -235,6 +242,8 @@ bluetooth {
 		shutdown-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
 		device-wakeup-gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>;
 		host-wakeup-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+		clocks = <&bd71847>;
+		clock-names = "lpo";
 		max-speed = <3000000>;
 	};
 };
Signature · 1 line
2.25.1
#1 lore raw

Hi

I have some problems here. Open to suggestion:

Quoted 35 lines · Michael Trimarchi

pmic clock is connected to svns_rtc using RTC_XTALI pin, and wifi/bluetooth chipset

---
 .../boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi     | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi +7 -0
index c11895d9d582..a21ec0d1d003 100644
@@ -28,6 +28,8 @@ usdhc2_pwrseq: usdhc2-pwrseq {
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_usdhc2_pwrseq>;
                reset-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
+               clocks = <&bd71847>;
+               clock-names = "ext_clock";
        };
 };
 
@@ -214,6 +216,11 @@ &i2c4 {
        status = "okay";
 };
 
+&snvs_rtc {
+       clocks = <&bd71847>;
+       clock-names = "snvs-rtc";
+};
+
 &uart2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_uart2>;

arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi bluetooth { · line 249

Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi +2 -0
@@ -235,6 +242,8 @@ bluetooth {
                shutdown-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
                device-wakeup-gpios = <&gpio1 18 GPIO_ACTIVE_HIGH>;
                host-wakeup-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+               clocks = <&bd71847>;
+               clock-names = "lpo";
                max-speed = <3000000>;
        };
 };

I've done more testing in suspend/resume and it can not work. I have modelled differently and extended the svns block to receive an external clock and make it always enabled. The problem here is the cpu takes the clock from the pmic that is enabled by default and the pmic clock even wifi and bluetooth. If I want to register the driver I would like to connect all of them but it seems that osc_32k is the basic clock of the cpu and can be modelled using pmic easily. Even I have created the ext clock on the snvs block so should be always enabled suspend/resume. The device can not resume from suspend.

Michael

Quoted 3 lines

--
2.25.1

Signature · 11 lines
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com