Skip to contentSkip to conversation

regulator: qcom_smd: add get_voltage to MP5496

PATCH In review Robert Marko 2 participants 5 messages Jun 4, 2022 – Jun 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 regulator: qcom_smd: add get_voltage to MP5496

Add the get_voltage OP to MP5496 ops using the generic rpm_reg_get_voltage.

---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/qcom_smd-regulator.c +1 -0
index 8490aa8eecb1..5ec68250e79d 100644
@@ -205,6 +205,7 @@ static const struct regulator_ops rpm_mp5496_ops = {
 	.is_enabled = rpm_reg_is_enabled,
 	.list_voltage = regulator_list_voltage_linear_range,
 
+	.get_voltage = rpm_reg_get_voltage,
 	.set_voltage = rpm_reg_set_voltage,
 };
 
Signature · 1 line
2.36.1
#1 lore raw

PATCH 2/2 regulator: qcom_smd: correct MP5496 ranges

Currently set MP5496 Buck and LDO ranges dont match its datasheet[1]. According to the datasheet:
Buck range is 0.6-2.1875V with a 12.5mV step
LDO range is 0.8-3.975V with a 25mV step.

So, correct the ranges according to the datasheet[1].

[1] https://www.monolithicpower.com/en/documentview/productdocument/index/version/2/document_type/Datasheet/lang/en/sku/MP5496GR/document_id/6906/

---
 drivers/regulator/qcom_smd-regulator.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/regulator/qcom_smd-regulator.c +4 -4
index 5ec68250e79d..6c69359b3ef2 100644
@@ -724,19 +724,19 @@ static const struct regulator_desc pms405_pldo600 = {
 
 static const struct regulator_desc mp5496_smpa2 = {
 	.linear_ranges = (struct linear_range[]) {
-		REGULATOR_LINEAR_RANGE(725000, 0, 27, 12500),
+		REGULATOR_LINEAR_RANGE(600000, 0, 127, 12500),
 	},
 	.n_linear_ranges = 1,
-	.n_voltages = 28,
+	.n_voltages = 128,
 	.ops = &rpm_mp5496_ops,
 };
 
 static const struct regulator_desc mp5496_ldoa2 = {
 	.linear_ranges = (struct linear_range[]) {
-		REGULATOR_LINEAR_RANGE(1800000, 0, 60, 25000),
+		REGULATOR_LINEAR_RANGE(800000, 0, 127, 25000),
 	},
 	.n_linear_ranges = 1,
-	.n_voltages = 61,
+	.n_voltages = 128,
 	.ops = &rpm_mp5496_ops,
 };
 
Signature · 1 line
2.36.1
maintainer
#2 lore raw

Re: [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges

Quoted 4 lines · Robert Marko

Currently set MP5496 Buck and LDO ranges dont match its datasheet[1]. According to the datasheet:
Buck range is 0.6-2.1875V with a 12.5mV step
LDO range is 0.8-3.975V with a 25mV step.

Doesn't make much difference here but in general fixes like this should come before new features in a series so they can be applied without dependency issues.

#3 lore raw

Re: [PATCH 2/2] regulator: qcom_smd: correct MP5496 ranges

Quoted 10 lines · Mark Brown
Quoted 4 lines · Robert Marko

Currently set MP5496 Buck and LDO ranges dont match its datasheet[1]. According to the datasheet:
Buck range is 0.6-2.1875V with a 12.5mV step
LDO range is 0.8-3.975V with a 25mV step.

Doesn't make much difference here but in general fixes like this should come before new features in a series so they can be applied without dependency issues.

Will do it next time, thanks for the heads up.

Regards,
Robert

maintainer
#4 lore raw
In reply to Robert Marko
Quoted 3 lines · Robert Marko

Add the get_voltage OP to MP5496 ops using the generic rpm_reg_get_voltage.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: qcom_smd: add get_voltage to MP5496

      commit: f210f387c8c05ae0bd5312b8b6b85398c20b94f9
[2/2] regulator: qcom_smd: correct MP5496 ranges
      commit: 122e951eb8045338089b086c8bd9b0b9afb04a92

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark