Bluetooth: btbcm: Fix refcount leak in btbcm_get_board_name
PATCH 1/1 Bluetooth: btbcm: Fix refcount leak in btbcm_get_board_name
of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.
--- drivers/bluetooth/btbcm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/bluetooth/btbcm.c +3 -1
@@ -495,8 +495,10 @@ static const char *btbcm_get_board_name(struct device *dev)if (!root)return NULL ; -if (of_property_read_string_index (root,"compatible" ,0 , &tmp)) +if (of_property_read_string_index (root,"compatible" ,0 , &tmp)) { +of_node_put (root);return NULL ; + }/* get rid of any '/' in the compatible string */ len =strlen (tmp) +1 ;
Signature · 1 line
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=647420
---Test result---
Test Summary:
CheckPatch PASS 1.58 seconds GitLint PASS 0.95 seconds SubjectPrefix PASS 0.92 seconds BuildKernel PASS 32.38 seconds BuildKernel32 PASS 28.97 seconds Incremental Build with patchesPASS 39.52 seconds TestRunner: Setup PASS 478.23 seconds TestRunner: l2cap-tester PASS 17.54 seconds TestRunner: bnep-tester PASS 6.12 seconds TestRunner: mgmt-tester PASS 102.36 seconds TestRunner: rfcomm-tester PASS 9.75 seconds TestRunner: sco-tester PASS 9.53 seconds TestRunner: smp-tester PASS 9.60 seconds TestRunner: userchan-tester PASS 6.45 seconds
---
Regards,
Linux Bluetooth
Quoted 6 lines · Miaoqian Lin
of_find_node_by_path()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore.
Add missingof_node_put()in the error path to avoid refcount leak.Fixes 63fac3343b99 ("Bluetooth: btbcm: Support per-board firmware variants")Signed-off-by Miaoqian Lin <[email protected]>
Oops thanks!
Yours,
Linus Walleij