arm64: dts: qcom: Get rid of some warnings

PATCH Applied Vinod Koul 2 participants 5 messages Jun 6, 2022 – Jul 3, 2022

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support

lore

Share & tools

lore

Vinod Koul

author

2022-06-06 06:50 UTC #0 lore raw

v3 cover arm64: dts: qcom: Get rid of some warnings

This attempts to make W=1 free from warnings for all SM* dts files.

Bunch of these are releated to node not having valid unit address and being present under soc node. So moving it out fixed that. Interconnect node was simple rename to remove unit address which was not really valid for these nodes.

Changes in v3:
- rebase on v5.19-rc1

Changes in v2:
- drop the sound and dsi node changes

*** SUBJECT HERE ***

*** BLURB HERE ***

Vinod Koul (3):
arm64: dts: qcom: sm8450: rename interconnect nodes
arm64: dts: qcom: sm8350: Move qup-opp-tables out of soc node
arm64: dts: qcom: sm8250: Move qup-opp-table out of soc node

 arch/arm64/boot/dts/qcom/sm8250.dtsi | 38 +++++++-------
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 76 ++++++++++++++--------------
 arch/arm64/boot/dts/qcom/sm8450.dtsi |  4 +-
 3 files changed, 59 insertions(+), 59 deletions(-)

Signature · 1 line

2.34.1

Vinod Koul

author

2022-06-06 06:50 UTC #1 lore raw

PATCH v3 1/3 arm64: dts: qcom: sm8450: rename interconnect nodes

clk-virt and mc-virt interconnect nodes were named interconnect@0 and interconnect@1. That is incorrect as we don't have unit addresses 0/1 for these node.

This causes warning:
arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
Warning (unit_address_vs_reg): /interconnect@0:
node has a unit name, but no reg or ranges property
arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4:
Warning (unit_address_vs_reg): /interconnect@1:
node has a unit name, but no reg or ranges property
arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
Warning (unique_unit_address_if_enabled): /interconnect@0:
duplicate unit-address (also used in node /soc@0)

Rename the nodes to interconnect-0 and interconnect-1 to fix the warning.

Signed-off-by Vinod Koul <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/sm8450.dtsi +2 -2

index 7d08fad76371..92887eaabe77 100644
@@ -262,13 +262,13 @@ scm: scm {
 		};
 	};
 
-	clk_virt: interconnect@0 {
+	clk_virt: interconnect-0 {
 		compatible = "qcom,sm8450-clk-virt";
 		#interconnect-cells = <2>;
 		qcom,bcm-voters = <&apps_bcm_voter>;
 	};
 
-	mc_virt: interconnect@1 {
+	mc_virt: interconnect-1 {
 		compatible = "qcom,sm8450-mc-virt";
 		#interconnect-cells = <2>;
 		qcom,bcm-voters = <&apps_bcm_voter>;

Signature · 1 line

2.34.1

Vinod Koul

author

2022-06-06 06:50 UTC #2 lore raw

PATCH v3 2/3 arm64: dts: qcom: sm8350: Move qup-opp-tables out of soc node

In reply to Vinod Koul

The soc node expects all the nodes to have unit addresses. The qup-opp-tables do not have that which causes warnings:

arch/arm64/boot/dts/qcom/sm8350.dtsi:640.46-657.5:

	Warning (simple_bus_reg): /soc@0/qup-100mhz-opp-table:
	missing or empty reg/ranges property
arch/arm64/boot/dts/qcom/sm8350.dtsi:659.46-676.5:
	Warning (simple_bus_reg): /soc@0/qup-120mhz-opp-table:
	missing or empty reg/ranges property

Move the qup-opp-tables out of soc node to fix these warnings

Signed-off-by Vinod Koul <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 76 ++++++++++++++--------------
 1 file changed, 38 insertions(+), 38 deletions(-)

arch/arm64/boot/dts/qcom/sm8350.dtsi +38 ~~-38~~

index 743cba9b683c..310c97323dfc 100644
@@ -341,6 +341,44 @@ CLUSTER_PD: cpu-cluster0 {
 		};
 	};
 
+	qup_opp_table_100mhz: qup-100mhz-opp-table {
+		compatible = "operating-points-v2";
+
+		opp-50000000 {
+			opp-hz = /bits/ 64 <50000000>;
+			required-opps = <&rpmhpd_opp_min_svs>;
+		};
+
+		opp-75000000 {
+			opp-hz = /bits/ 64 <75000000>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+		};
+
+		opp-100000000 {
+			opp-hz = /bits/ 64 <100000000>;
+			required-opps = <&rpmhpd_opp_svs>;
+		};
+	};
+
+	qup_opp_table_120mhz: qup-120mhz-opp-table {
+		compatible = "operating-points-v2";
+
+		opp-50000000 {
+			opp-hz = /bits/ 64 <50000000>;
+			required-opps = <&rpmhpd_opp_min_svs>;
+		};
+
+		opp-75000000 {
+			opp-hz = /bits/ 64 <75000000>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+		};
+
+		opp-120000000 {
+			opp-hz = /bits/ 64 <120000000>;
+			required-opps = <&rpmhpd_opp_svs>;
+		};
+	};
+
 	reserved_memory: reserved-memory {
 		#address-cells = <2>;
 		#size-cells = <2>;

@@ -638,44 +676,6 @@ ipcc: mailbox@408000 {
 			#mbox-cells = <2>;
 		};
 
-		qup_opp_table_100mhz: qup-100mhz-opp-table {
-			compatible = "operating-points-v2";
-
-			opp-50000000 {
-				opp-hz = /bits/ 64 <50000000>;
-				required-opps = <&rpmhpd_opp_min_svs>;
-			};
-
-			opp-75000000 {
-				opp-hz = /bits/ 64 <75000000>;
-				required-opps = <&rpmhpd_opp_low_svs>;
-			};
-
-			opp-100000000 {
-				opp-hz = /bits/ 64 <100000000>;
-				required-opps = <&rpmhpd_opp_svs>;
-			};
-		};
-
-		qup_opp_table_120mhz: qup-120mhz-opp-table {
-			compatible = "operating-points-v2";
-
-			opp-50000000 {
-				opp-hz = /bits/ 64 <50000000>;
-				required-opps = <&rpmhpd_opp_min_svs>;
-			};
-
-			opp-75000000 {
-				opp-hz = /bits/ 64 <75000000>;
-				required-opps = <&rpmhpd_opp_low_svs>;
-			};
-
-			opp-120000000 {
-				opp-hz = /bits/ 64 <120000000>;
-				required-opps = <&rpmhpd_opp_svs>;
-			};
-		};
-
 		gpi_dma2: dma-controller@800000 {
 			compatible = "qcom,sm8350-gpi-dma";
 			reg = <0 0x00800000 0 0x60000>;

Signature · 1 line

2.34.1

Vinod Koul

author

2022-06-06 06:50 UTC #3 lore raw

PATCH v3 3/3 arm64: dts: qcom: sm8250: Move qup-opp-table out of soc node

In reply to Vinod Koul

The soc node expects all the nodes to have unit addresses. The qup-opp-table does not have that which causes warnings:

arch/arm64/boot/dts/qcom/sm8250.dtsi:916.32-933.5:

	Warning (simple_bus_reg): /soc@0/qup-opp-table:
	missing or empty reg/ranges property

Move the qup-opp-table out of soc node to fix these warnings

Signed-off-by Vinod Koul <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 38 ++++++++++++++--------------
 1 file changed, 19 insertions(+), 19 deletions(-)

arch/arm64/boot/dts/qcom/sm8250.dtsi +19 ~~-19~~

index cf0c97bd5ad3..6fd30064ea74 100644
@@ -702,6 +702,25 @@ CLUSTER_PD: cpu-cluster0 {
 		};
 	};
 
+	qup_opp_table: qup-opp-table {
+		compatible = "operating-points-v2";
+
+		opp-50000000 {
+			opp-hz = /bits/ 64 <50000000>;
+			required-opps = <&rpmhpd_opp_min_svs>;
+		};
+
+		opp-75000000 {
+			opp-hz = /bits/ 64 <75000000>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+		};
+
+		opp-120000000 {
+			opp-hz = /bits/ 64 <120000000>;
+			required-opps = <&rpmhpd_opp_svs>;
+		};
+	};
+
 	reserved-memory {
 		#address-cells = <2>;
 		#size-cells = <2>;

@@ -914,25 +933,6 @@ rng: rng@793000 {
 			clock-names = "core";
 		};
 
-		qup_opp_table: qup-opp-table {
-			compatible = "operating-points-v2";
-
-			opp-50000000 {
-				opp-hz = /bits/ 64 <50000000>;
-				required-opps = <&rpmhpd_opp_min_svs>;
-			};
-
-			opp-75000000 {
-				opp-hz = /bits/ 64 <75000000>;
-				required-opps = <&rpmhpd_opp_low_svs>;
-			};
-
-			opp-120000000 {
-				opp-hz = /bits/ 64 <120000000>;
-				required-opps = <&rpmhpd_opp_svs>;
-			};
-		};
-
 		gpi_dma2: dma-controller@800000 {
 			compatible = "qcom,sm8250-gpi-dma";
 			reg = <0 0x00800000 0 0x70000>;

Signature · 1 line

2.34.1

Bjorn Andersson

Applied

2022-07-03 04:01 UTC #4 lore raw

In reply to Vinod Koul

Quoted 8 lines · Vinod Koul

This attempts to make W=1 free from warnings for all SM* dts files.
Bunch of these are releated to node not having valid unit address and being present under soc node. So moving it out fixed that. Interconnect node was simple rename to remove unit address which was not really valid for these nodes.
[...]

Applied, thanks!

[1/3] arm64: dts: qcom: sm8450: rename interconnect nodes

      commit: 12cfafe7b78876133474f4b3e44e0464a94f61b0
[2/3] arm64: dts: qcom: sm8350: Move qup-opp-tables out of soc node
      commit: e2eedde448a9be6202fd9965aef29d4b6607ee67
[3/3] arm64: dts: qcom: sm8250: Move qup-opp-table out of soc node
      commit: 191c85b852c122e9282797ae3ce2a36083f1e9a9

Best regards,

Signature · 1 line

Bjorn Andersson <[email protected]>