Skip to contentSkip to conversation

ceph: fix the incorrect comment for the ceph_mds_caps struct

PATCH Superseded Xiubo Li 2 participants 3 messages Jun 6, 2022 Ceph common code (libceph)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Xiubo Li

author
#0 lore raw

PATCH 1/1 ceph: fix the incorrect comment for the ceph_mds_caps struct

The incorrect comment is misleading. Acutally the last members in ceph_mds_caps strcut is a union for none export and export bodies.

---
 include/linux/ceph/ceph_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/ceph/ceph_fs.h +1 -1
index 86bf82dbd8b8..24622ecb9900 100644
@@ -768,7 +768,7 @@ struct ceph_mds_caps {
 	__le32 xattr_len;
 	__le64 xattr_version;
 
-	/* filelock */
+	/* a union of none export and export bodies. */
 	__le64 size, max_size, truncate_size;
 	__le32 truncate_seq;
 	struct ceph_timespec mtime, atime, ctime;
Signature · 1 line
2.36.0.rc1
#1 lore raw
Quoted 14 lines · Xiubo Li

The incorrect comment is misleading. Acutally the last members in ceph_mds_caps strcut is a union for none export and export bodies.

---
 include/linux/ceph/ceph_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/ceph/ceph_fs.h +0 -0
index 86bf82dbd8b8..24622ecb9900 100644

include/linux/ceph/ceph_fs.h struct ceph_mds_caps { · line 771

Quoted 5 lines
include/linux/ceph/ceph_fs.h +1 -1
@@ -768,7 +768,7 @@ struct ceph_mds_caps {
 	__le32 xattr_len;
 	__le64 xattr_version;
 
-	/* filelock */
+	/* a union of none export and export bodies. */

Also confusing :)

I think you mean "a union of non-export and export bodies."

Quoted 3 lines
include/linux/ceph/ceph_fs.h +0 -0
 	__le64 size, max_size, truncate_size;
 	__le32 truncate_seq;
 	struct ceph_timespec mtime, atime, ctime;
Signature · 1 line
Jeff Layton <[email protected]>
author
#2 lore raw
Quoted 18 lines · Jeff Layton
Quoted 17 lines · Xiubo Li

The incorrect comment is misleading. Acutally the last members in ceph_mds_caps strcut is a union for none export and export bodies.

---
  include/linux/ceph/ceph_fs.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/ceph/ceph_fs.h +0 -0
index 86bf82dbd8b8..24622ecb9900 100644
@@ -768,7 +768,7 @@ struct ceph_mds_caps {
  	__le32 xattr_len;
  	__le64 xattr_version;
 
Quoted 5 lines

include/linux/ceph/ceph_fs.h struct ceph_mds_caps { · line 771

Quoted 2 lines
include/linux/ceph/ceph_fs.h +1 -1
-	/* filelock */
+	/* a union of none export and export bodies. */

Also confusing :)

I think you mean "a union of non-export and export bodies."

Right. Will fix it :-)

Thanks!

Quoted 3 lines
Quoted 3 lines
include/linux/ceph/ceph_fs.h +0 -0
  	__le64 size, max_size, truncate_size;
  	__le32 truncate_seq;
  	struct ceph_timespec mtime, atime, ctime;