event/dlb2: fix advertized capabilities
PATCH 1/1 event/dlb2: fix advertized capabilities
1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support queue priority
2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
--- drivers/event/dlb2/dlb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/event/dlb2/dlb2.c +3 -2
@@ -61,11 +61,12 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_BURST_MODE |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), };
Signature · 1 line
2.25.1
Quoted 1 line · Timothy McDaniel
Be more descriptive,
Quoted 4 lines
1) Remove
RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support queue priority
2) AddRTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
3) AddRTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
file doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.
Quoted 31 lines
Fixes e7c9971a857a ("event/dlb2: add probe-time hardware init")Signed-off-by Timothy McDaniel <[email protected]>--- drivers/event/dlb2/dlb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/event/dlb2/dlb2.c +3
-3@@ -61,11 +61,12 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_BURST_MODE |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), }; --2.25.1
I will update both the description and doc/guides/eventdevs/features/dlb2.ini
Thanks,
Tim
Quoted 53 lines
-----Original Message-----
From: Jerin Jacob <[email protected]>
Sent: Thursday, June 9, 2022 12:06 PM
To: McDaniel, Timothy <[email protected]>
Cc: Jerin Jacob <[email protected]>; dpdk-dev <[email protected]>; dpdk stable <[email protected]>
Subject: Re: [PATCH] event/dlb2: fix advertized capabilitiesQuoted 1 line · Timothy McDaniel
Be more descriptive,
Quoted 4 lines
1) Remove
RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support queue priority
2) AddRTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
3) AddRTE_EVENT_DEV_CAP_RUNTIME_PORT_LINKfile doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.
drivers/event/dlb2/dlb2.c static struct rte_event_dev_info
Quoted 14 lines
Fixes e7c9971a857a ("event/dlb2: add probe-time hardware init")Signed-off-by Timothy McDaniel <[email protected]>--- drivers/event/dlb2/dlb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/event/dlb2/dlb2.c +0
-0@@ -61,11 +61,12 @@ static struct rte_event_dev_info
evdev_dlb2_default_info= {Quoted 17 lines
drivers/event/dlb2/dlb2.c +3
-3.max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_BURST_MODE |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), }; --2.25.1
PATCH v2 1/1 event/dlb2: fix advertized capabilities
In reply to Timothy McDanielThis commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the DLB2 hardware does not support such capability. This commit removes that feature from the reported capabilities feature set.
Additionally, two capabilities that DLB2 does support were not being reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of setting up the link between multiple queues and a single port. If the flag is not set, the eventdev can only map a single queue to each port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of configuring the queue/port link at runtime. If the flag is not set, the eventdev queue/port link is only can be configured during initialization
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated to match the capabilities actually reported by the PMD.
===
Changes since V1;
1) reorder capabilities flags to match the order that they appear in in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
--- doc/guides/eventdevs/features/dlb2.ini | 3 ++- drivers/event/dlb2/dlb2.c | 9 +++++---- 2 files changed, 7 insertions(+), 5 deletions(-)
doc/guides/eventdevs/features/dlb2.ini +2 -1
@@ -4,12 +4,13 @@ ; Refer to default.ini for the full list of available PMD features. ; [Scheduling Features] -queue_qos = Y event_qos = Y distributed_sched = Y queue_all_types = Y burst_mode = Y implicit_release_disable = Y +runtime_port_link = Y +multiple_queue_port = Y maintenance_free = Y [Eth Rx adapter Features]
drivers/event/dlb2/dlb2.c +5 -4
@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | -RTE_EVENT_DEV_CAP_BURST_MODE | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | -RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | +RTE_EVENT_DEV_CAP_BURST_MODE | +RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), };
Signature · 1 line
2.25.1
Quoted 20 lines · Timothy McDaniel
This commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting
RTE_EVENT_DEV_CAP_QUEUE_QOS, but the DLB2 hardware does not support such capability. This commit removes that feature from the reported capabilities feature set.Additionally, two capabilities that DLB2 does support were not being reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT= Event device is capable of setting up the link between multiple queues and a single port. If the flag is not set, the eventdev can only map a single queue to each port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK= Event device is capable of configuring the queue/port link at runtime. If the flag is not set, the eventdev queue/port link is only can be configured during initialization
Quoted 4 lines
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated to match the capabilities actually reported by the PMD.
Signed-off-by Timothy McDaniel <[email protected]>
Please fix
[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1 Missing 'Fixes' tag:
event/dlb2: fix advertized capabilities
Invalid patch(es) found - checked 1 patch
Quoted 56 lines
===
Changes since V1;
1) reorder capabilities flags to match the order that they appear in in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details--- doc/guides/eventdevs/features/dlb2.ini | 3 ++- drivers/event/dlb2/dlb2.c | 9 +++++---- 2 files changed, 7 insertions(+), 5 deletions(-)doc/guides/eventdevs/features/dlb2.ini +2
-1@@ -4,12 +4,13 @@ ; Refer to default.ini for the full list of available PMD features. ; [Scheduling Features] -queue_qos = Y event_qos = Y distributed_sched = Y queue_all_types = Y burst_mode = Y implicit_release_disable = Y +runtime_port_link = Y +multiple_queue_port = Y maintenance_free = Y [Eth Rx adapter Features]drivers/event/dlb2/dlb2.c +5
-5@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | -RTE_EVENT_DEV_CAP_BURST_MODE | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | -RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | +RTE_EVENT_DEV_CAP_BURST_MODE | +RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), }; --2.25.1
PATCH v3 1/1 event/dlb2: fix advertized capabilities
In reply to Timothy McDanielThis commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the DLB2 hardware does not support such capability. This commit removes that feature from the reported capabilities feature set.
Additionally, two capabilities that DLB2 does support were not being reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of setting up the link between multiple queues and a single port. If the flag is not set, the eventdev can only map a single queue to each port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of configuring the queue/port link at runtime. If the flag is not set, the eventdev queue/port link is only can be configured during initialization
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated to match the capabilities actually reported by the PMD.
===
Changes since V2:
Added "fixes" line that was present in original, but missing in V2.
Changes since V1;
1) reorder capabilities flags to match the order that they appear in in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
--- doc/guides/eventdevs/features/dlb2.ini | 3 ++- drivers/event/dlb2/dlb2.c | 9 +++++---- 2 files changed, 7 insertions(+), 5 deletions(-)
doc/guides/eventdevs/features/dlb2.ini +2 -1
@@ -4,12 +4,13 @@ ; Refer to default.ini for the full list of available PMD features. ; [Scheduling Features] -queue_qos = Y event_qos = Y distributed_sched = Y queue_all_types = Y burst_mode = Y implicit_release_disable = Y +runtime_port_link = Y +multiple_queue_port = Y maintenance_free = Y [Eth Rx adapter Features]
drivers/event/dlb2/dlb2.c +5 -4
@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | -RTE_EVENT_DEV_CAP_EVENT_QOS | -RTE_EVENT_DEV_CAP_BURST_MODE | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | -RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | +RTE_EVENT_DEV_CAP_BURST_MODE | +RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | +RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | +RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), };
Signature · 1 line
2.25.1
Quoted 20 lines · Timothy McDaniel
This commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting
RTE_EVENT_DEV_CAP_QUEUE_QOS, but the DLB2 hardware does not support such capability. This commit removes that feature from the reported capabilities feature set.Additionally, two capabilities that DLB2 does support were not being reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT= Event device is capable of setting up the link between multiple queues and a single port. If the flag is not set, the eventdev can only map a single queue to each port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK= Event device is capable of configuring the queue/port link at runtime. If the flag is not set, the eventdev queue/port link is only can be configured during initialization
Quoted 8 lines
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated to match the capabilities actually reported by the PMD.
Fixes e7c9971a857a ("event/dlb2: add probe-time hardware init")Signed-off-by Timothy McDaniel <[email protected]>
For here to [2] content, needs to be moved to [1] to avoid polluting the commit message.
Fixed and Applied to dpdk-next-net-eventdev/for-main. Thanks
Quoted 10 lines
===
Changes since V2:
Added "fixes" line that was present in original, but missing in V2.Changes since V1;
1) reorder capabilities flags to match the order that they appear in in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
[2]
Quoted 1 line
---
[1]
Quoted 1 line
doc/guides/eventdevs/features/dlb2.ini | 3 ++-