Skip to contentSkip to conversation

event/dlb2: fix QID inflight exploit

PATCH Applied Timothy McDaniel 2 participants 2 messages Jun 6, 2022 – Jun 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 event/dlb2: fix QID inflight exploit

If QID inflights is set to an invalid value it can cause the PMD to hang. This commit adds checks to make sure that the value is valid before programming the hardware.

Fixes 1857f1922ce2 ("event/dlb2: use new implementation of resource file")
---
 drivers/event/dlb2/pf/base/dlb2_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/event/dlb2/pf/base/dlb2_resource.c +1 -1
index d4c49c2992..548bebd068 100644
@@ -3701,7 +3701,7 @@ dlb2_verify_create_ldb_queue_args(struct dlb2_hw *hw,
 		}
 	}
 
-	if (args->num_qid_inflights > 4096) {
+	if (args->num_qid_inflights < 1 || args->num_qid_inflights > 2048) {
 		resp->status = DLB2_ST_INVALID_QID_INFLIGHT_ALLOCATION;
 		return -EINVAL;
 	}
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 9 lines · Timothy McDaniel

If QID inflights is set to an invalid value it can cause the PMD to hang. This commit adds checks to make sure that the value is valid before programming the hardware.

Fixes 1857f1922ce2 ("event/dlb2: use new implementation of resource file")

Applied to dpdk-next-net-eventdev/for-main. Thanks

Quoted 20 lines
---
 drivers/event/dlb2/pf/base/dlb2_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/event/dlb2/pf/base/dlb2_resource.c +1 -2
index d4c49c2992..548bebd068 100644
@@ -3701,7 +3701,7 @@ dlb2_verify_create_ldb_queue_args(struct dlb2_hw *hw,
                }
        }
 
-       if (args->num_qid_inflights > 4096) {
+       if (args->num_qid_inflights < 1 || args->num_qid_inflights > 2048) {
                resp->status = DLB2_ST_INVALID_QID_INFLIGHT_ALLOCATION;
                return -EINVAL;
        }
--

2.25.1