Introduce MediaTek CCI devfreq driver
v7 cover Introduce MediaTek CCI devfreq driver
The Cache Coherent Interconnect (CCI) is the management of cache coherency by hardware. CCI DEVFREQ is DVFS driver for power saving by scaling clock frequency and supply voltage of CCI. CCI uses the same input clock source and power rail as LITTLE CPUs on Mediatek SoCs.
This series depends on:
Chanwoo's repo: kernel/git/chanwoo/linux.git
branch: devfreq-testing
[1]: PM / devfreq: Export devfreq_get_freq_range symbol within devfreq [2]: PM / devfreq: Add cpu based scaling support to passive governor [3]: PM / devfreq: passive: Reduce duplicate code when passive_devfreq case [4]: PM / devfreq: passive: Update frequency when start governor
Changes in v7:
- remove the 'ret' printing from dev_err_probe().
Changes in v6:
- Remove unnecessary "goto" statement.
Changes in v5:
- Modify some binding description.
- Remove pre_voltage member.
- Not to enable/disable intermediate clock.
- Not to "put" resources that using devm_ variants.
Resend v4:
- CC interconnect maintainer.
- Change sign-off sequence in commit message.
Changes in v4:
- Add a maintainer in the binding document.
- Modify clock description.
- Add binding document into MAINTAINERS.
- Replace format specifier %d with %ld.
Changes in v3:
- Move binding document to 'interconnect' and rename it.
- Add COMPILE_TEST dependence symbol.
- Remove need_voltage_tracking variable.
- Move mtk_ccifreq_voltage_tracking() code into mtk_ccifreq_set_voltage().
- Add an interation limit in the while() loop.
- Replace 'cci_dev' with 'dev'
- Replace old_* with pre_*
- Remove of_match_ptr()
- Use module_platform_driver()
Changes in v2:
- Take MT8183 as example in binding document.
- Use dev_err() instead of pr_err().
- Use 'goto' statement to handle error case.
- Clean up driver code.
Johnson Wang (2):
dt-bindings: interconnect: Add MediaTek CCI dt-bindings PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
.../bindings/interconnect/mediatek,cci.yaml | 140 ++++++ MAINTAINERS | 1 + drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/mtk-cci-devfreq.c | 474 ++++++++++++++++++ 5 files changed, 626 insertions(+) create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml create mode 100644 drivers/devfreq/mtk-cci-devfreq.c
Signature · 1 line
2.18.0
PATCH v7 1/2 dt-bindings: interconnect: Add MediaTek CCI dt-bindings
Add devicetree binding of MediaTek CCI on MT8183 and MT8186.
--- .../bindings/interconnect/mediatek,cci.yaml | 141 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 142 insertions(+) create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml new file +141 -0
@@ -0,0 +1,141 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interconnect/mediatek,cci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Cache Coherent Interconnect (CCI) frequency and voltage scaling + +maintainers: + - Jia-Wei Chang <[email protected]> + - Johnson Wang <[email protected]> + +description: | + MediaTek Cache Coherent Interconnect (CCI) is a hardware engine used by + MT8183 and MT8186 SoCs to scale the frequency and adjust the voltage in + hardware. It can also optimize the voltage to reduce the power consumption. + +properties: + compatible: + enum: + - mediatek,mt8183-cci + - mediatek,mt8186-cci + + clocks: + items: + - description: + The multiplexer for clock input of the bus. + - description: + A parent of "bus" clock which is used as an intermediate clock source + when the original clock source (PLL) is under transition and not + stable yet. + + clock-names: + items: + - const: cci + - const: intermediate + + operating-points-v2: true + opp-table: true + + proc-supply: + description: + Phandle of the regulator for CCI that provides the supply voltage. + + sram-supply: + description: + Phandle of the regulator for sram of CCI that provides the supply + voltage. When it is present, the implementation needs to do + "voltage tracking" to step by step scale up/down Vproc and Vsram to fit + SoC specific needs. When absent, the voltage scaling flow is handled by + hardware, hence no software "voltage tracking" is needed. + +required: + - compatible + - clocks + - clock-names + - operating-points-v2 + - proc-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8183-clk.h> + cci: cci { + compatible = "mediatek,mt8183-cci"; + clocks = <&mcucfg CLK_MCU_BUS_SEL>, + <&topckgen CLK_TOP_ARMPLL_DIV_PLL1>; + clock-names = "cci", "intermediate"; + operating-points-v2 = <&cci_opp>; + proc-supply = <&mt6358_vproc12_reg>; + }; + + cci_opp: opp-table-cci { + compatible = "operating-points-v2"; + opp-shared; + opp2_00: opp-273000000 { + opp-hz = /bits/ 64 <273000000>; + opp-microvolt = <650000>; + }; + opp2_01: opp-338000000 { + opp-hz = /bits/ 64 <338000000>; + opp-microvolt = <687500>; + }; + opp2_02: opp-403000000 { + opp-hz = /bits/ 64 <403000000>; + opp-microvolt = <718750>; + }; + opp2_03: opp-463000000 { + opp-hz = /bits/ 64 <463000000>; + opp-microvolt = <756250>; + }; + opp2_04: opp-546000000 { + opp-hz = /bits/ 64 <546000000>; + opp-microvolt = <800000>; + }; + opp2_05: opp-624000000 { + opp-hz = /bits/ 64 <624000000>; + opp-microvolt = <818750>; + }; + opp2_06: opp-689000000 { + opp-hz = /bits/ 64 <689000000>; + opp-microvolt = <850000>; + }; + opp2_07: opp-767000000 { + opp-hz = /bits/ 64 <767000000>; + opp-microvolt = <868750>; + }; + opp2_08: opp-845000000 { + opp-hz = /bits/ 64 <845000000>; + opp-microvolt = <893750>; + }; + opp2_09: opp-871000000 { + opp-hz = /bits/ 64 <871000000>; + opp-microvolt = <906250>; + }; + opp2_10: opp-923000000 { + opp-hz = /bits/ 64 <923000000>; + opp-microvolt = <931250>; + }; + opp2_11: opp-962000000 { + opp-hz = /bits/ 64 <962000000>; + opp-microvolt = <943750>; + }; + opp2_12: opp-1027000000 { + opp-hz = /bits/ 64 <1027000000>; + opp-microvolt = <975000>; + }; + opp2_13: opp-1092000000 { + opp-hz = /bits/ 64 <1092000000>; + opp-microvolt = <1000000>; + }; + opp2_14: opp-1144000000 { + opp-hz = /bits/ 64 <1144000000>; + opp-microvolt = <1025000>; + }; + opp2_15: opp-1196000000 { + opp-hz = /bits/ 64 <1196000000>; + opp-microvolt = <1050000>; + }; + };
MAINTAINERS +1 -0
@@ -5757,6 +5757,7 @@ L: [email protected] S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git F: Documentation/devicetree/bindings/devfreq/ +F: Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml F: drivers/devfreq/ F: include/linux/devfreq.h F: include/trace/events/devfreq.h
Signature · 1 line
2.18.0
AngeloGioacchino Del Regno
maintainerRe: [PATCH v7 1/2] dt-bindings: interconnect: Add MediaTek CCI dt-bindings
Il 07/06/22 16:05, Johnson Wang ha scritto:
Quoted 11 lines
Add devicetree binding of MediaTek CCI on MT8183 and MT8186.
Signed-off-by Jia-Wei Chang <[email protected]>Signed-off-by Johnson Wang <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Acked-by Chanwoo Choi <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>Reviewed-by AngeloGioacchino Del Regno <[email protected]>Acked-by Georgi Djakov <[email protected]>--- .../bindings/interconnect/mediatek,cci.yaml | 141 ++++++++++++++++++
Uhm, I've just noticed that this is being put in the bindings/interconnect folder. The mediatek,cci is *not* an interconnect driver, but a devfreq one and is not using any ICC APIs.
Shouldn't this go to bindings/devfreq/ instead?!
Quoted 4 lines
MAINTAINERS | 1 + 2 files changed, 142 insertions(+)create mode 100644
Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v7 1/2] dt-bindings: interconnect: Add MediaTek CCI dt-bindings
Quoted 13 lines · AngeloGioacchino Del Regno
Il 07/06/22 16:05, Johnson Wang ha scritto:
Quoted 11 lines
Add devicetree binding of MediaTek CCI on MT8183 and MT8186.
Signed-off-by Jia-Wei Chang <[email protected]>Signed-off-by Johnson Wang <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Acked-by Chanwoo Choi <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>Reviewed-by AngeloGioacchino Del Regno <[email protected]>Acked-by Georgi Djakov <[email protected]>--- .../bindings/interconnect/mediatek,cci.yaml | 141 ++++++++++++++++++
Quoted 5 lines
Uhm, I've just noticed that this is being put in the bindings/interconnect folder. The mediatek,cci is *not* an interconnect driver, but a devfreq one and is not using any ICC APIs.
Shouldn't this go to bindings/devfreq/ instead?!
No, devfreq is not a hardware subsystem.
Best regards,
Krzysztof
PATCH v7 2/2 PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
In reply to Johnson WangWe introduce a devfreq driver for the MediaTek Cache Coherent Interconnect (CCI) used by some MediaTek SoCs.
In this driver, we use the passive devfreq driver to get target frequencies and adjust voltages accordingly. In MT8183 and MT8186, the MediaTek CCI is supplied by the same regulators with the little core CPUs.
--- drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/mtk-cci-devfreq.c | 440 ++++++++++++++++++++++++++++++ 3 files changed, 451 insertions(+) create mode 100644 drivers/devfreq/mtk-cci-devfreq.c
drivers/devfreq/Kconfig +10 -0
@@ -120,6 +120,16 @@ config ARM_TEGRA_DEVFREQ It reads ACTMON counters of memory controllers and adjusts the operating frequencies and voltages with OPP support. +config ARM_MEDIATEK_CCI_DEVFREQ + tristate "MEDIATEK CCI DEVFREQ Driver" + depends on ARM_MEDIATEK_CPUFREQ || COMPILE_TEST + select DEVFREQ_GOV_PASSIVE + help + This adds a devfreq driver for MediaTek Cache Coherent Interconnect + which is shared the same regulators with the cpu cluster. It can track + buck voltages and update a proper CCI frequency. Use the notification + to get the regulator status. + config ARM_RK3399_DMC_DEVFREQ tristate "ARM RK3399 DMC DEVFREQ Driver" depends on (ARCH_ROCKCHIP && HAVE_ARM_SMCCC) || \
drivers/devfreq/Makefile +1 -0
@@ -11,6 +11,7 @@ obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o obj-$(CONFIG_ARM_IMX_BUS_DEVFREQ) += imx-bus.o obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ) += imx8m-ddrc.o +obj-$(CONFIG_ARM_MEDIATEK_CCI_DEVFREQ) += mtk-cci-devfreq.o obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ) += rk3399_dmc.o obj-$(CONFIG_ARM_SUN8I_A33_MBUS_DEVFREQ) += sun8i-a33-mbus.o obj-$(CONFIG_ARM_TEGRA_DEVFREQ) += tegra30-devfreq.o
drivers/devfreq/mtk-cci-devfreq.c new file +440 -0
440 lines not on this page · raw message
Signature · 1 line
2.18.0
Re: [PATCH v7 2/2] PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
Il 07/06/22 16:05, Johnson Wang ha scritto:
Quoted 10 lines
We introduce a devfreq driver for the MediaTek Cache Coherent Interconnect (CCI) used by some MediaTek SoCs.
In this driver, we use the passive devfreq driver to get target frequencies and adjust voltages accordingly. In MT8183 and MT8186, the MediaTek CCI is supplied by the same regulators with the little core CPUs.
Signed-off-by Jia-Wei Chang <[email protected]>Signed-off-by Johnson Wang <[email protected]>Acked-by Chanwoo Choi <[email protected]>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 56 lines · Johnson Wang
The Cache Coherent Interconnect (CCI) is the management of cache coherency by hardware. CCI DEVFREQ is DVFS driver for power saving by scaling clock frequency and supply voltage of CCI. CCI uses the same input clock source and power rail as LITTLE CPUs on Mediatek SoCs.
This series depends on:
Chanwoo's repo:kernel/git/chanwoo/linux.git
branch: devfreq-testing
[1]: PM / devfreq: Exportdevfreq_get_freq_rangesymbol within devfreq [2]: PM / devfreq: Add cpu based scaling support to passive governor [3]: PM / devfreq: passive: Reduce duplicate code whenpassive_devfreqcase [4]: PM / devfreq: passive: Update frequency when start governorChanges in v7:
- remove the 'ret' printing fromdev_err_probe().Changes in v6:
- Remove unnecessary "goto" statement.Changes in v5:
- Modify some binding description.
- Removepre_voltagemember.
- Not to enable/disable intermediate clock.
- Not to "put" resources that usingdevm_variants.Resend v4:
- CC interconnect maintainer.
- Change sign-off sequence in commit message.Changes in v4:
- Add a maintainer in the binding document.
- Modify clock description.
- Add binding document intoMAINTAINERS.
- Replace format specifier %d with %ld.Changes in v3:
- Move binding document to 'interconnect' and rename it.
- AddCOMPILE_TESTdependence symbol.
- Removeneed_voltage_trackingvariable.
- Movemtk_ccifreq_voltage_tracking()code intomtk_ccifreq_set_voltage().
- Add an interation limit in thewhile()loop.
- Replace 'cci_dev' with 'dev'
- Replace old_* with pre_*
- Removeof_match_ptr()
- Usemodule_platform_driver()Changes in v2:
- Take MT8183 as example in binding document.
- Usedev_err()instead ofpr_err().
- Use 'goto' statement to handle error case.
- Clean up driver code.Johnson Wang (2):
dt-bindings: interconnect: Add MediaTek CCI dt-bindings PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver
Quoted 9 lines
.../bindings/interconnect/mediatek,cci.yaml | 140 ++++++ MAINTAINERS | 1 + drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/mtk-cci-devfreq.c | 474 ++++++++++++++++++ 5 files changed, 626 insertions(+) create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml create mode 100644 drivers/devfreq/mtk-cci-devfreq.c
Applied them. Thanks.
Signature · 8 lines
Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 4 lines · Johnson Wang
The Cache Coherent Interconnect (CCI) is the management of cache coherency by hardware. CCI DEVFREQ is DVFS driver for power saving by scaling clock frequency and supply voltage of CCI. CCI uses the same input clock source and power rail as LITTLE CPUs on Mediatek SoCs.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek