regulator: rpi-panel-attiny: Use backlight helper
PATCH 1/1 regulator: rpi-panel-attiny: Use backlight helper
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by backlight.h.
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.
--- drivers/regulator/rpi-panel-attiny-regulator.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/regulator/rpi-panel-attiny-regulator.c +1 -5
@@ -187,15 +187,11 @@ static int attiny_update_status(struct backlight_device *bl) {struct attiny_lcd *state =bl_get_data (bl);struct regmap *regmap = state->regmap; -int brightness = bl->props.brightness; +int brightness =backlight_get_brightness (bl);int ret, i;mutex_lock (&state->lock); -if (bl->props.power !=FB_BLANK_UNBLANK || - bl->props.fb_blank !=FB_BLANK_UNBLANK ) - brightness =0 ; -for (i =0 ; i <10 ; i++) { ret =regmap_write (regmap,REG_PWM , brightness);if (!ret)
base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
Signature · 1 line
2.30.2
Quoted 5 lines · Stephen Kitt
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by
backlight.h.
Quoted 8 lines
Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.Signed-off-by Stephen Kitt <[email protected]>Cc Liam Girdwood <[email protected]>Cc Mark Brown <[email protected]>
Daniel.
Mark Brown
maintainerQuoted 11 lines · Stephen Kitt
backlight_properties.fb_blank is deprecated. The states it represents are handled by other properties; but instead of accessing those properties directly, drivers should use the helpers provided by
backlight.h.Instead of retrieving the backlight brightness in struct
backlight_propertiesmanually, and then checking whether the backlight should be on at all, usebacklight_get_brightness()which does all this and insulates this from future changes.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: rpi-panel-attiny: Use backlight helper
commit: 8c92d9221d47ea97534888e2975ecd54896718d8
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark