Skip to contentSkip to conversation

staging: olpc_dcon: Use backlight helper

PATCH New Stephen Kitt 1 participant 1 message Jun 7, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: olpc_dcon: Use backlight helper

Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes.

Cc Jens Frederich <[email protected]>
Cc Jon Nettleton <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/olpc_dcon/olpc_dcon.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.c +1 -4
index 7284cb4ac395..b9d570e9ad3b 100644
@@ -517,10 +517,7 @@ static struct device_attribute dcon_device_files[] = {
 static int dcon_bl_update(struct backlight_device *dev)
 {
 	struct dcon_priv *dcon = bl_get_data(dev);
-	u8 level = dev->props.brightness & 0x0F;
-
-	if (dev->props.power != FB_BLANK_UNBLANK)
-		level = 0;
+	u8 level = backlight_get_brightness(dev) & 0x0F;
 
 	if (level != dcon->bl_val)
 		dcon_set_backlight(dcon, level);

base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

Signature · 1 line
2.30.2