misc: bcm-vk: Directly use ida_alloc()/free()
Subsystems (2)
PATCH 1/1 misc: bcm-vk: Directly use ida_alloc()/free()
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove().
Signed-off-by Ke Liu <[email protected]>
--- drivers/misc/bcm-vk/bcm_vk_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/misc/bcm-vk/bcm_vk_dev.c +3 -3
@@ -1401,7 +1401,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)bcm_vk_tty_set_irq_enabled (vk, i); } - id =ida_simple_get (&bcm_vk_ida,0 ,0 ,GFP_KERNEL ); + id =ida_alloc (&bcm_vk_ida,GFP_KERNEL );if (id <0 ) { err = id;dev_err (dev,"unable to get id\n" );
@@ -1500,7 +1500,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) misc_device->name =NULL ; err_ida_remove: -ida_simple_remove (&bcm_vk_ida, id); +ida_free (&bcm_vk_ida, id); err_irq:for (i =0 ; i < vk->num_irqs; i++)
@@ -1573,7 +1573,7 @@ static void bcm_vk_remove(struct pci_dev *pdev)if (misc_device->name) {misc_deregister (misc_device);kfree (misc_device->name); -ida_simple_remove (&bcm_vk_ida, vk->devid); +ida_free (&bcm_vk_ida, vk->devid); }for (i =0 ; i < vk->num_irqs; i++)devm_free_irq (&pdev->dev,pci_irq_vector (pdev, i), vk);
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 31 lines · Ke Liu
Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove().Signed-off-by Ke Liu <[email protected]>--- drivers/misc/bcm-vk/bcm_vk_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/misc/bcm-vk/bcm_vk_dev.c +2
-2@@ -1401,7 +1401,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)bcm_vk_tty_set_irq_enabled (vk, i); } - id =ida_simple_get (&bcm_vk_ida,0 ,0 ,GFP_KERNEL ); + id =ida_alloc (&bcm_vk_ida,GFP_KERNEL );if (id <0 ) { err = id;dev_err (dev,"unable to get id\n" );@@ -1500,7 +1500,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) misc_device->name =NULL ; err_ida_remove: -ida_simple_remove (&bcm_vk_ida, id); +ida_free (&bcm_vk_ida, id); err_irq:for (i =0 ; i < vk->num_irqs; i++)
drivers/misc/bcm-vk/bcm_vk_dev.c static void bcm_vk_remove(struct pci_dev *pdev) · line 1576
Quoted 5 lines
drivers/misc/bcm-vk/bcm_vk_dev.c +1
-1@@ -1573,7 +1573,7 @@ static void bcm_vk_remove(struct pci_dev *pdev)if (misc_device->name) {misc_deregister (misc_device);kfree (misc_device->name); -ida_simple_remove (&bcm_vk_ida, vk->devid); +ida_free (&bcm_vk_ida, vk->devid);
If conversions were this simple, why wouldn't the maintainer have done this already for the whole tree?
Are you sure these types of changes are correct? How did you test them?
thanks,
greg k-h