Skip to contentSkip to conversation

i40e: Fix VF's MAC Address change on VM

PATCH In review Jan Sokolowski 2 participants 2 messages Jun 8, 2022 – Jun 21, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: Fix VF's MAC Address change on VM

From: Norbert Zulinski <[email protected]>

Clear VF MAC from parent PF and remove VF filter from VSI when both conditions are true:
-VIRTCHNL_VF_OFFLOAD_USO is not used
-VM MAC was not set from PF level

It affects older version of IAVF
and it allow them to change MAC Address on VM,
newer IAVF won't change their behaviour.

Previously it wasn't possible to change VF's MAC Address on VM because there is flag on IAVF driver that won't allow to change MAC Address if this address is given from PF driver.

Fixes 155f0ac2c96b ("iavf: allow permanent MAC address to change")
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +4 -0
index 033ea71763e3..86b0f21287dc 100644
@@ -2147,6 +2147,10 @@ static int i40e_vc_get_vf_resources_msg(struct i40e_vf *vf, u8 *msg)
 		/* VFs only use TC 0 */
 		vfres->vsi_res[0].qset_handle
 					  = le16_to_cpu(vsi->info.qs_handle[0]);
+		if (!(vf->driver_caps & VIRTCHNL_VF_OFFLOAD_USO) && !vf->pf_set_mac) {
+			i40e_del_mac_filter(vsi, vf->default_lan_addr.addr);
+			eth_zero_addr(vf->default_lan_addr.addr);
+		}
 		ether_addr_copy(vfres->vsi_res[0].default_mac_addr,
 				vf->default_lan_addr.addr);
 	}
Signature · 6 lines
2.27.0

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by on v1 1/1
#1 lore raw

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c static int i40e_vc_get_vf_resources_msg(struct

Quoted 39 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jan Sokolowski
Sent: Wednesday, June 8, 2022 11:11 AM
To: [email protected]
Cc: Zulinski, NorbertX <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v1] i40e: Fix VF's MAC Address change on VM

From: Norbert Zulinski <[email protected]>

Clear VF MAC from parent PF and remove VF filter from VSI when both conditions are true:

(quoted diff) +0 -2
-VIRTCHNL_VF_OFFLOAD_USO is not used
-VM MAC was not set from PF level

It affects older version of IAVF
and it allow them to change MAC Address on VM, newer IAVF won't change their behaviour.

Previously it wasn't possible to change VF's MAC Address on VM because there is flag on IAVF driver that won't allow to change MAC Address if this address is given from PF driver.

Fixes 155f0ac2c96b ("iavf: allow permanent MAC address to change")
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +0 -0
index 033ea71763e3..86b0f21287dc 100644
@@ -2147,6 +2147,10 @@ static int i40e_vc_get_vf_resources_msg(struct

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan